From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736FBC4828F for ; Thu, 8 Feb 2024 20:40:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B70E06B0071; Thu, 8 Feb 2024 15:40:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B20AA6B0074; Thu, 8 Feb 2024 15:40:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E86B6B0075; Thu, 8 Feb 2024 15:40:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 808386B0071 for ; Thu, 8 Feb 2024 15:40:39 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FD4CA1DFB for ; Thu, 8 Feb 2024 20:40:39 +0000 (UTC) X-FDA: 81769804998.14.2CEFE30 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 5AE45100002 for ; Thu, 8 Feb 2024 20:40:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=a3cUsjCS; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707424837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xi7KPoWqAXAvNBxNNrO0Ip/xrQyxX/GcOKh52w1BrLI=; b=UIZBoom0qblZqKVV9vOCANW/cwC6LaGbOCKeUsiqli0e2vplCP/IdXGQ03JTtumQLtae0l 9yTh6F5Eqx7BOBvysRyfSb5IetciUzYv9o36GipwR0CRzfY3K+JQgDf56WgfwSrl3odKoD HiSRTGZnILsXCaqqmYUMP5GS4Xlmo7U= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=a3cUsjCS; dmarc=none; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707424837; a=rsa-sha256; cv=none; b=W740ixFU2sZWdhBRZ/EOxQayHku5b46UXotlJqNmrosa+oB1BYFUmtUs74tMnE3QEgmq1/ Xx+I0KVKrxD8iAqxpg5r0i/HePu3NvQhi1t2s2Sqi3Sn5JZszxzT10Me2fkdXM0gS+VcXg kDu1cI/VuvjwWnzI5DYuDV5i2bG2L34= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 65DD261EF4; Thu, 8 Feb 2024 20:40:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD111C433C7; Thu, 8 Feb 2024 20:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707424836; bh=hY5pCcHr8ug1jwsyK7SWJs6C1KS3DdykXBC+j+28xYM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a3cUsjCST8pixTIk2dgsBhj4sptXIGq5bEZE2KLUB8PmF+yW878fOAclqeiqzLTZs iHhH4SBJJhnicK7O6Fb7nLI/WoVxyOwk7KL4wmLTYvgcplfrILemWxGI18z9OFHOKf sKBXq++eGsUU4WQoVVv3AYXmgAQGTm4WfzPEt1cU= Date: Thu, 8 Feb 2024 12:40:35 -0800 From: Andrew Morton To: David Hildenbrand Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs/proc/task_mmu: Add display flag for VM_MAYOVERLAY Message-Id: <20240208124035.1c96c256d6e8c65f70b18675@linux-foundation.org> In-Reply-To: References: <20240208084805.1252337-1-anshuman.khandual@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5AE45100002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: eqkp3j78wmcq8tdy47uhacmqjs79kyqb X-HE-Tag: 1707424837-477064 X-HE-Meta: U2FsdGVkX1/k+BrT5Ik6fKZ9fraOdwyeD5dgK2rTYTI5q7OYXIf3bfDkP/22QHMuQxRkT9hNZvzv6RSUOyLFbk1tuq5Gt1/QeRPIFA7vyEz68F5fkvZ3uo/iKWTQ/y26IAEjub+r5KwBcfLU2mTNLKGP309ztjjN0AaGWaRDFeOaRucD0exQ8XCI03vMBK0E/olZgJJ3DbnBJCgpIc7CZnto2la04TMN6V2PudCRHycC3BRLu0HSwW43b0Qhrw+848jRlcesghyDkbJKTEdx9Dz5k4dcZvxwcVk9Lwt74AsrPWdsBpwksN5CsEBSMCRnZXryN9taAHMHe2nodG35zW2Zf217ylNiWCB1AVetNBR/m/Bk56/Lx/FzZL5rR2WHWZX3QOqqTwKXsCVj77lBzsUQCfi7xRLjjebxSUfeHxQpm9e1Lx3qmaqNoqLi4yKqicHmgVc2HPVzM8bLvpIBnn//pF1hHdZDFe0Du/gn0nGQjNTkbtr6iSC/KJVL5iTGifVcwIxPvCU9q78bjGPGjF4LuO+mTKQdsncO//UWH+Se4sl4ncvD/eGtobnChK+jtM1L6ZzuPaAx9kynada7RQNPufmH07i/7Us+P90kRPl6DSYkTbp0msFtDyDidTowEpj8ULlZnSrORSJg3mvSetcf52/QuLGEWt5LbxSvq9QMYyz/dR/gv3W0Xng90ChXOAB2+GjPWbrQZQf6uV0X28doOjzVNGbU6cxx8jtgnBYHs/CjPZX19Rm5OytHP/xJgIOC1iO5cc9lEpFw5ECRTdVjvPL6zHxYm4NGhZV0ofWQE+zFOPuLok7jrPTA/kmxaB4lZ/eUWcjEheHW41IrMC6tZY/rwTQ5W9+ci9MvniJWNq7xYBo8f3OfdwH1Lk14wwQrRBTzTftHIkKjrs0UBVLm8U1N/+AY6dxPglSXyS1ZxPsTJM2fwhsL+/rzbMd+KRvIbOiwJjTb3YBSEbc Hgo77ky3 xBec0BVXWgV5qfInq47ZT2xXtYmlLI4zBk7lNVeBiCfLJQmcc1pWjb3bYDV0d5kEH74Nfs+mOmMrT9I/FPZaz1pomLogVXx3USoJp8qTcP3/d8u8ecqrM+tVCWXb+2XdZHpG/MEobeS7HC4j3zOfYHaEmAFlLIL9tGiPdA4q5G63PJLYbA/zKF2UDkNK+/sV06njBnv+noFyX9g+rJPclSdwkHdjTNS4s+lFsVRuOtn/6xkGR2OJon/EwA/SVi7B6MsKSJU3kecIUyPZVgQfNMdCWJeE6YiGZWudVXGYDyESU3U+CscCLCMw5DSPH/ttZt97bKDo2iczoQx920OCVVI5Q3wT4DHB4JVT0s3Az7gMCu/KyXQJ7aD7DVNGUUPRIVvlUhZKHRA/B1EsTc+J4ciVpu+d5zsHJioEyBJdEQu29hznuJIXQ5pnPCzmRWoYlTgiFnECt3w/e0mCmsgtyNFS1uP8voiKD12O8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 Feb 2024 17:48:26 +0100 David Hildenbrand wrote: > On 08.02.24 09:48, Anshuman Khandual wrote: > > VM_UFFD_MISSING flag is mutually exclussive with VM_MAYOVERLAY flag as they > > both use the same bit position i.e 0x00000200 in the vm_flags. Let's update > > show_smap_vma_flags() to display the correct flags depending on CONFIG_MMU. > > > > Cc: Andrew Morton > > Cc: David Hildenbrand > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-fsdevel@vger.kernel.org > > Signed-off-by: Anshuman Khandual > > --- > > This applies on v6.8-rc3 > > > > fs/proc/task_mmu.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index 3f78ebbb795f..1c4eb25cfc17 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -681,7 +681,11 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > > [ilog2(VM_HUGEPAGE)] = "hg", > > [ilog2(VM_NOHUGEPAGE)] = "nh", > > [ilog2(VM_MERGEABLE)] = "mg", > > +#ifdef CONFIG_MMU > > [ilog2(VM_UFFD_MISSING)]= "um", > > +#else > > + [ilog2(VM_MAYOVERLAY)] = "ov", > > +#endif /* CONFIG_MMU */ > > [ilog2(VM_UFFD_WP)] = "uw", > > #ifdef CONFIG_ARM64_MTE > > [ilog2(VM_MTE)] = "mt", > > Reviewed-by: David Hildenbrand I'm thinking Fixes: b6b7a8faf05c ("mm/nommu: don't use VM_MAYSHARE for MAP_PRIVATE mappings") Cc: