From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6B40C4828F for ; Thu, 8 Feb 2024 17:30:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 521F96B0080; Thu, 8 Feb 2024 12:30:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D3B86B0081; Thu, 8 Feb 2024 12:30:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3733F6B0082; Thu, 8 Feb 2024 12:30:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2452C6B0080 for ; Thu, 8 Feb 2024 12:30:33 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EC9B4140F28 for ; Thu, 8 Feb 2024 17:30:32 +0000 (UTC) X-FDA: 81769325904.15.64BC8EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 0A96E1C000C for ; Thu, 8 Feb 2024 17:30:28 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i3GwLrT0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707413429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WO5yVARso2Jg8Z0OQG5achjKt7tNGYabD1QNw/gc16k=; b=qVfvJ3NJFnP2z9jy03ac5vYY1/6m/+74WrO171rmkz+uuiKMwG4EBa9DdfQY+exyqBmlFf gXtlBVMKcOOMilJeqJZsJ5BZcPnD5pY6UG6HOyRnOm/GCleUip97v81MwQXLa+rivj+/l7 hzDggGHmZN37AAHnd8rJ7CIxNNZDW3E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i3GwLrT0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of alex.williamson@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=alex.williamson@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707413429; a=rsa-sha256; cv=none; b=JCnamMW3UJqf4dOYVbA7mQXslRXekQLYVIjrKmA8wtkkSfCq6Y5Pyj4URCm0aykuox+NrU JLvqQ5R263NKmIhbKX4h50k2r/dyv7UVpKIxja8Gin6+sS1cuwryT7eZ4vMQwVIV1emuIG wDNrSUN/KfTI4B8ZPs/8mosxYfbiVBo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707413428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WO5yVARso2Jg8Z0OQG5achjKt7tNGYabD1QNw/gc16k=; b=i3GwLrT0dAmR9XJHheCPh0NIu8maubQtWu1TFhscHUUUBlzHaPr9MbS4IEVxbFIbvIhi0M 4Z14HGi8n3+njkKdLLgkFSW45Htebz2RHO+5MsTkZzK+oaxeoBQwdQTCv9LUw9q91D6P6Y 6zqnOfdSzPwsFZa+1U7GtWgeE5x3JtQ= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-I0B4YbSoNOi-3yW-BLjOhQ-1; Thu, 08 Feb 2024 12:30:26 -0500 X-MC-Unique: I0B4YbSoNOi-3yW-BLjOhQ-1 Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-7bf4698825eso166600139f.0 for ; Thu, 08 Feb 2024 09:30:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707413425; x=1708018225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WO5yVARso2Jg8Z0OQG5achjKt7tNGYabD1QNw/gc16k=; b=aNSrVdM0O1R5+feKq/2seWh323SpF6N/rAj99Vp5f9lG+0OIQjRqMtFPzU7a9xyPPA TPPVzfr/Q7ca3kVajIAsNm1YTGLjU/1BsZOSzL+UWG48mPw4JEQTEn/sjtVVdrii5D2T 8HG2t80CBf8ILomV3uC5JIV8lofDedN9cIHNePLCYNSja93Z5P7A5ErSwTm7V1jAreHq nhp2t4fXjqDylJ0S8hQ7E9JPUkb+kVifBa8X842LEjA8VnDVkHX2PHVMm0nmTnPokzfh by72n70wu2IYmN1RfTysTuVXjur/GK+S52oTbyCjn+woi0w7Twvo/sKyTBvYBeJmWKi4 kf/w== X-Forwarded-Encrypted: i=1; AJvYcCVb2blgshkwtqKDw9kDCnlTtbEkJ7z6L8gDU1jG1CKdKM9iLvjXlvcjK7M+9U5Ak5mdZ8bHWAomWPhOygb12NcO2hk= X-Gm-Message-State: AOJu0Yy6nhzJRxOTvuER+dBp7k7Oq+Oa8ZgJWUoU7H7bu3UOYT7ZXblb WncVAy2ZKvepbAgQOqdrdLw9EnG3DwLUe/E3EVMGMqy44HAfT7HKcOE6iq38lY7dpQCwzIDnaKz sq/9SCPkILjsP0iET1Yfnc/mqIC0A0KbwUdy/HHUkW+HX9wnW X-Received: by 2002:a5e:c015:0:b0:7c3:ec35:8df7 with SMTP id u21-20020a5ec015000000b007c3ec358df7mr316088iol.3.1707413425281; Thu, 08 Feb 2024 09:30:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5cjmBmVzOqD9itRTqfUhfQRTZ1e6fo4necDLXqiHFxdWo0ezcppkqw1/b39eYhNrgHWeqZA== X-Received: by 2002:a5e:c015:0:b0:7c3:ec35:8df7 with SMTP id u21-20020a5ec015000000b007c3ec358df7mr316054iol.3.1707413425002; Thu, 08 Feb 2024 09:30:25 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXsISWUx7+IbC4yWXLMIWdDubVunoNs0LamFRSmQHr/gq05or7/HwqOdJrrI7pQBSHJpi9tpnPqrfcgnndV++FpnI0A+XQmbrKQ43C4hGgaLaPvagxEPWQLWW56VJoy6E7RsYEFYxz9pjZSy+AjG0QWEIlNERpQxR5S3LZcgAzNBjq1hMLhXa/UFH/xd/a1SSxG4Q8k2nPztDLBNUInVOQkxtBcKotGfo7OKFejQfUS6h1J9OoM8ESlyTBQQ5w1IUAJtfga9XvDD70WSfCy4nqvj6SZjjA/SBVVIou7d1Bu8R2QyUMtY/8PHHGw7uTNsYp+OjNEv72Hai3e60llbXarCHiFbpbTD/Vo7YXdORPvdUR6Xqs2hQvGpQUtd8D7xgmnTXZXtrqEjty5iXgh72u5BXKPCFIMsRmpI63NtWN1V1iNchA4B0vUSI4uhi868kHoZqWoWuFoVXKfvEPf8tzSJMq/8VC63Znrj7a7j1jDE3AHby3SDniICgaLs1W401btgaav0KbqJyitTzx7irAEuL5xwNv2ftYUvxCykaFHMYvwJ/KDKnMOT7iydK21L8gd4e/joTLvoiyB+dEZhMtl/lpTVpUWtcvqsHpE9BssR269GYgXBUnsakMQJD4ltrWn3JYGgpIqLcYILsChNywx8xGPJydZi71+SxB40Nk1GXnJY+uD4taEfwa4FViWKOrtvPA6+txZ3hwmQkM2iZOFZMrhYKqOq0Qq7koCzMSO7rTLhuINcpV0GdSClcGxYa1UKsjIkwjyH5s9SHlQ3Tw+FkxieeHLXrA9mFxYWS07xwPfr1OFSNdMhtrAKMcS97HXlRAldNP1OS+0d6QczdkXN9IAOajk60SR8iWYiILXxbPOCfysj85ecfzdeVGI9XiRHzfM6BgnGmVS+3aa9xurS7THRYAkMcI3huwcHOs2QX/Vhe+zBU2hUUStkn 6sDKVnnq 6LOIAsRALIOLFClLe35uMH0XBzvzIR6a2NOcOc5hhg2cPAI1s2LTiuTVXbLWmaAuO3AAh36/6dsRdG1fITBEeXY1QgHbfWxTkJVyvW6mOXuWMg5qK7r3uur5NMapW1hneooWpQrZSW47GvNnta61AY24w5t9GodVHVSgyx1C5K6rkVf99WE1rxOny6XPUYCTxc+hzSIBk3rmzZdBYSCImCrf1x Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id a18-20020a056638005200b00470fe9f837fsm972435jap.29.2024.02.08.09.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 09:30:24 -0800 (PST) Date: Thu, 8 Feb 2024 10:30:22 -0700 From: Alex Williamson To: Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 4/4] vfio: convey kvm that the vfio-pci device is wc safe Message-ID: <20240208103022.452a1ba3.alex.williamson@redhat.com> In-Reply-To: <20240207204652.22954-5-ankita@nvidia.com> References: <20240207204652.22954-1-ankita@nvidia.com> <20240207204652.22954-5-ankita@nvidia.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0A96E1C000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: h7fmzzrw887f4bor47dn5nr4nng61az3 X-HE-Tag: 1707413428-312178 X-HE-Meta: U2FsdGVkX1/+yp0CnDXZEx42r+/gNEKAMF1h9mFpDh1YY+H/Jn/tVPf3jTiCPAecJQd/YKNaCXsbiF/FZ2HcOv6BP0YRW0Oz+T6+tp1cW7zu8zZHU/Vf8Le+8MpjyyCfGUqnCewoYbJxCadyBFSvpnNnF5Dh+lA5CQ8hyop1ixCS/y67aip0Xkq64+TrwrA/bnqqam7qSlSNLB/1KBFpk+S8+ucqZRIZHCg8eenAhb6BcPYXe9fRAO76CidRpu2GSF+sruL6AgeY5su8DFqAfYuJRYx8MnR7Oj4qjIxzUgsi7HeRaXlVy6sT/ooC2I1X9vS4vb3DbPikq7ka+/yf5wiB9MpiSKYCYK34aUgVPeH7bVPXrkUW7TSo4viTFbCZg7a0fuskoEw/9PpyXtR97dGjCs6CsJ2yO9g/PYPw6I7k6DuVT/77ssFHjEqHwd7Zw67Q20eZXxglx7CMhydjOxkD5x8Ft/yylMiv/xr7TEAm9DNqu55PKpe+KLEozpvEM9aExMbYNbSc37REvLHTFkr0t1KHfUnl/2cDaQAziv+/wVTT81SB7VOwym/+Pb5qIiIRYCW0fIbYCe/mBClzrjHt/mQS6mGYK4bm31nAQhMfyrMWtR+YGeyMTVasxadHMcCxAd2vn0WR2SCrqIQGgcnBBS1ApCngE6qW/pgrju70oYkKIBb5uxqXVCUaJb9sf8spWenX5ge/eOHh0a7CqtlDMdTG+SqgoA0wPKH74/JcZPL21kJUjvTqwRKHj0xsnMxdpEvXXRKPw1r6q5WeWJkBYfPbKGn70xRWDszfkJtsDechsf79M67JfCsH4qJ8BMqPurKqFKAOIa96kiBOFauxPP7rS7Wlrni3n35Cr0+QY1Xws/CwhHsRrnsKh0RLMworTtzcFRxJYpZBOJ4uF/YNdJmM2LTXgDRN2AcD2UOy5kMqnJv2a2CNtzXatGE4bWEQMKQL2ALeO1cwTAx P3gj9D7g 45TE0Ut50NjHAZPOWNxagoBegJSy5sz8wSJPGFVo7mzy1aTznFzz2Y66n1w8+c5NrObChl00i0cTSe4PUCoceMzYTFy96+5zx3wZaU+sisBP30obQ3pWQG/yIKTjFgpLcrR4X+MZpio4mO9D3XlvPQBIkjAoPnYSkttGZOH4DB9p5gyDYMt0kedIwzMx4ipQIT6X2lXozt+Q9K6Mg739inCkWhO2yB8iBd6YByOL3xCRWi4zyAeyBB3k5zjyxkb3goXFx73LLzyXuoD+Q+YMVkiZu3SVi008XWgrYN7WFW9EFEho78wAqjsJh9TFnxESWJrbdffCHUyX5XafZJMISZFYjw0Mqh695Y05bKgmMWJtHgCL7Yepi60RKNLi8awmXBAE4CLwnix4Y/gqQPUxByPS0N+3FD6Y5OduDXTTE+6wnm3SrweQ5y0RgNtR7YSspar7diN3et/UGmlLfZP06SqCDeQmhNJbH6D5L X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 8 Feb 2024 02:16:52 +0530 wrote: > From: Ankit Agrawal > > The code to map the MMIO in S2 as NormalNC is enabled when conveyed > that the device is WC safe using a new flag VM_VFIO_ALLOW_WC. > > Make vfio-pci set the VM_VFIO_ALLOW_WC flag. > > This could be extended to other devices in the future once that > is deemed safe. > > Signed-off-by: Ankit Agrawal > Suggested-by: Catalin Marinas > Acked-by: Jason Gunthorpe > --- > drivers/vfio/pci/vfio_pci_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c > index 1cbc990d42e0..c3f95ec7fc3a 100644 > --- a/drivers/vfio/pci/vfio_pci_core.c > +++ b/drivers/vfio/pci/vfio_pci_core.c > @@ -1863,7 +1863,8 @@ int vfio_pci_core_mmap(struct vfio_device *core_vdev, struct vm_area_struct *vma > * See remap_pfn_range(), called from vfio_pci_fault() but we can't > * change vm_flags within the fault handler. Set them now. > */ > - vm_flags_set(vma, VM_IO | VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); > + vm_flags_set(vma, VM_VFIO_ALLOW_WC | VM_IO | VM_PFNMAP | > + VM_DONTEXPAND | VM_DONTDUMP); > vma->vm_ops = &vfio_pci_mmap_ops; > > return 0; The comment above this is justifying the flags as equivalent to those set by the remap_pfn_range() path. That's no longer the case and the additional flag needs to be described there. I'm honestly surprised that a vm_flags bit named so specifically for a single driver has gotten this far. It seems like the vfio use case for this and associated FUD for other use cases could all be encompassed in the comment where the bit is defined and we could use a name like VM_ALLOW_ANY_UNCACHED or VM_IO_ANY. Thanks, Alex