From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D131DC48260 for ; Thu, 8 Feb 2024 09:20:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 333706B0078; Thu, 8 Feb 2024 04:20:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E3AD6B007E; Thu, 8 Feb 2024 04:20:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AB776B0080; Thu, 8 Feb 2024 04:20:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 07F006B0078 for ; Thu, 8 Feb 2024 04:20:05 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9815440D18 for ; Thu, 8 Feb 2024 09:20:04 +0000 (UTC) X-FDA: 81768089928.01.810F3D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 9AA0A40004 for ; Thu, 8 Feb 2024 09:20:02 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dZsMqVVD; spf=pass (imf27.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707384002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cfySpqWl1TsOvDzqqREgn2XTm5VZ4qycsTnqTDrC3S0=; b=AQNP0FKTlm7VqMRoPbBpe1ykyER9bAU/h/Bp8+eCdhdaDtLkEWIXLRnwQ4e+yrtzU7XG1x 6Jm40qYdZctVEKHxCBUFTAu1avg4yYKQxkfm6s+xGSZ9q1sxtazRQzZl2QislGq0WvSBPN JtcP52HUSge5Muo11QS8N9cUBzIYYSA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707384002; a=rsa-sha256; cv=none; b=SdrLdYi1ST/WGw0mcHlok8MXxS4dMVRl9LZfvBwPDIBpr4470lfq225ztrF8DVFz19CjcC unDgXIjsVCuCqao8mmSFc1ncdjhSERaGGD/VXFB5FiioJ4Ka+kSWUJVPm4auaJNybuCCwD nE3D91uTTh5zlM3mP+mok/bNjutRTUE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dZsMqVVD; spf=pass (imf27.hostedemail.com: domain of oleg@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707384001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cfySpqWl1TsOvDzqqREgn2XTm5VZ4qycsTnqTDrC3S0=; b=dZsMqVVDFWVrhgqR1cGr4IQq8JDjT8lZ3C7H0sWxMAgcrG+UjUmP9RXb3yxxHv99eEPYyW W88FZsExeKZlROZGXwe2MoWoufla/Z/buqYeYuc2akRfQMEBgBUp/4h7BN553CiP2UatnF flFj0o9ZKmcitK9XGl4QhJikeEXED1o= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-0mXpjo0ZPqSXA07eDs2xrg-1; Thu, 08 Feb 2024 04:19:59 -0500 X-MC-Unique: 0mXpjo0ZPqSXA07eDs2xrg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE1583C23FCC; Thu, 8 Feb 2024 09:19:58 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.253]) by smtp.corp.redhat.com (Postfix) with SMTP id F273711216; Thu, 8 Feb 2024 09:19:56 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 8 Feb 2024 10:18:43 +0100 (CET) Date: Thu, 8 Feb 2024 10:18:40 +0100 From: Oleg Nesterov To: Christian Brauner Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Tycho Andersen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" Subject: Re: [PATCH v3 1/1] pidfd: implement PIDFD_THREAD flag for pidfd_open() Message-ID: <20240208091840.GA19801@redhat.com> References: <20240131132602.GA23641@redhat.com> <202402081434.9e1ded3-oliver.sang@intel.com> <20240208-empfinden-annalen-da6c77b0fefb@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240208-empfinden-annalen-da6c77b0fefb@brauner> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Stat-Signature: 4ms84j1xrq5nzko8dow643ytat3doffe X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9AA0A40004 X-Rspam-User: X-HE-Tag: 1707384002-813422 X-HE-Meta: U2FsdGVkX1+MbYuXWQGsRyVA4YKX9Ds8Y+LbV5MIXJ8NSj1M6CUFbLBw7hcRNNs4OHCMNeVCs/kcZrubQgYBVHxH+Fktq35dlOdytN8/A7lzGwBEB7sH9/M8GJ3oeIzitZescgo46E9VbH0i+FkfX3iLBQBkdplooZ/uRmJxABrpJ0SEgw0ORQmTbmzKEWnbA7214TYuOsWvbosUm/zveK1lfkLW+muYHsjZMW1bCTw9PWzOUFoP1bOmm4aNK7TLB6v8Se4NdeFPkqiiXGUmBR+H9YANsQ3OC23U40SKaP3G1742msongZJjWPuPtDCGCqayBpdmxGo5bS289pQdICyhXJ8u/wpjCE3Dg7VOV8DECyTbQlOmASo9Qc4MdKxKzIWFZYDSfqozXT15rbC8MLejfcjQx2PJPX/JgFZ6WUYu4UbfsGIv7OgfryB622Mno3K3ZA+U/luIpzxsDdShtcjTWj8rGvrLtmcr0VsQM/R2dGkbwr36bJc+kWASmNpuBvgOm90k7Ys1Zv5dvjuo5mO2uy5jNn8rqtN9l+CmRTzrMZin55du8+nV9nh4eF8A09OeXeeUfpzT7cGZQUwi3EVZmHKX1+AfXULWK8oRiPEj4yZHMRqq2P9F9hvwsxFG14opBZjmTiIn4LpWX2CpAiwcolFVT3vlZ/+krCnCS47CS2LFEfFqSASuqH4uOSnRXD789WSjXipXF9DDEycJFdwnxp5yM7ALy7hlOlBOuSZPTBXLABu0JarRgY9REENpU5t+QKcMXPAZt5CQh0xFDPxtcqYaQrHe9Y0L89Tc9JU8OqE+4NXLUUaZLoCLSbZAUWaFb6DCZBkw7POdYJkdMAjpON1K4SYvfRHY1oBo+fDOjSi9ZsUvsgmjk+9n+TgjAPcjWJ6fBpDrkpVzx0iFaxwXjc+luzdVDcc/dpj8vH4A36EcAs8hqKX8bAa8fVzBh7vqP6gBMbe4keL1/1w Q9mdImM2 C3QOqUSdTnDOZ9KRS9ueirWF8CPJ1LUbR5StqX+DWbKFO9W/3Rl1JIBCw+fHfQF7nOROde18ennQDKEQWlESxixP1OOsfVCdGD4iOuRzwZlwgesaiAO8Yl9Wc64r7740Raiz5tfd7D6vHMQdnjn/WmJXRTfzyKKvnqk79KN8l+aBYVKzTZlzTn+zWwMk1H+IY2ZIp9DuCl04pn9uc3lNa4sGllMadkg4kApdYCy9FMzraRUjYDtA03YSYURo5TIxY7kCXJqTxm/FjEZxKx+3nE4zJ+qs9f2fVwKGVZBc7ToPCFHcWqXJPG6NiILAL38aoVhJV9VwXSe8KuxTvsTYeWofKOoA9Dmea60lEfuMRXyKXLurRwVbzH1jQ0WI25BXTLB1AjiGY4Vo6or6gNW3ATgRClpuYKJISAr6w+ObHau8JMr8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/08, Christian Brauner wrote: > > On Thu, Feb 08, 2024 at 03:54:44PM +0800, kernel test robot wrote: > > > > > > Hello, > > > > kernel test robot noticed "last_state.load_disk_fail" on: > > > > commit: aa9c201b150f15cf12e8df8af531b2c74ae1a8fc ("[PATCH v3 1/1] pidfd: implement PIDFD_THREAD flag for pidfd_open()") > > url: https://github.com/intel-lab-lkp/linux/commits/Oleg-Nesterov/pidfd-implement-PIDFD_THREAD-flag-for-pidfd_open/20240131-213408 > > base: https://git.kernel.org/cgit/linux/kernel/git/vfs/vfs.git vfs.all > > patch link: https://lore.kernel.org/all/20240131132602.GA23641@redhat.com/ > > patch subject: [PATCH v3 1/1] pidfd: implement PIDFD_THREAD flag for pidfd_open() > > > > in testcase: boot > > > > compiler: gcc-12 > > test machine: 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz (Ice Lake) with 128G memory > > > > (please refer to attached dmesg/kmsg for entire log/backtrace) > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-lkp/202402081434.9e1ded3-oliver.sang@intel.com > > > > > > > > The kernel config and materials to reproduce are available at: > > https://download.01.org/0day-ci/archive/20240208/202402081434.9e1ded3-oliver.sang@intel.com > > > > > > as in dmesg in above link: > > > > LKP: ttyS0: 1408: can't load the disk /dev/disk/by-id/ata-SanDisk_SDSSDH3250G_182971800454-part1, skip testing... > > > > we know this should be related with some early issues but we failed to figure > > out. so here also attached parent dmesg as dmesg-e0ee7b583f.xz FYI. > > I have a hard time seeing how this would be caused by any of Oleg's > changes. Plus, the merges from the vfs tree linked under "url:" above > are all pretty out of date? Yes, the patch under url still has the extra trailing ";" after "if" so pidfd_prepare() will always fail. Fixed by Tycho. Oleg.