From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B6D3C4828F for ; Thu, 8 Feb 2024 03:34:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB0B66B007D; Wed, 7 Feb 2024 22:34:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E60CF6B007E; Wed, 7 Feb 2024 22:34:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D50086B0080; Wed, 7 Feb 2024 22:34:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C9C1A6B007D for ; Wed, 7 Feb 2024 22:34:06 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9EBBFC01C0 for ; Thu, 8 Feb 2024 03:34:06 +0000 (UTC) X-FDA: 81767218092.07.F309ED7 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf30.hostedemail.com (Postfix) with ESMTP id CB40280002 for ; Thu, 8 Feb 2024 03:34:04 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Yj0ADKvy; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf30.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707363244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YZky5AyAre/dMpZf5i1mGaM6Xcv4ytjnlRQvYEYmfJ4=; b=ndjV11FnTddyXWPLbOL41WhxWdaX9VFIJsp6X7IbhQP3TBw5Ddk+Gmiu6nifqf5O7nOlMh /p0BdjM+gLZZuLT4iGbdx9iA858tSelemWNWyMv+Uf5V9k7AVLuSBSlV+8HEpqZiyEZd2e CIXPKudf5sQK6R1zvyJqzwdcISc6/N8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=Yj0ADKvy; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf30.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.208.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707363244; a=rsa-sha256; cv=none; b=os1NWuGtLGgenzZPFLHtW4EFftE3p7ikqj6OYFQ5z7ExZZBwR3CG6/rwetR/Wdg7oq5dZu vI2gJ/fMMcBm8D4vEHE/NXXpOAQoHsGN2/xajJQqyLsJ0pGqNmO+le82KyWSk4urXEpyEV +xdTpWS4mLIARTY+HkbxckPvhclZidE= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-55fe4534e9bso1585918a12.0 for ; Wed, 07 Feb 2024 19:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1707363243; x=1707968043; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YZky5AyAre/dMpZf5i1mGaM6Xcv4ytjnlRQvYEYmfJ4=; b=Yj0ADKvyou2ZDoAB0BKQ1Tikw4yIWXU22yJL4RdszzByKk0M1g67KHg3LnIpBC9Az6 Rep3kF3ZCWtVNSs2MDORmf34iUJwR8jXBbhOnLsUuGGVEV+UtNW1v8t4Tv27qUqJw6uh r5tN8v/vGJ50g9WzuvPahh6F27P81Cz4UuxcD6SnHxFMcnvjsvCScTYcIiup9Q1+lRps DGN+3wWOJ6OtqCDfezE/XdGxbNcIJl2+0PQP4AZo+ryjwRzmHZnEj7NiDlpaIsfTzPv0 8kINp01qu/iCLAXwPcIqNXaQlBA5YTzERSTHYw9KWq4SgNQBGr+HOgcR3CRGSboX+/Bm 5OeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707363243; x=1707968043; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YZky5AyAre/dMpZf5i1mGaM6Xcv4ytjnlRQvYEYmfJ4=; b=eJx8dXCZmTKVlurnSB8uQK75ti8QxToxhhIRXnACX5fmUeU0hFhUPEjzfYGwslXoK/ 3vREvDJfgDZPXRLaROITXVa4JWFb06oRRcE+ZBMS6jP5wv+VVYorSyPTnvgXeNan1WWI nLJpJwZ7JdSRLqK0XB2XFa83W1f6/uZ7FsT0qHvUtOPsElzUh/pMICQ55M3B82i+xwaD xhPU8C2r6ECM4SALiwu04GTcBGu390uh9M35ORlkwK950xyXL3ZLrgvS2W3dWf0B0CX4 50I1lmnzSv1MidSsn8euRCdn8a9+rtq3VTL730nWC8v4Yw+4YBhoE6ogGQMxDZZN9jzM ZGcQ== X-Gm-Message-State: AOJu0YxztSUwHZEYV/xp4c9atvpZ3OoNW2VQXbN7lPBNLMINiUIwesem qftbktosrzp9RuL/dgAfCTPkqtit+LT3fOQVr9B3RyLpgxIXLejro/d9tw1U5UUg4k/4iZeEev5 d X-Google-Smtp-Source: AGHT+IFwURbzc5dJWII2nIbroF6k8NHi8ssar3QgC4kUORyGyMKECLVzF9J4kCH9bUstrsepD5InoQ== X-Received: by 2002:a17:906:a854:b0:a26:c376:d1dc with SMTP id dx20-20020a170906a85400b00a26c376d1dcmr5718939ejb.70.1707363243228; Wed, 07 Feb 2024 19:34:03 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWodZbXtkk5077xIPMkHscFYscinPzlfZvM+W4I0NAQol5gcGs1qITat1+xhJtAG54FMxzc92nhjFI5b3pE66pbRks= Received: from localhost ([2a02:8071:6401:180:f8f5:527f:9670:eba8]) by smtp.gmail.com with ESMTPSA id lb7-20020a170906adc700b00a38378d11e7sm1434210ejb.132.2024.02.07.19.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 19:34:02 -0800 (PST) Date: Thu, 8 Feb 2024 04:34:01 +0100 From: Johannes Weiner To: Zhongkun He Cc: akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/z3fold:remove unneeded spinlock in z3fold_alloc Message-ID: <20240208033401.GC185687@cmpxchg.org> References: <20240204131543.1469661-1-hezhongkun.hzk@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240204131543.1469661-1-hezhongkun.hzk@bytedance.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CB40280002 X-Stat-Signature: xzsnr4gzn8ncunaarntp7hmtmjztbx5z X-Rspam-User: X-HE-Tag: 1707363244-797190 X-HE-Meta: U2FsdGVkX186wi4koNvI1eR3l39YzzQPHZ0kVz4AFVNFsvPSdfhHSzOHL9Go9r8BEf00yGMxHDV1X2fj/1siZ5rhqpL8O1keCfav9MVwCYksksZB8aWXWk04cwP2R/Qdn0XFqsPr7+M7bvO1xo84BU7WCsN+FFQCtndzcvs5z09cAOz1KMe145GYy6p2I/T5m/YWqavTIk2Bqqj2/VGu7vaMKdYnTyH8k1Y1NnffBYZEDBPPV3fMB/e6sxMRXP01g+A2d5+Y6BY6OX54iwLbm//0Lt8cJlm4LAMoipgADpViFxIU9CFQTt967KrUvZUKpd3aFK0xey4TuSL8SZ/wzqEqWmLivuPEVZvvKmmSN9urwP69zrFdoBiBWUGJIjYVGcxirnp6/2T2ml1zHVutY+sM569hZ8L65GNILU4Tgn1j4nWMSLcGGY2ioKhf05bddZu4aWxBuR569/runaJt7ojObKCGXiTeOylqxXhgoIn85znNjqWL+QAa9Oxcws+9itHTQiMWKYhDTv51W/e0LJKW70EibdfPMvaC46w1//ZQPI0QHfiT9CKRfioon75DTpwZualB7FiAwRt6QHnxILuzU3AaQPdrkMsanUv8tTXTFAXqnX439JK47/ar4tkV3261BDeqdCPo8MNXE6fpNd1htkW2IU6x1Yft3fSugJVJAfawOsHzw3UQqQFIHXQJ67pwCGScKKdkMgP8htqEPHvfqml58znzSj5g5yTomELAsUFqSYbitkxUcwVbBKKiFSEokJrvUPJ8H+F0oWSZUTl9wvQ3QmRYAvtIvCWrtO6RWCpSakGIKHDCP0ERqeyLpd9drIxUWnOZVQdTY/j2uw6J+wnj4SzzZH7OXMs6QPw6bMZxuC2MecMwqBC7wi5sEvvHn1z/vEmM0IPqs1jWrT6ImiCdNU7Ll60txF4UcvieACgGaM277BLrBSB7gXIctfMWuMV8vCkpTdtKGur 9S/3fFnU Yaz2HPwMG0Mbl0RlcPpPtPFH9esOYOMdSrhT3T9QGFWMRkCvnNFkYaczCYF4Be6ga3wt2Cv/VH3OTFf6EDgUkNhr/T9hEeugSI+vdhUuxrkbpnvZeivKvjLYaMJJEErEDpeNls6bcU1PiGV4TrTKMZBXp9xDcXocrHiMiO5HyyCaH7FDS2IKKqnU8O5zEbVqD0WtnfVnBtPfqzu1CkKak0oGWSfLcUmg1uzPO9riGN91UYeakfGnt0koLNK5/bmgLFwIoOEs0Sck5iduk7kb/xsGkfsM1WdC5v6G9Yh3VxQIY3T89lWbWs8eAtv5p5YWj0ZrIr5brpZ03u1LOPTAJFoBvp+ty36x/hoN8mIdrwakEAW8Tr9pYNSq15Th/a5QkPYw1GxcDd5+PttNk1IWEHGY4HF3Ah6t91vqp6c5M/KIQMaqcNIwfAdH1f4E9vFsHiZM8LBRwE4fpWR/dDTMoeA4LTXHaL6PrYdgVtYExrcObHGXkx6jawBuq8SZKH5lxKBhe7s0SVyZu40bzQUVJZn0F08RVQYzLiKZn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000586, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 04, 2024 at 09:15:43PM +0800, Zhongkun He wrote: > The spinklock in z3fold_alloc() is used to protect page->lru, > but now it was removed in commit 'e774a7bc7f0ad', so remove > the spinlock too. The pool->lock clearly protects things other than page->lru. I'm not saying that you're wrong, but your changelog doesn't make a strong case that you're right, either ;) Please CC Vitaly (scripts/get_maintainer.pl) on these patches.