From: Johannes Weiner <hannes@cmpxchg.org>
To: Zhongkun He <hezhongkun.hzk@bytedance.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/z3fold:remove unneeded spinlock in z3fold_alloc
Date: Thu, 8 Feb 2024 04:34:01 +0100 [thread overview]
Message-ID: <20240208033401.GC185687@cmpxchg.org> (raw)
In-Reply-To: <20240204131543.1469661-1-hezhongkun.hzk@bytedance.com>
On Sun, Feb 04, 2024 at 09:15:43PM +0800, Zhongkun He wrote:
> The spinklock in z3fold_alloc() is used to protect page->lru,
> but now it was removed in commit 'e774a7bc7f0ad', so remove
> the spinlock too.
The pool->lock clearly protects things other than page->lru.
I'm not saying that you're wrong, but your changelog doesn't make a
strong case that you're right, either ;)
Please CC Vitaly (scripts/get_maintainer.pl) on these patches.
next prev parent reply other threads:[~2024-02-08 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 13:15 Zhongkun He
2024-02-08 3:34 ` Johannes Weiner [this message]
2024-02-08 17:29 ` [External] " Zhongkun He
2024-02-21 22:23 ` Andrew Morton
2024-02-22 2:40 ` [External] " Zhongkun He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208033401.GC185687@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=hezhongkun.hzk@bytedance.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox