From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D6BCC4828F for ; Thu, 8 Feb 2024 02:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98B766B007D; Wed, 7 Feb 2024 21:01:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93AE96B007E; Wed, 7 Feb 2024 21:01:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 829CE6B0080; Wed, 7 Feb 2024 21:01:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 740BC6B007D for ; Wed, 7 Feb 2024 21:01:17 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4D3CBA01A6 for ; Thu, 8 Feb 2024 02:01:17 +0000 (UTC) X-FDA: 81766984194.02.DFA78BC Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf09.hostedemail.com (Postfix) with ESMTP id 1CA58140019 for ; Thu, 8 Feb 2024 02:01:14 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ry4rv5Zd; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707357675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f17VA0K/59Gswb1cNQeS+97yCPfT5U8DLi0nKEQk0NM=; b=WxNt+lrrRQTQ7ty91ankPy7qT7R8iKzXZd85pezk/5r83YAE6QuHR15XV6fuM3hvC7U68c TKyxZFcFh4nMh6YNG7xVNz1uyRvA2+O9cCzJer2vtaD35D/tl8tnaPEkn5aQU9RZirUPhm iP7xG+DH/BL5Acq9/azJWKwf3jZYp/k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707357675; a=rsa-sha256; cv=none; b=c+tqGCkQV6+c8G27rpSA+gycolg9grJ518Z2RLbTlwmp/fcySyg24UZh5MIjGpvMrWVsG9 zGbVdG8kLJ3jThtwd4qIwhO+z4qakCpQmvUsARDDJ1WjrNUkVwS45jrjZeLrpqrPxfRO+n 0MtOUncZdKCaGkMjUWpR7M8Zrhdv14w= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ry4rv5Zd; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 14FE2CE1ACC; Thu, 8 Feb 2024 02:01:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D66AC433C7; Thu, 8 Feb 2024 02:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707357669; bh=dwTLQzI/QIkNCUaRNzVuPjQwBg8dpqhsrkwPkL+Pg7g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ry4rv5ZdjcSuqtYio8CxxKNPfgBtQ5SZk14HB7hm+WwWdBn0VomqE2FLHV9pJojq9 7bphmEJCiWzntJPdMCabGqgE5OIjyDA+Asw8BlDH+VBUug0L21dFZB8Td+ftMMacMg Rle8uVDEKFFELCeYg9jOthphVF05BW7aUP2lhqa8= Date: Wed, 7 Feb 2024 18:01:08 -0800 From: Andrew Morton To: Muchun Song Cc: Prakash Sangappa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, mike.kravetz@oracle.com Subject: Re: [PATCH v3] Hugetlb pages should not be reserved by shmat() if SHM_NORESERVE Message-Id: <20240207180108.6a181d9fa5b404f78c0b4b22@linux-foundation.org> In-Reply-To: References: <1706040282-12388-1-git-send-email-prakash.sangappa@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1CA58140019 X-Rspam-User: X-Stat-Signature: wpd5uascz6cei1o65hx5iehbnr8r3uo3 X-Rspamd-Server: rspam03 X-HE-Tag: 1707357674-448909 X-HE-Meta: U2FsdGVkX1/f54qXoS8bqKk1yXJA3Lg/pLqDXTyAPPV26EhdYU+37DpEin/BuZ08lyG9bbbJjoPcrVWv3zjlFCCFGGzxABtzhgX/qgoJ/O0VfZcqvlOxx93hE9CSW3oz+ybI/2Zi5+rb78lXVGnHHoiU1yKoYtG0oGkXaPcXXcMOiFSv/r/jafWhuZOF53CdliTxdqDGOJHqwInCrGUHITUcEiDZ3c+0zg0qYaN58PSM5GPx+GMmVdfduPqeMcCT2ckMGQB0m8PkBADB6c/mjWQ2EQHUJz0HylIVksiXgnDmKxjIHUuEhAN3d2aVoCIvVTsaLpghCwTVbSlWFWf6MA1RD6rIWn417NJdLwQKJqI8ASDhoZPkPJAxrpcZfgDatqvvye9znxTm0ioeNVPc+Im+WB378lWDia0YWc/U0msYMNBb8UrNX2xZutDq6l2lwdayLjmpxFZ3S7kNctkG79zDdJNunLDmLTrHGv4Z8TZTKWLbGBkrVijS+DMOXlDwMz11hwBPjpv4pHy6FgP8bVUiqBrcTQQ/ST+M9fqyQAGotAmD7dCfACAIGNAHBS4nAyFSCy+MOCfIpQG2hYdibCKfS+LSJs4r+svDrmAF68XtSUTaiHv8yaXDwhWPozSQfoVShX4A1J6eSYI1SR4WV4zelWscqFPWDB+u3CRYn8Cb4akBIXIlhKCkuKJ4EHpULVdxw5ARSr3evj3MAz+INKH+3Jmv3xsWRvH0soPxLFidV35kZAsY1ugjXqd7+ldBWNpZq/hRdGGHAJA9sdzU8n3HK0iT0GCuXy+4TiQnrHa5NFtT4D6xybZUWso8pjG9IaAwCalVr5nMgOG0a+tVCDSFeu3s4lec9G0L0L0YYJcAm6ze+Ev+sSOakCtSg47I0wcvYpSMNrl8PYpxoxvyDbYwYBVApOtaY1WgjGc4o0bE1VI4RpsWtBHS5rzvpvDGKFTnbuAtXKyGXqI447a XN69Cwy2 XLpaMVTSmTclvz6VuB7p4Xn1mdqRbfJrhTH11tYj1XO3hsB2UAhD04k1eAcyDwfzNHhKH8pDSvLN2VTUGVV1bAEF0bjBHbi5REVzcaJRJh9tSHOTnyM/TpUIXotXHyJuoRapuqkv+Cleba2ZMgC3rewdwiN+WxmsSpBSfn7peJoYnHNwjPDYtRixeVvwj8BJAdqNtnbQmwchEqe94PvHPXXzF41jk1YcupJgLqJCJ7+RsfeSkn3o18nwmSFDzKKyHJf/Ohb1A3AacmMQjj9mc05/cJw7XSLoWcpIE3Wu5BLzg6B0FuLf/wvJnURZQrdj2Pj2W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Jan 2024 15:03:15 +0800 Muchun Song wrote: > > Fix is to ensure that hugetlb pages are not reserved for SHM_HUGETLB shared > > memory in the shmat() call. > > Signed-off-by: Prakash Sangappa > > BTW, it is better to add a Fixes tag to specify which commit > that this commit aims to fix. s/better/essential/ However this issue appears to pass the "been there forever" test, so I'll send it to Linus as-is.