From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AFAAC4828D for ; Thu, 8 Feb 2024 01:56:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 433696B0071; Wed, 7 Feb 2024 20:56:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E2D36B0074; Wed, 7 Feb 2024 20:56:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AA996B0075; Wed, 7 Feb 2024 20:56:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1ABAF6B0071 for ; Wed, 7 Feb 2024 20:56:27 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0FC9C051E for ; Thu, 8 Feb 2024 01:56:26 +0000 (UTC) X-FDA: 81766971972.13.BC50C81 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 17627A0003 for ; Thu, 8 Feb 2024 01:56:24 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yUDDt+mZ; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707357385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bUv65ehmicGWrNTKzutgkWJiiQnZklbzALARYduVexU=; b=YmTpz7gamTESdkiTG2EhSDCp+TyhNX4F9+O7UTUjph9uJG/f2Z5H7vfn0ePACjpvSVYA6t TtiGeACYOQ9rX3EhKOzFZIaNTkxFr379T2c/LCT2JNbRJ5BGR0kZbvg5JUQ7fidxP+WSqW MGdYH9nlvkkXJRjLwttidiZ3DOOxEXk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=yUDDt+mZ; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707357385; a=rsa-sha256; cv=none; b=QuEAnQHLUQdkC3uGl4jnY4tiDvKkF0w7pg9CxpSPLC5Xc4u7ARBNoOVCFhVebRqe333Plq uBX0geiRiH/PALnMZKwYuyztE2452rA/C6IYQ196xObV+KPqEwi7QowMXtpAJwKHPwO0YF vsuFOtRJxOrx7/aCa4+qwrXzh7MfLlI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E43C061B23; Thu, 8 Feb 2024 01:56:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F693C433F1; Thu, 8 Feb 2024 01:56:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707357383; bh=rVThkiSRe3KkWzz8wgEgHLkSR8j9heMzqKF037jczOY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yUDDt+mZSSrAsObYnTUAk/OhxeX96BaLr5Y8tpQe4YqaooWEd4/eS7dpuHp1vkn13 DGZrF4kxSizzi9e75I5QE0hdsAWZ78TzvC+YzBw9U0qq+uVOGPIEnVyjBDv+JhmoOC 7FIzeR1kkM2mME9zqctRaKkRB8AxLyxqsRcDLtyE= Date: Wed, 7 Feb 2024 17:56:21 -0800 From: Andrew Morton To: "Darrick J. Wong" Cc: Matthew Wilcox , Christoph Hellwig , Hugh Dickins , Chandan Babu R , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: disable large folio support in xfile_create Message-Id: <20240207175621.dd773204e7928dbeee7a92bf@linux-foundation.org> In-Reply-To: <20240112022250.GU723010@frogsfrogsfrogs> References: <20240110092109.1950011-1-hch@lst.de> <20240110092109.1950011-3-hch@lst.de> <20240110175515.GA722950@frogsfrogsfrogs> <20240110200451.GB722950@frogsfrogsfrogs> <20240111140053.51948fb3ed10e06d8e389d2e@linux-foundation.org> <20240112022250.GU723010@frogsfrogsfrogs> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 17627A0003 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ns5z1w78szibmgdo7qumcagxm7kt9nx6 X-HE-Tag: 1707357384-877337 X-HE-Meta: U2FsdGVkX1/gr1KRsW0lbAhbYqiVbvlTEWazoxgTkzlvEeoHUggFwkd+ttWLNegRgb6FqavwfkOsyZM4huqqAGo7aLUZSZXsDmMr+evLyNVjFiwQB8tEAgWY2M2HBKM9qlAs+CLQ12ulME0VGHV0T7bt3/NNMOGmfyWcFA19JWdrjCTmJToAHubwqQooyF8X6JiVftO/Aey0s45+NLCfgJVC6hhazwXxij4+Nn1b/C9Dud5OSNU78InGvt69YRlvU4A02X+/w1Mhii07qu2nMaS8X89oBEjh6Iwgs65euAj5fcTJu0IopQPzS8sqduko+r8rWmHK8Yh3yUuA5Pu98jGOKUCiGQqI3J4kVVLctfDKkhbnVMK2+1NAdO5ZHKqWGyvSTYL0TIqH9mVUHDkX2qUmw1MkeRiY6G7O9gSRQ8IFQL7TTOoyndDZYsfdlK9b4LqDQIBkq5KB1TLbNldl5sc2pG+4aui89OM68N/kWSCiTnGWN7RTRNqPfaMkfWn3ljZh/3MtOHYmeLPWpnlSPLkYFFFTGeH81InR2OlnM/5LIES3lGejWgMQaGP72tk5ubP26rpKDOtKrJYi3QAs7/0EuIkfno1PqW62nZwDLR56uFY2+L4Luii7qLNbxI0amqS3o/tyYV5ZSmY0jY5FAhV8lX1Tzenul68V3dD67qekhiJVXpi+UANCG3PcfYvtE2qRpY/cjrntWfiwk/rEWAAFrK4YqoszMaUTOcd5FDVQ08MlQMsPKuaYOg4cUeWUuPPY3XvFgKJmzYZYEsXcvuqe3IqPdJw1lrJ8u6Xf68PAHJ1eFLZ9QJ52V8MkVK20Pu3Rx7q7se4mK7spzqqIOnAwZVdYeFEKL6ZHnuZQ1BwU4cFi7trghsSPNB79sQ1xP8zYaoj80Kx2L7aLPAMomN4GVpITDybTgxvutPNefsiKYuALMXfeyn7+Z3BJXd3t9GTGWLshEgj8KGfaVs4 6CGknMYG /ORTfoiJ4IZz5Ne12pzgnRhwh6DBDAP9APOAPraH809gXpoy2PjfiYijfdwbaGZ8SOzrdoxHN2DIQBdhQmMeXLNq+/nw9ozy1Anh371FQhVwlJDJLMYahAjirOW83CtUoIl2qkANvt6QK/ZWRzrfbxeG3zkQ3KYnJTIrD+UiVR+wxw/Rwy3r2RnNtfq5MQFBjHNA51UNgEAe4arrod9Gia65fJrP3Rae7qQ31wJq4rVItI0wwjUvgxrdZ+jmM8qzGiNcdg8eeFLLfmIZAB5zai/nap1gdgyg2EnQ9FaaarXI9gD9gokeqQ8oFZFsEmNNE8n4Z6IH8s04a/uH9Glmu63uT2i01sM/IYXRKwcR7Mo53qV80zWG2mIffJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" wrote: > On Thu, Jan 11, 2024 at 10:45:53PM +0000, Matthew Wilcox wrote: > > On Thu, Jan 11, 2024 at 02:00:53PM -0800, Andrew Morton wrote: > > > On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" wrote: > > > > > > > > > Fixing this will require a bit of an API change, and prefeably sorting out > > > > > > the hwpoison story for pages vs folio and where it is placed in the shmem > > > > > > API. For now use this one liner to disable large folios. > > > > > > > > > > > > Reported-by: Darrick J. Wong > > > > > > Signed-off-by: Christoph Hellwig > > > > > > > > > > Can someone who knows more about shmem.c than I do please review > > > > > https://lore.kernel.org/linux-xfs/20240103084126.513354-4-hch@lst.de/ > > > > > so that I can feel slightly more confident as hch and I sort through the > > > > > xfile.c issues? > > > > > > > > > > For this patch, > > > > > Reviewed-by: Darrick J. Wong > > > > > > > > ...except that I'm still getting 2M THPs even with this enabled, so I > > > > guess either we get to fix it now, or create our own private tmpfs mount > > > > so that we can pass in huge=never, similar to what i915 does. :( > > > > > > What is "this"? Are you saying that $Subject doesn't work, or that the > > > above-linked please-review patch doesn't work? > > > > shmem pays no attention to the mapping_large_folio_support() flag, > > so the proposed fix doesn't work. It ought to, but it has its own way > > of doing it that predates mapping_large_folio_support existing. > > Yep. It turned out to be easier to fix xfile.c to deal with large > folios than I thought it would be. Or so I think. We'll see what > happens on fstestscloud overnight. Where do we stand with this? Should I merge these two patches into 6.8-rcX, cc:stable?