From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8407AC4828F for ; Thu, 8 Feb 2024 00:08:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA8A86B0078; Wed, 7 Feb 2024 19:08:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D58586B007E; Wed, 7 Feb 2024 19:08:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1FA16B0080; Wed, 7 Feb 2024 19:08:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B03056B0078 for ; Wed, 7 Feb 2024 19:08:26 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 50FC41A0231 for ; Thu, 8 Feb 2024 00:08:26 +0000 (UTC) X-FDA: 81766699812.05.9AC1347 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id BAE364000E for ; Thu, 8 Feb 2024 00:08:24 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=osKux0YI; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707350904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8o1XUzlsaksLwX+tl1yzLLdA3Q6JAQnNoI/vW3ST9iM=; b=v0KUxlAHiISDfgqZA48US++57Bk8IVtj5hshofmzIyU8OPWBRv2DxOAzoCZrTJHquFcBHi lveOzrZIk1Jktd3LDJc3mn3IM905LrZ3ebzJR1Vxf87q4bMUmP3LchatZKNxBDlUjx1bE7 Ee7R/+5PCpaI8BRl/ERQiNuxCyKhnEQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=osKux0YI; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707350904; a=rsa-sha256; cv=none; b=J7v49GIKEAU/6PDfEMG/RMJCWXZJhThRCInjSrkXlXRrB26jd+jb3e4cyLSRlVfHvgMsSF ikypMAvkjq69JLUES/CxGDBHRn23NcBSf139MGT1YnFKxn0tkn0Hd1tsxBNZMAiBaibvAJ VWrj/yNmRnAy0RBYw0p1AzsoDR8xyiE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B9B096196F; Thu, 8 Feb 2024 00:08:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DC73C433C7; Thu, 8 Feb 2024 00:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707350903; bh=zpFL9tuc+VckuTDiG9NM15A9S+EbfXl30c0elvw5tTM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=osKux0YIteV3Jlbv7wlzFCk3jUqr8BjkFANBLBePHJdbgi1La88MZKOHhp/PHu3kA dll2N1SW5QC14Adl5a4trJNJDWvhX85ucdeJQcJKXYvm0W2gGiZPVWO57HsmVnIKKY SOnn6r1fzBe/0v6v7xBXO98JckBHMVlZCsjEmW8E= Date: Wed, 7 Feb 2024 16:08:22 -0800 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, alexandru.elisei@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/cma: Add sysfs file 'release_pages_success' Message-Id: <20240207160822.c061cc98d6ffd2ab1ecac38a@linux-foundation.org> In-Reply-To: <8d9f2950-6805-481f-a5e7-e5ea45128fb5@arm.com> References: <20240206045731.472759-1-anshuman.khandual@arm.com> <20240206093857.d834af4f96d643c53e29e02d@linux-foundation.org> <8d9f2950-6805-481f-a5e7-e5ea45128fb5@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BAE364000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: y7zo4w1woy616tm6bfz93yq1bjms8nwz X-HE-Tag: 1707350904-218284 X-HE-Meta: U2FsdGVkX18dgROyxkZ8LEDDIDyyl5J1C9mbvbtNDCTxgziPuW1aj9SwB474TnjBetXnnosL9GT0GrjY/kOd6aww2BNQqVdMvgC4ZD0rENOMLLhOn2fHZMLlEhtiwyN2zTGwc4tITu609gRzqGRI6BbZl53cmtTtC2erNSGW4BFnXGLtQH9TlykyZVRRl4job6kW1V8GTvdPacJoyE7fArLBjezhTunv+vM0sTIlvqk62Q68Ozu6mYcTf8ignWEQPO1n3y9HPPomLuB0HN4gM8y24dXc5gpZBCBqia5b/tQ8WHpdPS9zg9UMVDMWCQ+RjHzIKzMQ6Pe9Ltca0N1j+30tXbRpw4eUoi9oRyZatNvnAXfnau9VmoF1abp5jZz6ej4zACcljM/Zw7aJRl0T8o2KM6cPcK0pRpAQVXEu/8+pzZ0HKnvDY35Bdwm7Wl0rUoNhMmQR2UYblRhZ1VOKU5JwIfePx6E9FZ8c1nLRmDa+A07QHczbiDU0CBgkrIfAns4FgdoNLq32T8nBBOs7xESxHvYu3rl4oYhWDNt3NYeoODe+F76cGmMBSelQazowDJDks+jFjtEjRGt7n5IWTWcLYVaDHm9GYIphedad38XyGBm2IKlqvK9vx2sCqewRArvGkNtxmqEGYqvEhCW5XnC8L7nwNxL1jPM4ur6XGCwgok/9r0G6lPIpNSZJsx6mzFJ4JuRlnXTZdjWdIkuiYltGLyZ+aCUkRx+jKutZcinv9DYi8/PGC/BdYw5GVPpn8Ds2MIl9CLnbsUdDTszGFE3tF1J+yutqAMr1kZ9iBv0coBoqSzYHLpUThDtm6u7isaq42m5XbI2DsywTsXzpoahwc8bC6PopSEiJvUH8aHLaKbCZQO7ta94QGDk/9Igqd9uu/8Rq6y+kIiEQXDEwneJp6vc/rv5uzYiwi/URUHiPV0RmDIhInjv91PS5U9h4gbWm2tSixlHWqE0P3Jv H2hVAaRp gUeDX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 Feb 2024 10:04:31 +0530 Anshuman Khandual wrote: > > The changelog doesn't explain why Linux needs this feature. The value > > to our users. Perhaps that info is buried in the link which is buried > > below the ^---$, but as this is the most important part of a changelog, > > it really should be spelled out here, completely and carefully please. > > Does this look better ? > > mm/cma: Add sysfs file 'release_pages_success' > > This adds the following new sysfs file tracking the number of successfully > released pages from a given CMA heap area. This file will be available via > CONFIG_CMA_SYSFS and help in determining active CMA pages available on the > CMA heap area. This adds a new 'nr_pages_released' (CONFIG_CMA_SYSFS) into > 'struct cma' which gets updated during cma_release(). > > /sys/kernel/mm/cma//release_pages_success > > After this change, an user will be able to find active CMA pages available > in a given CMA heap area via the following method. > > Active pages = alloc_pages_success - release_pages_success > > That's valuable information for both software designers, and system admins > as it allows them to tune the number of CMA pages available in the system. > This increases user visibility for allocated CMA area and its utilization. yup, thanks. I added the patch with the above for a changelog.