linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, alexandru.elisei@arm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/cma: Add sysfs file 'release_pages_success'
Date: Wed, 7 Feb 2024 16:08:22 -0800	[thread overview]
Message-ID: <20240207160822.c061cc98d6ffd2ab1ecac38a@linux-foundation.org> (raw)
In-Reply-To: <8d9f2950-6805-481f-a5e7-e5ea45128fb5@arm.com>

On Wed, 7 Feb 2024 10:04:31 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:

> > The changelog doesn't explain why Linux needs this feature.  The value
> > to our users.  Perhaps that info is buried in the link which is buried
> > below the ^---$, but as this is the most important part of a changelog,
> > it really should be spelled out here, completely and carefully please.
> 
> Does this look better ?
> 
> mm/cma: Add sysfs file 'release_pages_success'
> 
> This adds the following new sysfs file tracking the number of successfully
> released pages from a given CMA heap area. This file will be available via
> CONFIG_CMA_SYSFS and help in determining active CMA pages available on the
> CMA heap area. This adds a new 'nr_pages_released' (CONFIG_CMA_SYSFS) into
> 'struct cma' which gets updated during cma_release().
> 
> /sys/kernel/mm/cma/<cma-heap-area>/release_pages_success
> 
> After this change, an user will be able to find active CMA pages available
> in a given CMA heap area via the following method.
> 
> Active pages = alloc_pages_success - release_pages_success
> 
> That's valuable information for both software designers, and system admins
> as it allows them to tune the number of CMA pages available in the system.
> This increases user visibility for allocated CMA area and its utilization.

yup, thanks.  I added the patch with the above for a changelog.


      reply	other threads:[~2024-02-08  0:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  4:57 Anshuman Khandual
2024-02-06 17:38 ` Andrew Morton
2024-02-07  4:34   ` Anshuman Khandual
2024-02-08  0:08     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207160822.c061cc98d6ffd2ab1ecac38a@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alexandru.elisei@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox