From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1501BC4828D for ; Wed, 7 Feb 2024 23:59:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90AC46B007D; Wed, 7 Feb 2024 18:59:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BA636B007E; Wed, 7 Feb 2024 18:59:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A9456B0080; Wed, 7 Feb 2024 18:59:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6BCE66B007D for ; Wed, 7 Feb 2024 18:59:33 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2B20816031B for ; Wed, 7 Feb 2024 23:59:33 +0000 (UTC) X-FDA: 81766677426.10.6B73C20 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 73FDC40010 for ; Wed, 7 Feb 2024 23:59:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RskDEjDz; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707350371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wRwatAouUKP/HArxs6kr4FFVoi9HYCWT5hfysfQf8wA=; b=xlNlId81kLPIAcNmwbMB29JinQg98IkjeuDT3M3KSQM20gBZenIOo9x2KnjTNob6zb49UU Rf2Mr8aMI/wPiYiR2V3BRHDNW13yfSgXRvGHpls+B1KFWAGSYZOwsBAEWb6A3deohbje7P Dm6i0A5rfhv7Hi0COGG1hpuKIq1EkLM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707350371; a=rsa-sha256; cv=none; b=aAhWbD9qUpSOmdxaDyC0/PuKrJibb26u22n7BKBnPHwh2MXcH7GPIBcywy+OufoQDewfcC iGzibEulbd1dIimEAassWB6k6z0Di5qXqiA0onBJUYYoUIZorIw6OFw+iuknSorT6Q/rS0 aHuSxqoDm6bNyK3na5iKnRUmiNNZ6Hw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RskDEjDz; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9B8DD611FA; Wed, 7 Feb 2024 23:59:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0E73C433F1; Wed, 7 Feb 2024 23:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707350370; bh=A2dMLCL0N8nSgdIq9wrTS7hQJhAGgTvpR/6aTe8uFIE=; h=Date:From:To:Subject:In-Reply-To:References:From; b=RskDEjDzdZBhZa7SBbcC/31F5gD7ozdd58YpBawaxicaz/F/zARPTXGW9xcekssbm LqpA1TA/KT8auYNR6HG7AyQh/ejCsWB/MmjvTF7hfwWXL/4THV1CF4RDZKZFFGu337 eFUtIWOr6VLSjkEB+WNaxOeucC4fFlUTVpQC252A= Date: Wed, 7 Feb 2024 15:59:29 -0800 From: Andrew Morton To: Kuan-Ying Lee , Jan Kiszka , Kieran Bingham , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , , , Subject: Re: [PATCH] scripts/gdb/vmalloc: fix vmallocinfo error Message-Id: <20240207155929.cc107bcc14b982789bdc9fab@linux-foundation.org> In-Reply-To: <20240207155623.a943328ba0b77859246e0d9f@linux-foundation.org> References: <20240207085856.11190-1-Kuan-Ying.Lee@mediatek.com> <20240207155623.a943328ba0b77859246e0d9f@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 73FDC40010 X-Rspam-User: X-Stat-Signature: tgyaffy94onp5ozau8kcnetg3665juxd X-Rspamd-Server: rspam03 X-HE-Tag: 1707350371-708055 X-HE-Meta: U2FsdGVkX18d9VPl3TE9gGkqgnqIl3oymwb4bQlyktYUnMIMYYOQ8bd69XFY9vP38aYknB55N/PResmY6k9SjGLO17rKf49SCTPe6y9T3FCKxeissmu5zpf/0RXLOpgVxXL6NIMdEf3vVA0kTw7rar0wGBBVE4zvtVdu7KMxWAAYK+EKkLEDGZCCQh6KgZ+2NHfbaYyOPiAqJTHdTFlL2++JSWA8Z+Vz14w15PlSMZe/vcVZRdgocFoYgxpfT3r6v87KgKvQ4Y2DKotPQYEmyxGIFY4vQA2MpUEnmqDSqUCTbv3puDnlj8iP9TSIIw/tEsV1zR2rbvenWWgXBN1lmEtQO2JWjRHl9nsWIcaKkRcQDtE93PvOKIqigb35ZP/Hq7X7Q1WCZUsy9Ze4lWrTQMXW81rN6mmTinHMK2VSpiEpMrxrU2FzS/oonbo1Q51P3vhyIJmtwniI1E7+EVGKf6OTSQ8gw/JD8J5Mqb0iaBGu8nCbsb/My2q05a9ZUs9ZQostKgrvsvndmqbVzQbFvDaA4bVA2/pvhCVCmBjgq2hbo59QUXj5X8pmfkbEn1ga/rFEy47tIZHBjtdG/xLZaEKKwCT2B5c7EAvh8w9gXL3sfvbIb3bNuxW/JipE0RsBTOlPWZ7SFNHLVSzECFjpAOlQuViBIxCaVYUt27RXoTtwXB9fUcP17f7kRutHjhLkouaP/uplcSb/WMUyUJBikxGbJi9UjzGLlDfDjyr4DS72ez2B+LjCb2F3ka53p7C4n4fEFYjiQvay+HLPZScqbOYgA6apAwQvIZBrrN5avQ8fOiAcKKw3AgqJiXPjzMFt2D5F4r0hsAI5JBnbFVSa3pqTGCSBBZ4hIn2BlhVok6euZuQR/h4KsG5lMlvs5Fc46qprTwr4tdb89CVEplu4+opYwiPSa5cmOkSrxml4C8Uyv45C86srlTMC4QV8QrpYKkRmqRm2/qsaGcE/PE5 vmOhuUZM H4+/43VJJfIfUdfatdty67UsCZEfOgQ3IS1X8unle4yzcuV0Tn5fNgNNr18topto/p7XdCk28+Uz73E/HuDsLoD2SeLetAoaW5GO7AgVvmdjY5tVNKK3Cx2G6G6zYXsrk2xpSAr4gy+ORLR77ckcUUfiJX2wSeVyEnP4lhzkechNfE/iIL0I9DIcNaQzYe481voubpTMXbNKGMp4+viW144H42HhrIyCHhll24fWor3Rrs2k2h8Qp6gpvwK+rS2Gxz2gfJKtrqt5jUqFQQuLCh8NsVFcUWBdUL6Rb04jj8fEmMj89nuFMMCCX7CsN3gzIIgxc7A5dwevQH7S/WlhsC4bWyohAOCoF5vipajQwP0Y/UHOq6NxatuAslf/fhc6zTP0vwR1FDDQA/9BjsOKphyH4fw2y4ILZxn8grnwXuCNDYcAMgEqUVFirXloivfQu+KFvbrMSuf2PVUbmQlD2FSqvDfpVBsOvP/rOU+eueBzLGmgI30DubIL4r7vXY7rXMYVhahwDCHNZ+Bstf3oZ/IN96UGLDbkW5gBCZCV+XXZS/cY5FMk5FnDCXGwIrOKVH8o5O1GqY4Jpo6MhR1KaHThy2Mh47RPDBGOXG++xGHuWPigESyNkOlj1eb8xT3qlkaPoQpvIh/YSTHU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 Feb 2024 15:56:23 -0800 Andrew Morton wrote: > > [1] https://lore.kernel.org/linux-mm/20240102184633.748113-1-urezki@gmail.com/ > > vmap_area_list was removed by https://lkml.kernel.org/r/20240102184633.748113-6-urezki@gmail.com > > So I think this patch is actually a fix against mm.git:mm-unstable's > mm-vmalloc-remove-vmap_area_list.patch? > > However this gdb function was probably probably broken earlier in that > series, so perhaps this patch would be best staged as a predecessor to > Ulad's vmalloc series. ie, this: From: Kuan-Ying Lee Subject: scripts/gdb/vmalloc: fix vmallocinfo error Date: Wed, 7 Feb 2024 16:58:51 +0800 The patch series "Mitigate a vmap lock contention" removes vmap_area_list, which will break the gdb vmallocinfo command: (gdb) lx-vmallocinfo Python Exception : No symbol "vmap_area_list" in current context. Error occurred in Python: No symbol "vmap_area_list" in current context. So we can instead use vmap_nodes to iterate all vmallocinfo. Link: https://lkml.kernel.org/r/20240207085856.11190-1-Kuan-Ying.Lee@mediatek.com Signed-off-by: Kuan-Ying Lee Cc: Casper Li Cc: AngeloGioacchino Del Regno Cc: Chinwen Chang Cc: Jan Kiszka Cc: Kieran Bingham Cc: Matthias Brugger Cc: Qun-Wei Lin Cc: Uladzislau Rezki (Sony) Signed-off-by: Andrew Morton --- scripts/gdb/linux/vmalloc.py | 56 +++++++++++++++++---------------- 1 file changed, 29 insertions(+), 27 deletions(-) --- a/scripts/gdb/linux/vmalloc.py~scripts-gdb-vmalloc-fix-vmallocinfo-error +++ a/scripts/gdb/linux/vmalloc.py @@ -29,32 +29,34 @@ class LxVmallocInfo(gdb.Command): if not constants.LX_CONFIG_MMU: raise gdb.GdbError("Requires MMU support") - vmap_area_list = gdb.parse_and_eval('vmap_area_list') - for vmap_area in lists.list_for_each_entry(vmap_area_list, vmap_area_ptr_type, "list"): - if not vmap_area['vm']: - gdb.write("0x%x-0x%x %10d vm_map_ram\n" % (vmap_area['va_start'], vmap_area['va_end'], - vmap_area['va_end'] - vmap_area['va_start'])) - continue - v = vmap_area['vm'] - gdb.write("0x%x-0x%x %10d" % (v['addr'], v['addr'] + v['size'], v['size'])) - if v['caller']: - gdb.write(" %s" % str(v['caller']).split(' ')[-1]) - if v['nr_pages']: - gdb.write(" pages=%d" % v['nr_pages']) - if v['phys_addr']: - gdb.write(" phys=0x%x" % v['phys_addr']) - if v['flags'] & constants.LX_VM_IOREMAP: - gdb.write(" ioremap") - if v['flags'] & constants.LX_VM_ALLOC: - gdb.write(" vmalloc") - if v['flags'] & constants.LX_VM_MAP: - gdb.write(" vmap") - if v['flags'] & constants.LX_VM_USERMAP: - gdb.write(" user") - if v['flags'] & constants.LX_VM_DMA_COHERENT: - gdb.write(" dma-coherent") - if is_vmalloc_addr(v['pages']): - gdb.write(" vpages") - gdb.write("\n") + nr_vmap_nodes = gdb.parse_and_eval('nr_vmap_nodes') + for i in range(0, nr_vmap_nodes): + vn = gdb.parse_and_eval('&vmap_nodes[%d]' % i) + for vmap_area in lists.list_for_each_entry(vn['busy']['head'], vmap_area_ptr_type, "list"): + if not vmap_area['vm']: + gdb.write("0x%x-0x%x %10d vm_map_ram\n" % (vmap_area['va_start'], vmap_area['va_end'], + vmap_area['va_end'] - vmap_area['va_start'])) + continue + v = vmap_area['vm'] + gdb.write("0x%x-0x%x %10d" % (v['addr'], v['addr'] + v['size'], v['size'])) + if v['caller']: + gdb.write(" %s" % str(v['caller']).split(' ')[-1]) + if v['nr_pages']: + gdb.write(" pages=%d" % v['nr_pages']) + if v['phys_addr']: + gdb.write(" phys=0x%x" % v['phys_addr']) + if v['flags'] & constants.LX_VM_IOREMAP: + gdb.write(" ioremap") + if v['flags'] & constants.LX_VM_ALLOC: + gdb.write(" vmalloc") + if v['flags'] & constants.LX_VM_MAP: + gdb.write(" vmap") + if v['flags'] & constants.LX_VM_USERMAP: + gdb.write(" user") + if v['flags'] & constants.LX_VM_DMA_COHERENT: + gdb.write(" dma-coherent") + if is_vmalloc_addr(v['pages']): + gdb.write(" vpages") + gdb.write("\n") LxVmallocInfo() _