From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4075FC4828D for ; Wed, 7 Feb 2024 23:56:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B51F76B0074; Wed, 7 Feb 2024 18:56:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B01C76B0078; Wed, 7 Feb 2024 18:56:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C92F6B007D; Wed, 7 Feb 2024 18:56:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8A1C56B0074 for ; Wed, 7 Feb 2024 18:56:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 464621C11E1 for ; Wed, 7 Feb 2024 23:56:28 +0000 (UTC) X-FDA: 81766669656.09.E7ECE4E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 9E2E1A0008 for ; Wed, 7 Feb 2024 23:56:26 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AP9MSno1; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707350186; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C8MX8hAmbc+bXt3TVWxkcpF4cySt12sl3QQG2SCDKKI=; b=gaKFaImaxMPA7hnBRUeTxs7m0HYg2v+bDfdA96e33OpwzcRqJ42gtNC+p7vQsokm533W8K 9o/4SQwqL2pnBrITiFSkIl0zsYTIXShZO7OruySoNgdDU5+1HF0VyOrRnDtG2vTtZMZWK3 06QVQenEnVB6LQZy3wmjp4Yfit2uusg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AP9MSno1; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707350186; a=rsa-sha256; cv=none; b=6un1+hP85u973qs0oj8ZYE1HiCDlScPJfI8IG0IWEl654zmXJGPPwcQRU1cUXBwhyYtBG0 6TTnkxQTC9aMaDBALT0QpqTpD8M7FGyVZKNtd/6D3MDbJ8fgObd4sbAviQOb2OAr4c8gS7 3psBoDc2khvFCLZ+ROSCKO8jd2roA7M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 58A45617DB; Wed, 7 Feb 2024 23:56:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B93AC433F1; Wed, 7 Feb 2024 23:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707350185; bh=olXKOEtFICuarB+A1Plr5Q6pk9xJ3SBVVYmbulfIKPw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AP9MSno1xVJ7P5OcbiS3b8nLGkGyrV5wo314dvJCWaT2KIpEdrvqLt/o+Eb3lTMLF TyipGNpYwzssX6qnz2ncIymRZKejRRCYpTn6iFnhumkH/ZvSbfUFgfpk6XKrm6jm02 JAEBRE+AZbMQGC6pFShPhx7GsjWPsYsaBOdXDAik= Date: Wed, 7 Feb 2024 15:56:23 -0800 From: Andrew Morton To: Kuan-Ying Lee Cc: Jan Kiszka , Kieran Bingham , Matthias Brugger , AngeloGioacchino Del Regno , , , , , , , , , "Uladzislau Rezki (Sony)" Subject: Re: [PATCH] scripts/gdb/vmalloc: fix vmallocinfo error Message-Id: <20240207155623.a943328ba0b77859246e0d9f@linux-foundation.org> In-Reply-To: <20240207085856.11190-1-Kuan-Ying.Lee@mediatek.com> References: <20240207085856.11190-1-Kuan-Ying.Lee@mediatek.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: x5xcg4rgyeo7umktqf5jwsd9ygwghsfw X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9E2E1A0008 X-HE-Tag: 1707350186-874930 X-HE-Meta: U2FsdGVkX18Q1wUdI4QrRcMPGiLmDbvyJU/2utzlzbhLBgbnyHHc1v9S2JVJvd8dsDgK3kFsRwUHR1H/Fz2fGvdmBrG27MMpcd89l+1S3jXlvgLyDPhKbhSto+mtTfaKzXBWnqkfu3QmN4tDSGMJoChykoFHPmbmrb8t6U1t2apj+j662jDOjVAeqgGM1A8it07cYFLiH9vM5/5/d9ciGWIGANRfP9Qk5RdJLHZL337YC+Rltt3mbRHzhJB1hpDG6GhF6iOTyqzGyV0f9b0VoVbs1QoHKJ+xeLXNvU4tl+6IeHFJ8MKMkD0ggRGTt5y9EOs3FqSORRUFM8VVrXwgDXNsIJc+6OJPKpmUOLlQtnQQNExVpPT7LHU7Q6i+AROjXUF0shkKKu4zUOd6NbY7JzYidMoe4+woOWe+slBLSXE1GyDL7EpRhKOLTzy/+UMHlQCSzYPi9DJHLqL7jEKDRB+/ztIaEr7S6FfnU6gefYL/6SJ1czXJShbqUu+uAlNiW5DqHGSWFeNfbzD074qT9Hn6WwfoLsKYfycp621D3oJX8lcPvT9eU0O+jaDf+75/RxgSMOHTOFOlpPOTrnVZbksbi8au+mlOwb34EOwg50S2kzA9trUGN/vzsUN6YhnjiawPNWwxPo1u4CbW2G/egJQTUqt905E2lsY7X0ymfYZt5EUnwowtxPyzhr/ae10MgxpvU8ZtyswhUNAYCy19PLHVNjBDJekwgzncfAb3ePGdWaMJHvutxUFNqBHDSooSN7f1l36RvEdrZ/fDhdh8491wuhQ+GxTPfsDtZVNofC4q5TblBj60kusdi7E81Ft5FbyNtAi4E6HWQCBnjmKdRqEIrFnOMT/C/7M5GdgivJB+6QEjhal39+zcBxvQRh/NGdt9KQCcBZhoV08rJOLIf5C4wloPJsthUNVivM3Sj5GkKKP4eMnnT132+c3RwBfVFeeGHJmc3/GSceiuQkv jNwKYUTq fZsDI2LW4Uc5nsfLIjTfrRnJY2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 Feb 2024 16:58:51 +0800 Kuan-Ying Lee wrote: > We met the gdb vmallocinfo issue as following. > > (gdb) lx-vmallocinfo > Python Exception : No symbol "vmap_area_list" in current context. > Error occurred in Python: No symbol "vmap_area_list" in current context. > > Since Mitigate a vmap lock contention patchset [1], we > remove the vmap_area_list. I don't think that's correct? > We need to use vmap_nodes to iterate all vmallocinfo. > > [1] https://lore.kernel.org/linux-mm/20240102184633.748113-1-urezki@gmail.com/ vmap_area_list was removed by https://lkml.kernel.org/r/20240102184633.748113-6-urezki@gmail.com So I think this patch is actually a fix against mm.git:mm-unstable's mm-vmalloc-remove-vmap_area_list.patch? However this gdb function was probably probably broken earlier in that series, so perhaps this patch would be best staged as a predecessor to Ulad's vmalloc series. > Signed-off-by: Kuan-Ying Lee > Cc: Casper Li > --- > scripts/gdb/linux/vmalloc.py | 56 +++++++++++++++++++----------------- > 1 file changed, 29 insertions(+), 27 deletions(-) > > diff --git a/scripts/gdb/linux/vmalloc.py b/scripts/gdb/linux/vmalloc.py > index d3c8a0274d1e..803f17371052 100644 > --- a/scripts/gdb/linux/vmalloc.py > +++ b/scripts/gdb/linux/vmalloc.py > @@ -29,32 +29,34 @@ class LxVmallocInfo(gdb.Command): > if not constants.LX_CONFIG_MMU: > raise gdb.GdbError("Requires MMU support") > > - vmap_area_list = gdb.parse_and_eval('vmap_area_list') > - for vmap_area in lists.list_for_each_entry(vmap_area_list, vmap_area_ptr_type, "list"): > - if not vmap_area['vm']: > - gdb.write("0x%x-0x%x %10d vm_map_ram\n" % (vmap_area['va_start'], vmap_area['va_end'], > - vmap_area['va_end'] - vmap_area['va_start'])) > - continue > - v = vmap_area['vm'] > - gdb.write("0x%x-0x%x %10d" % (v['addr'], v['addr'] + v['size'], v['size'])) > - if v['caller']: > - gdb.write(" %s" % str(v['caller']).split(' ')[-1]) > - if v['nr_pages']: > - gdb.write(" pages=%d" % v['nr_pages']) > - if v['phys_addr']: > - gdb.write(" phys=0x%x" % v['phys_addr']) > - if v['flags'] & constants.LX_VM_IOREMAP: > - gdb.write(" ioremap") > - if v['flags'] & constants.LX_VM_ALLOC: > - gdb.write(" vmalloc") > - if v['flags'] & constants.LX_VM_MAP: > - gdb.write(" vmap") > - if v['flags'] & constants.LX_VM_USERMAP: > - gdb.write(" user") > - if v['flags'] & constants.LX_VM_DMA_COHERENT: > - gdb.write(" dma-coherent") > - if is_vmalloc_addr(v['pages']): > - gdb.write(" vpages") > - gdb.write("\n") > + nr_vmap_nodes = gdb.parse_and_eval('nr_vmap_nodes') > + for i in range(0, nr_vmap_nodes): > + vn = gdb.parse_and_eval('&vmap_nodes[%d]' % i) > + for vmap_area in lists.list_for_each_entry(vn['busy']['head'], vmap_area_ptr_type, "list"): > + if not vmap_area['vm']: > + gdb.write("0x%x-0x%x %10d vm_map_ram\n" % (vmap_area['va_start'], vmap_area['va_end'], > + vmap_area['va_end'] - vmap_area['va_start'])) > + continue > + v = vmap_area['vm'] > + gdb.write("0x%x-0x%x %10d" % (v['addr'], v['addr'] + v['size'], v['size'])) > + if v['caller']: > + gdb.write(" %s" % str(v['caller']).split(' ')[-1]) > + if v['nr_pages']: > + gdb.write(" pages=%d" % v['nr_pages']) > + if v['phys_addr']: > + gdb.write(" phys=0x%x" % v['phys_addr']) > + if v['flags'] & constants.LX_VM_IOREMAP: > + gdb.write(" ioremap") > + if v['flags'] & constants.LX_VM_ALLOC: > + gdb.write(" vmalloc") > + if v['flags'] & constants.LX_VM_MAP: > + gdb.write(" vmap") > + if v['flags'] & constants.LX_VM_USERMAP: > + gdb.write(" user") > + if v['flags'] & constants.LX_VM_DMA_COHERENT: > + gdb.write(" dma-coherent") > + if is_vmalloc_addr(v['pages']): > + gdb.write(" vpages") > + gdb.write("\n") > > LxVmallocInfo() > -- > 2.18.0