From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E14C4828F for ; Wed, 7 Feb 2024 23:48:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7DC06B0075; Wed, 7 Feb 2024 18:48:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D9E6B0078; Wed, 7 Feb 2024 18:48:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1CC76B007D; Wed, 7 Feb 2024 18:48:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C2CBB6B0075 for ; Wed, 7 Feb 2024 18:48:32 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 93466A027E for ; Wed, 7 Feb 2024 23:48:32 +0000 (UTC) X-FDA: 81766649664.30.F83FADE Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 6F3D41C0004 for ; Wed, 7 Feb 2024 23:48:28 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AMBszwyY; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707349710; a=rsa-sha256; cv=none; b=SZ6q5I4g8OLnXTkOeRqBzTgulidX/zbql6vSlxsrSatvL4LJdLn34iXuWvApJltGBl3mZ8 btA96igPjoqX6xRC1G8KadlZYNEcH2UJuQfvSXypDDAKlspBYKjPDHWEMqXZfRKz+ItJNM ThiJUUfdBeFsju6kSs/nLgGLxlnWAx8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=AMBszwyY; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707349710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LbUtiqe0JJqdfn7m0MnLuU7PI8sDTK0uVne8bSzluBw=; b=uEc1GcLrRYik6jiFlA4TJNXLu8x6KNj/cKCMRpavZ7e0QsyPGwQIAWp4e2l+8RPPeUTn5j rUhFF2OjdasY1hj/lIwE005q5v11n/qVa9/sLnBZTZ1cu5WTEKFyum9DhC6J6KbwptGxI+ 9MqhuGg8rHjbOeFCXuP4YuD5rEaAJtE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 635F4CE1B32; Wed, 7 Feb 2024 23:48:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B6D3C433F1; Wed, 7 Feb 2024 23:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707349704; bh=iN5MCr7TuNN8Lmw1GLhuyPUlMhQg6qzjeczx+I9YTtY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AMBszwyYpG01cQ/GFe1kGLx1YOCxeGxjYbHdMxzCgsYecus/b6jDNE417tqx2hV9w W9QHJ2cBLVBIfN2L7eySJ0eY0+cw3XUxi+rC/67KV95PwIEpYWYopkAvMRn9riAam+ qaLAos0l5US8JU8NYtBuuTKhMyMuzuYRztLwE0MI= Date: Wed, 7 Feb 2024 15:48:24 -0800 From: Andrew Morton To: Kefeng Wang Cc: Subject: Re: [PATCH] mm: compaction: refactor compact_node() Message-Id: <20240207154824.38a8654fb396f790c2a7a3f8@linux-foundation.org> In-Reply-To: <20240207095841.1648144-1-wangkefeng.wang@huawei.com> References: <20240207095841.1648144-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6F3D41C0004 X-Stat-Signature: hx1o6du4f1x9wgsjg8t57wuxx1mnn16t X-HE-Tag: 1707349708-112284 X-HE-Meta: U2FsdGVkX1+vQY/lSxiUgolegkoehVXztyTPn9BHcAAvvnYTxGVcdMr9XaHv44/VdDpQoLaQdA6Xzw12khdatxYyBWWrTY4nzcThPKjaJzFA4RBGKgN9C5eHd1GcY7E3zxmsSPMlP0eAhrRJM7J4N0qNXi18hqqj4Rlh4WVp6fEKGF2pcoYeS++4OYhmfNFR6cCXDm1OvXCBXzeCHuXLzQg7hcnSQFYNlh5yxgDCO/sCQom2F91rCx1aq8Zjl5xBxf2QhV3WlGtt51G5NHS8OTaLmOUOvAGFCTB2i+28x9vEy8VUHuc34Mfp3gAyL2w563drMvQCvwGZpPk4XK15mVxnBmMhfzF4UqU9DOwkUWdC0Y20ch/lUgXsQ9qEzHWd5tEaXjcCyMMyuCnPJKU/3eDpbHujpeXros/xG5au/BWu08bmoqTtxedCgKE3oFi8SmMrvZ//WCAVFketO8NFSxSfvVGh6taPDFE3MSjLorcPrKweZ0kb4eR6AMd6/Ru9ZmAI85ZcI+68retbp2RUP7hXuxtGsHm24fMaUjdCRZ+1w2gvC4smZT3KTUBCnO0ZdBKfJ2Kp4TBE1pIC3QiQ+33ynYpsY/XSa5DC+AIoocV5zjijcUIbqaljbYjsG8qNoTTqk//Y4lFYDRoefqzEz4ymrD6Hhq8cn4RZS42J86/FdXluKUkJg8fEka8d3W74nmBEtYDXSmZ6cyZ1p/vPtFmDcB2cUoMc4h8n9vcS63caW+zf7VJ63vk8FPPnY+97EuWWJX+NuV2dquQ/vtyOrCPCdec2DMqepxAHxwBnOIt7/aLNgVRlFBjuoNKSEFH7TjMDA+NdpsUnyfJdYnfkawG6+tc9TKvJZbGqK5B5cpeOh8+kUEqBY8qBzwj8fncDQzjDxm2p5dLa5PzrUJRfpq6RaNTXBwqwdpPoqJQT/hu/IpU3LcKWrN6faOzMj5fy3r6mb774cPugEshjh1q mCgRWIIT Mp+VJ1g7/muTgh7eQkLUbVEC6fXekYOuom6u4Ju6dY/f0XyJuGBqHyyF4cnsaaXj9dsv9mpe4h2ZoHGSr3aHN8ddTc2485xDVD1D/Z/TyT/PH9JwWE2QGWZAaWY6L3E5usQJoD7PlTUZUPTl/lZFMq6CDgo16GnFYFbPXSdBMxHJa2mndKNmBCxCs/FYmn96kQ5OWF7RlSOyPeFr6xjBMKpIgKZsCI0H5FEysLIZ2fiCGD7RQKB4cr1BtFUr3cyeINUEx2dPYD4toOCq/Zs24Twb1Q12MEwDln0Y5yNPoPPkAwCk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 7 Feb 2024 17:58:41 +0800 Kefeng Wang wrote: > Refactor compact_node() to handle both proactive and synchronous compact > memory, which cleanups code a bit. Looks good. > + * Compact all zones within a node till each zone's fragmentation score > + * reaches within proactive compaction thresholds (as determined by the > + * proactiveness tunable). > + * > + * It is possible that the function returns before reaching score targets > + * due to various back-off conditions, such as, contention on per-node or > + * per-zone locks. > + */ > +static void proactive_compact_node(pg_data_t *pgdat) > { > - pg_data_t *pgdat = NODE_DATA(nid); > - int zoneid; > - struct zone *zone; > - struct compact_control cc = { > - .order = -1, > - .mode = MIGRATE_SYNC, > - .ignore_skip_hint = true, > - .whole_zone = true, > - .gfp_mask = GFP_KERNEL, > - }; > - > - > - for (zoneid = 0; zoneid < MAX_NR_ZONES; zoneid++) { > - > - zone = &pgdat->node_zones[zoneid]; > - if (!populated_zone(zone)) > - continue; > - > - cc.zone = zone; > - > - compact_zone(&cc, NULL); > - } > + compact_node(pgdat, true); > } I suggest that proactive_compact_node() be removed. Move its comment to compact_node(), add explanation of the bool argument to that comment and open-code the call to compact_node() at proactive_compact_node()'s sole call site.