From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A413C4828D for ; Tue, 6 Feb 2024 13:32:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEB386B0075; Tue, 6 Feb 2024 08:32:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E73B36B0078; Tue, 6 Feb 2024 08:32:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D15E06B007B; Tue, 6 Feb 2024 08:32:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BAE306B0075 for ; Tue, 6 Feb 2024 08:32:12 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F06E480B4B for ; Tue, 6 Feb 2024 13:32:11 +0000 (UTC) X-FDA: 81761467662.12.AB84E26 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf06.hostedemail.com (Postfix) with ESMTP id A8C5C18001C for ; Tue, 6 Feb 2024 13:32:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GU07agyh; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707226329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=ae9C/de5C6PHRLki/2bZu9b7S/IxdhhJYMP/IMLkn5g=; b=xlgJBmQ6y6bYXtQJOvGHPmByPkTPaG93/baGgJuqn28KjMRDAkNci6rSd+5DKGPe7+g8BA YgaBqPWtsVK9K2ivFL7+Sr2QKYX44vCb+ewqLbxM62JZh8Qs+hg+/QIc3lO4zZlMJfgaNI merrOA1+lkWML96AjNz47/ZaHFAnjWY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707226329; a=rsa-sha256; cv=none; b=Ol3IYs+YODFycMbE1g9NUX69SnT3KMdurhTqFUBHYog9jTRPszLXv5kTDqtNWV3PwNrx2S 2HlzytCL0H6pWBqImi1b3VbXH1F0TFIliyRqG4Tj9WsJLQ+xUqcFm8On7SBhO6GhCxCwWc 5UyPEcXUFzaXkvHRV6FUXQARK7wSaiw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=GU07agyh; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 192.198.163.13 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707226330; x=1738762330; h=date:from:to:cc:subject:message-id:mime-version; bh=QBwDsbh1+S8mFwHW5IooDdMttQ2TcsjFHG4Sx/8T4jQ=; b=GU07agyhL9t9OvUqEcEwFYcdMhC74l4kN6ZPcAZg30/TSFz854d+digC /OBZ1hboWeGhnGhHJuBLOfV4QH+xLa7qJSTkckiJ0677SevMK9u6Iq8yY vKnQpLuphptxAHW0rpIl+Sc4F0KtiOKDp0jLUCNKwWRYvba3OgttbX6Kk ROXohK4iecMmtT+zejU7/zdp5aSvxTZABJQ2X2+N1qbWke5wVqPUZXElq jpSx0K8BNwr3Z3LhDKhgbe8uWo7wPYJC+mMoeOYoqzfSiRjPQqQ3QcONN K8iXd8Xbjk+JrlBtARFo2KMU55Uo5Dq6j/evgSJ24PPs0rBelxWnDz1MP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="3706825" X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="3706825" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 05:32:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,247,1701158400"; d="scan'208";a="5640778" Received: from lkp-server01.sh.intel.com (HELO 01f0647817ea) ([10.239.97.150]) by fmviesa004.fm.intel.com with ESMTP; 06 Feb 2024 05:32:06 -0800 Received: from kbuild by 01f0647817ea with local (Exim 4.96) (envelope-from ) id 1rXLYR-0001QI-1g; Tue, 06 Feb 2024 13:32:03 +0000 Date: Tue, 6 Feb 2024 21:31:44 +0800 From: kernel test robot To: Timur Tabi Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Danilo Krummrich Subject: [linux-next:master 4231/4465] drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1955: warning: Function parameter or struct member 'gsp' not described in 'nvkm_gsp_radix3_sg' Message-ID: <202402062106.cfArbjsv-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: A8C5C18001C X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: fbdn1es9x11szid19me7tou6qadqhxts X-HE-Tag: 1707226329-62643 X-HE-Meta: U2FsdGVkX1+bRK3Q/197l5I9z73o177LYHsP925/+oFOmHYzz5ZGnhSJiKjyep983uyNTV8FpDmLj0uEUxfivxu2vCkyBXsUlPJ65sdWWyr0hntRfUCyWNJk/rmu1H8rr0SRxm2zeZWtMGgUQ7MMO2anuKYmlzcB7u3TWODjSngUYrL9fKdGvNMZEEHT55cQ1oaV60o4nx+8l/NWD4Mpf6aHqu5t8bY8/5j5ETf1vKgll3b8xPIH5C1UQsr4ITpoW0E9qkw1kwhC5MrYRS+lJ9zBxCGLD7aWIGi8TuA/GChF7UqnOvfWhYZaHV+SwkoJ7bGsHCR8FHHKCl5XP33L31qYDxzu4eCp/9xsC129w28y+Mqfceykqv1y/evLoBZBOGIZePXJEh5tHlK6OtR+xf1gWUatpr28gL1gmwbSgbEKQYY7sfESkNWfP7PT1IZT/sAreXmqMGB92u/9TRVDtX9RQwYkcVAd0+twpQmnDZq2a1c2YVCNmCubm9PY+JutbX6mnELRP5cr0PGKrlcMV0inW8EacL13HkaUCHFt052zmxvEVvCyQAj0taY2tSUHypqOqIWcO6mPxPvHfSGsl1N4dPiRb4DmCSSoX88MJrcsEslpi6vBkoOiMVbpJbY63l98PhKYTYiTIVFSNvnrL3pl6cnvyMPfHmQfdnf/xx6iBk7+SjJ+2Xov+QWNY7dIUxwTuqJrE0I563H/B3vSJNYblnAxsS0e49DDBeZ4zDFJDoeRXAAIcKddjdKM6/29fe4yLGjQ2b6sZUNBg8qqIQ9QDIraB0oHJVzj+n0OZom6p68r9VBTeePAy7UKXGUQ4RGwfFaqKAgBNVRvcb0orP7h6oQdpqoDG4n9IWSnpfhZgMm+Zgs4m/U+NmTujkaFL2p182IC+TS5dtSnHHl0oP4kPa1ntCxz745MADFwfszQ1oPQle4eOOBcD5EYiURlEqIFdnNjmHRn+4gjx6R XareoZfT yAO9d6g8XXhiq8/i1O92MDn4OhSEtk3gfHeBsrcVIQ69FzzszSgpNWLjvWxJvBI5eh/jbL2vu7RpSj7+aQb29MgMOVSdJTn4ps9Mt+aEPTqavV20tKuUoekbh0retEse2YPD2x0xY5K6ltAQGP+wRJnHDpX2HyEDC/yxD/84BvecerlJJi36YsEPk9pbo73J3apsF+Zu9o4Na/7jkTIyZg6OcPlHRydMJlXeJqvK5RZwbBfJbCl5+/TL4/MybNAtPTYmd4vGVS+MFtjzopMAiwHKk7SKynjujLrGxqqTSBwCtjQffPHPEEmXVAEDUtEfvc3MBdUTs0QvkFQYOHXtgJzJcoG8xMnDWFt/0Nhp+9FEkgAzxslzyfhywV6jDV4F92M+vI7JWsWErtEzebDVJvi/qrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: ac139fc7db67968e5061715508b5fc4aa7c40c56 commit: 34e659f34a7559ecfd9c1f5b24d4c291f3f54711 [4231/4465] drm/nouveau: nvkm_gsp_radix3_sg() should use nvkm_gsp_mem_ctor() config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240206/202402062106.cfArbjsv-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240206/202402062106.cfArbjsv-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202402062106.cfArbjsv-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1442: warning: Function parameter or struct member 'priv' not described in 'r535_gsp_msg_run_cpu_sequencer' drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1442: warning: Function parameter or struct member 'fn' not described in 'r535_gsp_msg_run_cpu_sequencer' drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1442: warning: Function parameter or struct member 'repv' not described in 'r535_gsp_msg_run_cpu_sequencer' drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1442: warning: Function parameter or struct member 'repc' not described in 'r535_gsp_msg_run_cpu_sequencer' drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1815: warning: Function parameter or struct member 'gsp' not described in 'r535_gsp_libos_init' >> drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1955: warning: Function parameter or struct member 'gsp' not described in 'nvkm_gsp_radix3_sg' drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1955: warning: Function parameter or struct member 'sgt' not described in 'nvkm_gsp_radix3_sg' drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1955: warning: Function parameter or struct member 'size' not described in 'nvkm_gsp_radix3_sg' drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c:1955: warning: Function parameter or struct member 'rx3' not described in 'nvkm_gsp_radix3_sg' vim +1955 drivers/gpu/drm/nouveau/nvkm/subdev/gsp/r535.c 176fdcbddfd288 Ben Skeggs 2023-09-19 1922 88a2b4d34a64bb Timur Tabi 2023-11-22 1923 /** 88a2b4d34a64bb Timur Tabi 2023-11-22 1924 * nvkm_gsp_radix3_sg - build a radix3 table from a S/G list 88a2b4d34a64bb Timur Tabi 2023-11-22 1925 * 88a2b4d34a64bb Timur Tabi 2023-11-22 1926 * The GSP uses a three-level page table, called radix3, to map the firmware. 88a2b4d34a64bb Timur Tabi 2023-11-22 1927 * Each 64-bit "pointer" in the table is either the bus address of an entry in 88a2b4d34a64bb Timur Tabi 2023-11-22 1928 * the next table (for levels 0 and 1) or the bus address of the next page in 88a2b4d34a64bb Timur Tabi 2023-11-22 1929 * the GSP firmware image itself. 88a2b4d34a64bb Timur Tabi 2023-11-22 1930 * 88a2b4d34a64bb Timur Tabi 2023-11-22 1931 * Level 0 contains a single entry in one page that points to the first page 88a2b4d34a64bb Timur Tabi 2023-11-22 1932 * of level 1. 88a2b4d34a64bb Timur Tabi 2023-11-22 1933 * 88a2b4d34a64bb Timur Tabi 2023-11-22 1934 * Level 1, since it's also only one page in size, contains up to 512 entries, 88a2b4d34a64bb Timur Tabi 2023-11-22 1935 * one for each page in Level 2. 88a2b4d34a64bb Timur Tabi 2023-11-22 1936 * 88a2b4d34a64bb Timur Tabi 2023-11-22 1937 * Level 2 can be up to 512 pages in size, and each of those entries points to 88a2b4d34a64bb Timur Tabi 2023-11-22 1938 * the next page of the firmware image. Since there can be up to 512*512 88a2b4d34a64bb Timur Tabi 2023-11-22 1939 * pages, that limits the size of the firmware to 512*512*GSP_PAGE_SIZE = 1GB. 88a2b4d34a64bb Timur Tabi 2023-11-22 1940 * 88a2b4d34a64bb Timur Tabi 2023-11-22 1941 * Internally, the GSP has its window into system memory, but the base 88a2b4d34a64bb Timur Tabi 2023-11-22 1942 * physical address of the aperture is not 0. In fact, it varies depending on 88a2b4d34a64bb Timur Tabi 2023-11-22 1943 * the GPU architecture. Since the GPU is a PCI device, this window is 88a2b4d34a64bb Timur Tabi 2023-11-22 1944 * accessed via DMA and is therefore bound by IOMMU translation. The end 88a2b4d34a64bb Timur Tabi 2023-11-22 1945 * result is that GSP-RM must translate the bus addresses in the table to GSP 88a2b4d34a64bb Timur Tabi 2023-11-22 1946 * physical addresses. All this should happen transparently. 88a2b4d34a64bb Timur Tabi 2023-11-22 1947 * 88a2b4d34a64bb Timur Tabi 2023-11-22 1948 * Returns 0 on success, or negative error code 88a2b4d34a64bb Timur Tabi 2023-11-22 1949 * 88a2b4d34a64bb Timur Tabi 2023-11-22 1950 * See kgspCreateRadix3_IMPL 88a2b4d34a64bb Timur Tabi 2023-11-22 1951 */ 176fdcbddfd288 Ben Skeggs 2023-09-19 1952 static int 34e659f34a7559 Timur Tabi 2024-02-02 1953 nvkm_gsp_radix3_sg(struct nvkm_gsp *gsp, struct sg_table *sgt, u64 size, 176fdcbddfd288 Ben Skeggs 2023-09-19 1954 struct nvkm_gsp_radix3 *rx3) 176fdcbddfd288 Ben Skeggs 2023-09-19 @1955 { 176fdcbddfd288 Ben Skeggs 2023-09-19 1956 u64 addr; 176fdcbddfd288 Ben Skeggs 2023-09-19 1957 176fdcbddfd288 Ben Skeggs 2023-09-19 1958 for (int i = ARRAY_SIZE(rx3->mem) - 1; i >= 0; i--) { 176fdcbddfd288 Ben Skeggs 2023-09-19 1959 u64 *ptes; 34e659f34a7559 Timur Tabi 2024-02-02 1960 size_t bufsize; 34e659f34a7559 Timur Tabi 2024-02-02 1961 int ret, idx; 176fdcbddfd288 Ben Skeggs 2023-09-19 1962 34e659f34a7559 Timur Tabi 2024-02-02 1963 bufsize = ALIGN((size / GSP_PAGE_SIZE) * sizeof(u64), GSP_PAGE_SIZE); 34e659f34a7559 Timur Tabi 2024-02-02 1964 ret = nvkm_gsp_mem_ctor(gsp, bufsize, &rx3->mem[i]); 34e659f34a7559 Timur Tabi 2024-02-02 1965 if (ret) 34e659f34a7559 Timur Tabi 2024-02-02 1966 return ret; 176fdcbddfd288 Ben Skeggs 2023-09-19 1967 176fdcbddfd288 Ben Skeggs 2023-09-19 1968 ptes = rx3->mem[i].data; 176fdcbddfd288 Ben Skeggs 2023-09-19 1969 if (i == 2) { 176fdcbddfd288 Ben Skeggs 2023-09-19 1970 struct scatterlist *sgl; 176fdcbddfd288 Ben Skeggs 2023-09-19 1971 176fdcbddfd288 Ben Skeggs 2023-09-19 1972 for_each_sgtable_dma_sg(sgt, sgl, idx) { 176fdcbddfd288 Ben Skeggs 2023-09-19 1973 for (int j = 0; j < sg_dma_len(sgl) / GSP_PAGE_SIZE; j++) 176fdcbddfd288 Ben Skeggs 2023-09-19 1974 *ptes++ = sg_dma_address(sgl) + (GSP_PAGE_SIZE * j); 176fdcbddfd288 Ben Skeggs 2023-09-19 1975 } 176fdcbddfd288 Ben Skeggs 2023-09-19 1976 } else { 176fdcbddfd288 Ben Skeggs 2023-09-19 1977 for (int j = 0; j < size / GSP_PAGE_SIZE; j++) 176fdcbddfd288 Ben Skeggs 2023-09-19 1978 *ptes++ = addr + GSP_PAGE_SIZE * j; 176fdcbddfd288 Ben Skeggs 2023-09-19 1979 } 176fdcbddfd288 Ben Skeggs 2023-09-19 1980 176fdcbddfd288 Ben Skeggs 2023-09-19 1981 size = rx3->mem[i].size; 176fdcbddfd288 Ben Skeggs 2023-09-19 1982 addr = rx3->mem[i].addr; 176fdcbddfd288 Ben Skeggs 2023-09-19 1983 } 176fdcbddfd288 Ben Skeggs 2023-09-19 1984 176fdcbddfd288 Ben Skeggs 2023-09-19 1985 return 0; 176fdcbddfd288 Ben Skeggs 2023-09-19 1986 } 176fdcbddfd288 Ben Skeggs 2023-09-19 1987 :::::: The code at line 1955 was first introduced by commit :::::: 176fdcbddfd288408ce8571c1760ad618d962096 drm/nouveau/gsp/r535: add support for booting GSP-RM :::::: TO: Ben Skeggs :::::: CC: Dave Airlie -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki