From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15410C4828D for ; Tue, 6 Feb 2024 19:29:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A0F46B0074; Tue, 6 Feb 2024 14:29:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8510C6B0075; Tue, 6 Feb 2024 14:29:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71AEA6B0078; Tue, 6 Feb 2024 14:29:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5F0C36B0074 for ; Tue, 6 Feb 2024 14:29:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E9FBB1608D6 for ; Tue, 6 Feb 2024 19:29:03 +0000 (UTC) X-FDA: 81762366966.14.0DB4F24 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf10.hostedemail.com (Postfix) with ESMTP id F3BE8C0019 for ; Tue, 6 Feb 2024 19:29:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GkyuAXGZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.215.193 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707247742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=cI6ZwTOBhqIZJqtzKPKRHMXeREAJHxv8WlyCoSNSHPs=; b=EH6wiqak2kgsBVgCeAqNfqkKGCbXyFND7COpJZwnny+fdE66yuv4tNWD36I+VTuA4LGCrX 6z8SZBWBiAWvYGG++vyUHIR55Ic/EwWp4ikBlhyDrtrYvPBXyEpjfZI+0f/z4u1lfx5VjI ruGzO3tN1jsk7HJ0l4Xx5vT5F/imbWI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GkyuAXGZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of gourry.memverge@gmail.com designates 209.85.215.193 as permitted sender) smtp.mailfrom=gourry.memverge@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707247742; a=rsa-sha256; cv=none; b=DfYGjdywR7h0d9LlBqNiO2DaCjkt7ILU5A9oL/twWLWeb3ZFeKFbFuR7+G7014H2diZOp5 nOTE1LZuhkf2j/9BtotiqdZwOPSidiEJGKTlE/uSWlKRYJv/Det76ShZM7Hu4r2xr0M0jb 7GwcNcrWcHAdgOYDSmf9jUTW1NntlMA= Received: by mail-pg1-f193.google.com with SMTP id 41be03b00d2f7-5d3907ff128so5223979a12.3 for ; Tue, 06 Feb 2024 11:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707247740; x=1707852540; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cI6ZwTOBhqIZJqtzKPKRHMXeREAJHxv8WlyCoSNSHPs=; b=GkyuAXGZUuLth1Y1A3zZ58mHIM1DFOsBMpVD4yCIcy4Hs5H8cNuSf0HP7OUIn/kBb2 zttioQYaZL+fhApk0VviLpDBauod3IzRdWfLb38MtkwqwUE6s80QRO/q3SwRPtqF5q3m zI5G1XaGbbaoqIasyQzyll1ECVltQp2QwRGLLsDTa/jPMEJXI3yaIQzeT1qjcReEFkxY Z3J2DJTkit52Bzjsob0zfGaozq0KFiZi0m/oFhWfL3/6ObACe2PKqltYzHs7fLtB+Fcx MCy35pk1vkWp5Fr9WNhqhnRzXmpFvyCMzRXh2qLD+Ip49FAczwcqqUVs22ddxaTsXtTG Nksg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707247740; x=1707852540; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cI6ZwTOBhqIZJqtzKPKRHMXeREAJHxv8WlyCoSNSHPs=; b=ssHkd+MFhLneg0nsk9LwonnQNpLc+ORSYG5UAs+zGDLWGU+05hE8Pd3IdtU0MNsjGq 7YQ4Egibysbk45xkMrZ8JVCq8b7ePCGXs+Ttqi2GK/58aK71dVRvwf9r3UfydVa3VVfF yjmeQfNFtlOzoOYD91cMYCfCK4BHOeFVVjpGUJWFN7gSXJ2FgALjRd8jzqZZ7Fa8wLEF VHOuPOHgWBxgBnK0VBtTFgFWLX/kvQQozIx1y4rpPyKP9IfNYAVIoXDmblnOAF7YxCgG 55u5uTJqom2Sb4toO7F01dpov2R34q+sz8jACOqRUm+IXSf1uvpByZCYJIa9yWHHm/ej xy0w== X-Gm-Message-State: AOJu0YzqHL+wRmpBS5glwE51bE9KcKfvwdk29Ok42OgAcV9VFkeX7fzc O7RN0vt2IJzNxrBQ4PUnTwJg62n1zUpnCKLyB2Jd+UlREbvIDTWwhUR2bbK42g== X-Google-Smtp-Source: AGHT+IGix7BN3iZ3h/hFTWIEgjPzcLl8wptZLqmGxhxCBbb8JrBB8qyWBEGRy+gUxrsZxakB9WIVpw== X-Received: by 2002:a05:6a20:72a6:b0:19c:96e4:3671 with SMTP id o38-20020a056a2072a600b0019c96e43671mr3004406pzk.30.1707247740516; Tue, 06 Feb 2024 11:29:00 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWAaLZhMF4kQ/kF12ptomvIp0GVRKgr1paZ8gezzkD+BRvrgvvIARIaevSD3Ua6kqH/VP2pnYgsKRoXMg5CDaqeN3KCfloS3dk7EjMcdq6TGCOHsuNZQAbILfVPS7S23rs= Received: from fedora.mshome.net (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id y30-20020aa793de000000b006dfff453f8esm2323065pff.75.2024.02.06.11.28.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 11:29:00 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, ying.huang@intel.com, Gregory Price Subject: [PATCH] mm/mempolicy: weighted interleave checks wrong parameter Date: Tue, 6 Feb 2024 14:28:53 -0500 Message-Id: <20240206192853.3589-1-gregory.price@memverge.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: F3BE8C0019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: iyno67oxqur5roqxuce8bk6xzyywy8jj X-HE-Tag: 1707247741-34459 X-HE-Meta: U2FsdGVkX18Svau+i3Qku60A++VYIeKzJcZr21SdHhyLm2xo1s+0pYj3l7V0bZZbljeLLsyUBRTVJnhVPn01AApPEP0lw0+2GygQhLDRyXqzUr5jEjgiEB+sA/PIyVZX9QrMEAfBNyC79v3Y0R8PokshIVabXNPMggG+0D5YrrNJbrz7lGE5zVb2xnE00LOE+W9TS28jdYk46k+DRAGFveneMkjHXas/6kNu8cjaak/6hiac82cqmAwKuc5yIp1hgJFbomI65g9xtbs6+Kn7/lgg1L6KUBYTybLaj+M3gG0m/84OPZBRfi3RPIi3rV/1Oe75VJ5/6EM4jhR65EO+JbmqcDVreo/1vtATdFJYTtUJhj5ItJDM8jjjEqTt20ZGH7/J34oavX5qcNSto8wZb6yMjedkwg+JCexLssbeAHeHZuZ6ziuexBuTyT2qPVG8mQ1luKp10QOsV3EVb0Mp6pza6Gul4ngDg6tU6wBa4/g26vETfq49EmZibvLB3SHGJWklVUQVrrgyE4Af1cPsb9r7VDSAJ4xH8nqaj2aVxNrBCMAJ+MoFghUP774wo1RTodv2coHIdQ4V0qp8iWF19ol/578dzhvh5EorIuC2mzsu2KI2B2g/ZStDbtNkIY8p7482gyoj64NAMwP9LV7yvS2wALozPCmu5osp2RZMNBJWEo7MeUjzc9we6tAEjL0Ddl1ko1ELji3JUzOvnltVXCkyjmhggN8U98MHoKkUanNTWN8t8WDa+e0+RjOE5LbLf78YvBC+XPELWkRoo76apKirRF7TfF8MR/UQUN5fNd/kYCGxXFhA4pAiYo5rUWPd/6lYQaJU7Y6LTrjNglMgZsAKde3Q0g44VOtk6q39rDVNxsnSkXIDvqjsiISm03SQFRIdZUJn31Yd7gumNcixS6AYOiV7EVfeR1Y6v4LXNCGo07LzQyb2zu0CMYncCZTbu2srCEOoO7Xyesp47Ra gaQtCObj ps/SzfxRGidZGO0DPcEFs8edNL9Jqn37qgWOXZJHv8qE6DfF6YWPokJJF6lZ2tuBCyh4oQcg9mRijL4hG4VKBp6NUUAxDNJdbw0bsFc/Quuy29e6kZJZlYNrj4W3sXX1XUOKG+1GPyWBUuSYm8zWgAd7Q5CKu3hPWuWq6xdpjP23ydhp4T3ZKnzTUYWMW9cj6v1Kjnz+eWC2VVPgKpY8se1I7K3tmCATcuhSCdzlHtFqd360orXHqg62t7pO6Ey+PoFJAFBE1Dde8HI/JKI1F366A8Aku9mSVdVzMj0xHtrWMX5692I9Q3Zg1cl242lOE22znCLShVetS+AQ+aeZvikA0RLKpHe8bIOK64NKDMRor9KUzOC1TCzPe5bfy0pflJYYqmuwE8NpsVcw51N/oypbhqSPSPhHo7YJz8+pkiUTOSNskhSf9h4Yh8zYp333SPW11gX3NJ+1i1FsHUsX5V9eIv1o29dba7mtZQkFZ2X1PQ6TpCR0CkO9Z7M9OpE8Y3r7Gc5KSbIVej0qZl5b3xJQIthNR/6YXNT6Sap0ZsYfFOVk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.055413, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, Can you add this hotfix to d866f3b594ce3324947fef017bbbec1f4eb237ea on linux-next? This was reported after you picked up the patch line. Can probably be squashed, wasn't worth a full version. ~Gregory --- weighted interleave presently checks (!node) when it should check (!il_weight). This causes a wrong distribution of memory. Reported-by: "Huang, Ying" Signed-off-by: Gregory Price --- mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index ed0d5d2d456a..ba0b2b81bd08 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -1885,7 +1885,7 @@ static unsigned int weighted_interleave_nodes(struct mempolicy *policy) /* to prevent miscount use tsk->mems_allowed_seq to detect rebind */ cpuset_mems_cookie = read_mems_allowed_begin(); node = current->il_prev; - if (!node || !node_isset(node, policy->nodes)) { + if (!current->il_weight || !node_isset(node, policy->nodes)) { node = next_node_in(node, policy->nodes); if (read_mems_allowed_retry(cpuset_mems_cookie)) goto retry; -- 2.39.1