From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D9FC48297 for ; Tue, 6 Feb 2024 18:44:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A52B6B0075; Tue, 6 Feb 2024 13:44:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 455B16B0078; Tue, 6 Feb 2024 13:44:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3436B6B007D; Tue, 6 Feb 2024 13:44:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 25B606B0075 for ; Tue, 6 Feb 2024 13:44:36 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EEA5B1605DC for ; Tue, 6 Feb 2024 18:44:35 +0000 (UTC) X-FDA: 81762254910.20.7269F00 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 4D89B16000C for ; Tue, 6 Feb 2024 18:44:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=McVqnQj2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707245073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D0LGXNxavVyyanxOOZ+WuCkGeFHzn0tcuRzDMjcoaOY=; b=J1vqEOj6or1xy88jvH0J/h+AeOmLXk/TCMZzAOv713sQ2HQc26XHee1xSXcYG/6VdTZDl4 1VbCxLaSWy9hEF6zmU7omxmEPRwEm1rThR104koiLS/jBen65qUseU3YCr/Dj7r7o/K8iJ EGmGuZXygDI0mmBY1wVve4EcsIUu5aA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=McVqnQj2; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707245073; a=rsa-sha256; cv=none; b=f4qya9WjxxUNwmQhPu9hoY97+CId6RiNaioivabgKrVR1f0+P/cH7xl32+INQj7aWFHA6B gJ4KkfIisr8A+htlbs1DxVjPOmbjBkO2jHGsqPI98FcO5yAewU819KjlTpSHcH3/cwF2Sf KyBx7eLFSk7yqoq2stNhZ22BvtOv3Eo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 34B76616B8; Tue, 6 Feb 2024 18:44:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8B75C4167E; Tue, 6 Feb 2024 18:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707245072; bh=/LwfzEaBhm/92vOpLp6mT7VMsHzXGBh5BGuIoF2VfF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=McVqnQj29spOlhBIlxA2o3rEq3DIAfsdefRmcLD/1rvBN75qDwiYuK3Ub01Zi/MaC KoZIRiQSUWTmg+6dK39oGHJsrksfS20e974lyNA3T9cqMJHEVmydIS+QEOWlhSNGWF rZGIF6oZicGoGgH8Zna/l6YgYztObs3p7dD104YqVddbFu8D9VYYTom0h/8FTu+3N2 FWLXcFpGs2tNRizjiEzuEGzCgS6UQJ4TLVfCaqH8OMNr1V7q4XXDFKsj7rK8hQHagB I77nlKH/jCsw4VXwguAtbpPt3/ChhM192grQniJ5C6sI1qxZIXTwepRFIwsnIoadxt d7F9Bk06Ps/rQ== From: SeongJae Park To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , "Huang, Ying" , Chris Li , Minchan Kim , Yu Zhao , Barry Song , SeongJae Park , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Yosry Ahmed , David Hildenbrand , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH v2] mm/swap: fix race when skipping swapcache Date: Tue, 6 Feb 2024 10:44:29 -0800 Message-Id: <20240206184429.247502-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240206182559.32264-1-ryncsn@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4D89B16000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nkp5ryh3rrwxzaos3ofgxthauczyfd48 X-HE-Tag: 1707245073-112207 X-HE-Meta: U2FsdGVkX193r3BRygTo7KpaZSSWblyDOhx56eE9Ju6EgVqVGD6hIJK/936HkCD1qvb9bv6njShxVoC8VUMLUpHfZ1tFIdPMyNMVOtZbV2CXpMGANCW90YndK8LYPziuwi1I2A4t7fpREqikT+2OHPByhCXfzXDoHjHCnrThaKe4ClaUKMaxCaVtGgSNqjUuKBbsZMgGcUnoB7cRuxW6foOtuWOd+uIqLu7P5fpAE6RZJHD20W2KiU9WY2J5Y44FffIt2Qwss8lg/7qRJ2JRWAxhJtRc/qns9RRhudFWJPFuTZRX1RHPwpyjGc0xqZ2LZAKPGz2gjrGYBqmsMusgVjlBy2540/zv3TEIUN95v9tN6DbJa0+Y/cnWUFzeJHOT2V7chzvO/nlpvEo4T+YWuFUJ7UjdgLQp2vABGkhz7FVofGLV6rqvsAtv68pYGAfqcX2oG6XT1vleUiF28uSgB3jBJGv1WlNqG25gKbBHyg5aPupWaEMdfMFiW6p3d06Ve66Dov9k4bnJD7uSH9f5AMmg7NJeCHD5lm9+T439rOXOtCVTEcwcAu80USjWuUhnjaJPitqMz1r21jQlLI8pGsMmaV80lqsImTArlucBwV3fyJfe4PxJ3GlwTXXujr8lkDRnctI3GWNv7XVhO8wdU9fbjYKn4U3syJEAOT9UgKuXj4rjoxVLqU0/Y3rUHGIJYnzKzOJukUE5o5TN6D4bfs6TnBFF1N9uaax02GcwHEPW4BYP9ZNgbgolrOVvPsxtzLyzdTEk9vY7owTmRDE6nbm8j79ULz9YGqfEQb+w6j18s5dhkNoRcqXl73AVX42lmcdfuSU62jydd/N/iKdItW3Q2C9mXyyVZq8L0XOYLe3RTIkGCoQ/Ku8dLXBze3Q/2hBdT87Mpno/s1/h2A/QTMPtSQHOaYWpaLvRD6f+34VYZFtQV9+CUYPhF/j13FVBENb3imV7oslSn2nZccP JXT2A+zi AmT5E6bJoAXap3oyUal6E1A1EwCHSvRo97UuC+BpeP4dME9VUYDNPZROWXVPRBqk8i02IZCMU2QeVMtBdMh2TqKDofoxYDvxKFOTT4ig3dLlq8Fvxd/oxUu1sl7vLGYWh6xi/PCdARrd1kXWgFyox4+EOFWY0ehsw0s9vICWS3ewa3ZYrFchFDQlmuWdVC3RXt7o/SXXOCLkiz6zqkjfS/QAC6sAwhOQ0zJix8EKoNzIg8JMsgn4ClqSCcvL7Y4PKpjMyBMlo2aUhUs86C7XVjigXKZ99Hxuq0m+w03CDY8jRLmpnpTA2T8GV6uE7UEjtCd3QM+Z89F7zAXF1m0mo3ARqH8aSrMs/a/rCmYrv3Nj9Ha7UNJMG3oV9AA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, On Wed, 7 Feb 2024 02:25:59 +0800 Kairui Song wrote: > From: Kairui Song > [...] > --- > Update from V1: > - Add some words on ZRAM case, it will discard swap content on swap_free so the race window is a bit different but cure is the same. [Barry Song] > - Update comments make it cleaner [Huang, Ying] > - Add a function place holder to fix CONFIG_SWAP=n built [SeongJae Park] I confirm the build issue[1] that I reported yesterday is gone with this version. Thank you for fixing it! [1] https://lore.kernel.org/linux-mm/20240206022409.202536-1-sj@kernel.org Thanks, SJ [...]