From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC630C48297 for ; Tue, 6 Feb 2024 22:26:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BD066B0071; Tue, 6 Feb 2024 17:26:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 26D0A6B007D; Tue, 6 Feb 2024 17:26:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15CAD6B007E; Tue, 6 Feb 2024 17:26:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 082CB6B0071 for ; Tue, 6 Feb 2024 17:26:00 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D1C3B1A05EE for ; Tue, 6 Feb 2024 22:25:59 +0000 (UTC) X-FDA: 81762812838.02.84BB7D4 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf26.hostedemail.com (Postfix) with ESMTP id 967F0140006 for ; Tue, 6 Feb 2024 22:25:56 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=d4DsACTS; dmarc=none; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707258357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Ez6cmbQ+6c02bU3Ls6dl5ljjHsIkcoz1E2LZLwBXtM=; b=L62wTe7j+JiXrD97MBBjwwv2TsSAYb0GnOxaga7nogS4mM3cRb2UCIcrW0FIYXi4GgZjWQ KqrmCLZXo3yiSjrR30ws7PpKONWi3LjwvefQHYX+FfApnf+L+kUdBL2rhBkk7hD6mZOb26 zExYRmG6uAJY9s9XNKMPLeo1A2mxEtg= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=d4DsACTS; dmarc=none; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707258357; a=rsa-sha256; cv=none; b=DiiunWx8Y8nyl4EJEsga93umzI9/h6+oTxB+kaEbygCCpR/g8lQaHu0YvMIucB4UMJ1LBZ iHNqNF3QTom/0JWxz7eaSpY6R5aFupq5fYHAu4x+otTBASGGfayWDJCrkqHYbutsJI0Oei WqBPCec62QA9evko1fZXocJXmV2uFPo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 42333CE1742; Tue, 6 Feb 2024 22:25:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CA06C433C7; Tue, 6 Feb 2024 22:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707258351; bh=WU3x0zIeoP6xyUMyTVcnpXfLJrwhP5APoHffIvSjMFQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d4DsACTSy8TyyqJS3vN1FDuQFelfApE/DdBxnrCS9iPQH/Zy2u6zE1d/W0TvEFZgi hoUTECZ7LJ2xfiTR0yzszUXCmhASl9nJ4P93wMC8/fqYcIpm5LEckg8nQ6/LDkUM+m 00qmGUqbRWbeJh/vyhvDo7YkU+xeniPBDG52Rxi4= Date: Tue, 6 Feb 2024 14:25:50 -0800 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, Sumit Semwal , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/cma: Drop cma_get_name() Message-Id: <20240206142550.62bed7715692ddc0071da7d0@linux-foundation.org> In-Reply-To: <20240206041518.438801-1-anshuman.khandual@arm.com> References: <20240206041518.438801-1-anshuman.khandual@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 967F0140006 X-Stat-Signature: 9381grknrrsteypp3w9umr31gau6nygo X-Rspam-User: X-HE-Tag: 1707258356-74816 X-HE-Meta: U2FsdGVkX19ntj4Ex6pQ6gOiL+R4ADwi5E87tnFxO69ZgCW/l/IFdGx7jEP2wedVeCXAcf++r89ULtGROGOyDvVYMXUkALJL2n1vE5DX9Jd2JPpR2v8JqzNlKuTEICO3Z1fyanJmDQvNkomT26s4+w17VRUfbXsMsZV9PmPcEthBYg5ZPg5MXkxpj3Mbxh8KafBLmk90lijBlQY0yoiUt3QzrOSixaguyK7jI2uGbO06rzWk9RBE7NEjAhWZBDdVsQoR7cI2w4rHt/y0/tAk1jc/tzNa7fZi9aLfCdszrxSIGed5kkQyU9KfgHJaKuN1OATDrbxlRb65UK8iHdfRri4hWg6qIotPDE620DZnnc/BR5Xvy8exmhg4oThtDbskIp/E/yBd2GK2EO2lSfEJHNj7pivJxOtdBO1W+cV/7QVVOW5xH6JGTNeVF+xTxIk3H42uMz+NWxlDr4deAb+wT7TvHua4XpTg52mv86iUeMCkMfpDRqnKidO14SbUuViDVGuBwayicqW3BZnEDLtNny3hL4N96PdXTSJ8DeuVg+CCqNqknzM2V8nIi06bgQhsN3zzwOh/MGYQbVMhHSDfoeX2htKc+GMgwH5TiBgoUiHchzApVegpEea03e6E+76Gf72Wa08T0/axUmPd8JLK5hZb55sqPteTnr/UOoU5ldpIgAZCPra/DzMA0pT1BZWa4CA4URRbTkJPGnfipUYC2dhN0URMGGBo/ksd6NHiR+x2Jqy5m8ocgW7106poqRjEjhUEqyymwnYc+ZNWVkn5AJ3bEEg7AgJHj9w0sQTnqoiHUEYHcdtnVQE6u8PELenV7/2GPyKJd+JZ6wKSgbReNlIF2nVHU/VNfBDgIV9+XKsiKDpEL/HWx72yhq5DsnePM1B7QI9Lrk9+yYcFISBvxxWuauRwRZGP6srl8Hp9aKwAiRJpD7UFkoTL/0q7sja6toT2fGfOZW++FCikyXy OYqp0fQQ FborW6qnLO5ogoImXvbKddD8rYLbPWmaOLHV8GsIL0W8u70ezlcYfDGSr8iPYPJA8X5zUxuqotqIB2hdNM447Eeaz9H9mvePCnhqGYcTwptVUVoru3sFMxqBGlMwqUcR8X+qTVX4nut6mATkZi17I+HrXItAjSNJOvH7v61x7+PMdXBPfp8Lkd7aiLJ228FXn/Tskj3f9Y8BonuIPnFX+/UJh0yFJzD+AQW4ST7wTSgIxbbFiwsr9jjJNNZqOVh/9LpykeHUeTrGPxtIyQDhzgezf/u/XLxO8vShnByQ6rAh76atXxfts89s5BC8xpV/JpwPI23qMN53gNHsBEi5rQ4LSX7N1HxyO4p3hFxcpf1/ZSm0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 6 Feb 2024 09:45:18 +0530 Anshuman Khandual wrote: > cma_get_name() just returns cma->name without any additional transformation > unlike other helpers such as cma_get_base() and cma_get_size(). This helper > is not worth the additional indirection, and can be dropped after replacing > directly with cma->name in the sole caller __add_cma_heap(). drivers/dma-buf/heaps/cma_heap.c: In function '__add_cma_heap': drivers/dma-buf/heaps/cma_heap.c:379:28: error: invalid use of undefined type 'struct cma' 379 | exp_info.name = cma->name; | ^~ Fixing this would require moving the `struct cma' definition into cma.h. I don't think that's worthwhile.