[linux-next:master 3181/4021] fs/smb/client/file.c:1684:13: error: implicit declaration of function 'lock_is_write'; did you mean 'op_is_write'?

[linux-next:master 3181/4021] fs/smb/client/file.c:1684:13: error: implicit declaration of function 'lock_is_write'; did you mean 'op_is_write'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   23e11d0318521e8693459b0e4d23aec614b3b68b
commit: 39647541cb269fded1345c1e522f829e144f5af8 [3181/4021] smb/client: convert to using new filelock helpers
config: arc-randconfig-002-20240204 (https://download.01.org/0day-ci/archive/20240206/202402061335.qwIGBbl0-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240206/202402061335.qwIGBbl0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402061335.qwIGBbl0-lkp@intel.com/

All errors (new ones prefixed by >>):

   fs/smb/client/file.c: In function 'cifs_read_flock':
>> fs/smb/client/file.c:1684:13: error: implicit declaration of function 'lock_is_write'; did you mean 'op_is_write'? [-Werror=implicit-function-declaration]
    1684 |         if (lock_is_write(flock)) {
         |             ^~~~~~~~~~~~~
         |             op_is_write
>> fs/smb/client/file.c:1688:20: error: implicit declaration of function 'lock_is_unlock'; did you mean 'lock_pin_lock'? [-Werror=implicit-function-declaration]
    1688 |         } else if (lock_is_unlock(flock)) {
         |                    ^~~~~~~~~~~~~~
         |                    lock_pin_lock
>> fs/smb/client/file.c:1693:20: error: implicit declaration of function 'lock_is_read'; did you mean 'lock_is_held'? [-Werror=implicit-function-declaration]
    1693 |         } else if (lock_is_read(flock)) {
         |                    ^~~~~~~~~~~~
         |                    lock_is_held
   cc1: some warnings being treated as errors


vim +1684 fs/smb/client/file.c

  1661	
  1662	static void
  1663	cifs_read_flock(struct file_lock *flock, __u32 *type, int *lock, int *unlock,
  1664			bool *wait_flag, struct TCP_Server_Info *server)
  1665	{
  1666		if (flock->fl_flags & FL_POSIX)
  1667			cifs_dbg(FYI, "Posix\n");
  1668		if (flock->fl_flags & FL_FLOCK)
  1669			cifs_dbg(FYI, "Flock\n");
  1670		if (flock->fl_flags & FL_SLEEP) {
  1671			cifs_dbg(FYI, "Blocking lock\n");
  1672			*wait_flag = true;
  1673		}
  1674		if (flock->fl_flags & FL_ACCESS)
  1675			cifs_dbg(FYI, "Process suspended by mandatory locking - not implemented yet\n");
  1676		if (flock->fl_flags & FL_LEASE)
  1677			cifs_dbg(FYI, "Lease on file - not implemented yet\n");
  1678		if (flock->fl_flags &
  1679		    (~(FL_POSIX | FL_FLOCK | FL_SLEEP |
  1680		       FL_ACCESS | FL_LEASE | FL_CLOSE | FL_OFDLCK)))
  1681			cifs_dbg(FYI, "Unknown lock flags 0x%x\n", flock->fl_flags);
  1682	
  1683		*type = server->vals->large_lock_type;
> 1684		if (lock_is_write(flock)) {
  1685			cifs_dbg(FYI, "F_WRLCK\n");
  1686			*type |= server->vals->exclusive_lock_type;
  1687			*lock = 1;
> 1688		} else if (lock_is_unlock(flock)) {
  1689			cifs_dbg(FYI, "F_UNLCK\n");
  1690			*type |= server->vals->unlock_lock_type;
  1691			*unlock = 1;
  1692			/* Check if unlock includes more than one lock range */
> 1693		} else if (lock_is_read(flock)) {
  1694			cifs_dbg(FYI, "F_RDLCK\n");
  1695			*type |= server->vals->shared_lock_type;
  1696			*lock = 1;
  1697		} else if (flock->fl_type == F_EXLCK) {
  1698			cifs_dbg(FYI, "F_EXLCK\n");
  1699			*type |= server->vals->exclusive_lock_type;
  1700			*lock = 1;
  1701		} else if (flock->fl_type == F_SHLCK) {
  1702			cifs_dbg(FYI, "F_SHLCK\n");
  1703			*type |= server->vals->shared_lock_type;
  1704			*lock = 1;
  1705		} else
  1706			cifs_dbg(FYI, "Unknown type of lock\n");
  1707	}
  1708	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki