From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1269C48297 for ; Tue, 6 Feb 2024 20:23:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D3F76B0074; Tue, 6 Feb 2024 15:23:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 083CE6B0078; Tue, 6 Feb 2024 15:23:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8D786B007D; Tue, 6 Feb 2024 15:23:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D71206B0074 for ; Tue, 6 Feb 2024 15:23:53 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A8CBE1C164D for ; Tue, 6 Feb 2024 20:23:53 +0000 (UTC) X-FDA: 81762505146.30.74BDE05 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 53A2DA001B for ; Tue, 6 Feb 2024 20:23:50 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=WqRutX0z; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707251032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=07GLsY3wGCdeQZHm7Fg/VGTYyeyPIhloUHT+HXWDZbs=; b=2Fk9yQ/rS5F19/+SWihQgFYaUAwIw4rXrEW95eaXGuGmZ2/Bq6z38Dv7xHUINYl2rdYGo3 klCahHZIyr2i/ikuykF099pOOehq0kZ8xEIikygUB0tTMmyFRCb4PdNtgXgOU70muRlBPg 4U09KD67dXCfnYbhP8sgabqC/MeEDx0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=WqRutX0z; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707251032; a=rsa-sha256; cv=none; b=CbJoGaTLV+PsSZi0JhT63wUnzTqcNL98YlarIcTJ5JAV51XsduuvcjsBweFG8cdSXfYkuk FEmZFXC8MhoIl9EtCm4Ps9tES8J9NEPjrEpi36i4yS5C1YlNGSr0TeluvNHTYwj/KR2h9u qFV3peysC7a90U+NM6xR7gQeUkQWUTM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6C596CE0F1B; Tue, 6 Feb 2024 20:23:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84F09C433C7; Tue, 6 Feb 2024 20:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707251025; bh=R3Gvp712DLBLHZrUWRKpfJXFpWCymIU4evTbHKyLl8w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WqRutX0z7G4glv+gctBfnfBw81mKOeIYgGNtrpvvn1O8Np/rV9zimnIH30YuEmrZJ RCozwJf130thBphzjwKFkJaCetuHAZhyUCmyN7dA9ma9CA5iV0y+dodnJ+6Sdayvuy MVIabme+wrBOkzqAVNPqTO0pRZxK6DzEB3/jtNOk= Date: Tue, 6 Feb 2024 12:23:44 -0800 From: Andrew Morton To: Li Zhijian Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" , "Aneesh Kumar K . V" Subject: Re: [PATCH v2] mm/demotion: print demotion targets Message-Id: <20240206122344.4cd39c6ebb37871912c459fe@linux-foundation.org> In-Reply-To: <20240206020151.605516-1-lizhijian@fujitsu.com> References: <20240206020151.605516-1-lizhijian@fujitsu.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 53A2DA001B X-Rspam-User: X-Stat-Signature: tmjpby4spq6ftxc6qmz397ityhsyxddq X-Rspamd-Server: rspam01 X-HE-Tag: 1707251030-957292 X-HE-Meta: U2FsdGVkX1/lVlqo/xptA2X3GQ8g9BiAPblbf4s1QKjS7I7njuntIWgu7FtWracHWkM0sW9HIobOtYeXTK0FdhUZxO0EE9eUe6J7BAqieNemqJT8B+TQp/zxkyKlikk9tdlVz6UDgalECNMPYbTYqsWMITILLZtanCGRmRRC5Dw5ifbvz0ft19SZllJz8v+sLFVAn+60aJZp1Ylgf9lwtJkayj4qeGeQ313QNiSZSM7WwQZcKcNnVk/M7L9T43BD1IGkZcvo5hznmOD8kbGB5iY7ivTI865Ky4SiHSlxaFho36glL0dVLLqEVIj/H/9pnYKp8xBG4X7j36Fp8s1pJIjZvzlgiBiaMUDutiWbLp7GI8Mg4clAROD+586Rv/Lp0hNAT86JymoOBlgKlGN5+mZJScAkzhKVaCwOf4O9qedE917BEHOobVV0TqO1Kjr1qKd8xbYzOvc6RwguAFBMWwMaRu9HHoRZtbC43HMdFnRFy3RtbhnNx4jYsO5qc3ZxOBh/auaSvE1bcL+CD+9A4lCWyj9HtuEKQ1rNdoRj8l9YszPDKKgnJbggt7qNFrZ29AHvrwcas+8OcPU1n1rSE3MPZUFo9dxe9vzwi2PPdt1aCVKKWCfJwGpsvh5gDXiyNd67wSFEHwgqbSGDLt4XmowHvDYfl+biKrfg5V+ae/yim8VjToOQqyxYE4dID6KpgecDdMxmNF8wBLdCtq4MXi5VRhn+Vz+qoS+zYv9wrfhAGrBxzBPW1KoJxuCWv/7eOfhUpZwDfoNuyylFhcv9dqIBqjha5eX4InOmRMVCtrK4Q60MvbAYhaZd88/q3VR1pO405nr58EOuC9EsmgbzWQCEPLDudRAhHZneTgELMtD8DkYmK/DvWwQcQOW0gLrns3zovNuKY+wfEqxg4vMMzZBxQifH7LwUZw6GFpJ2d/nbf+IbkBEO5fm7jNNEjxfh7z7UH9nx4CWoDBM977Q PHgXogs8 zSyPiEg7bpIdzNswD4H5XRFcvKNCDWT32Np8tOghEMhUctbv89USdrpFyHmKuCZ2m0G3eaYlxnR4zV9XuV7XggNNAUND6mjT/BWXeYTeH5C+cYbXo93bSv68VPc3jm7TQYelVB3cz76o8pGMNf8/2G3AKYSckBbTdFFn22ak6UCnJeXYIch4dsbnKc3kckc+DvdU0KrXHaijx4omt5F+VyS0K1KmB0IeKzBwB6rnQiiJZiLkiBgCxMHyGEHpzkAAgtW/urH9zYj91k60= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 6 Feb 2024 10:01:51 +0800 Li Zhijian wrote: > Currently, when a demotion occurs, it will prioritize selecting a node > from the preferred targets as the destination node for the demotion. If > the preferred node does not meet the requirements, it will try from all > the lower memory tier nodes until it finds a suitable demotion destination > node or ultimately fails. > > However, the demotion target information isn't exposed to the users, > especially the preferred target information, which relies on more factors. > This makes users hard to understand the exact demotion behavior. > > Rather than having a new sys interface to expose this information, > printing directly to kernel messages, just like the current page > allocation fallback order does. > > ... > > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -359,6 +359,26 @@ static void disable_all_demotion_targets(void) > synchronize_rcu(); > } > > +static void dump_demotion_targets(void) Unrelated, but... establish_demotion_targets() should be __meminit, so dump_demotion_targets() could also be __meminit.