From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EECAC4828D for ; Tue, 6 Feb 2024 17:39:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D01B96B007D; Tue, 6 Feb 2024 12:39:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB19E6B007E; Tue, 6 Feb 2024 12:39:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA1516B0080; Tue, 6 Feb 2024 12:39:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AB4E16B007D for ; Tue, 6 Feb 2024 12:39:01 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8026BA21A0 for ; Tue, 6 Feb 2024 17:39:01 +0000 (UTC) X-FDA: 81762089682.10.7AF9616 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id BD0D1160002 for ; Tue, 6 Feb 2024 17:38:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lciMhFVw; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707241139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mHeSd8vALwZNvxx3hXr+M/CFbEmbTwE3R8UOSCmQ01M=; b=KHcFzfF4kTRtkbBbnnUQlPEwldmOJ1/ouuia1GL1jsEpKkypfuIJKJOHzcAlmOuSQZx09j df2edcsLU1fH3mqdc/3vPusJm44Tc08Y7GBu4JjLi1D73JaI6jsnVk5ZXK4g0lCvCVeGNw EDjMJkG02kBtIPt7ZWvsPH0aFvv8tRY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=lciMhFVw; dmarc=none; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707241139; a=rsa-sha256; cv=none; b=iQDPjtoiFhs11hWZb1zSOaB2yFJcOgaODRQ0PJrjxLa6EiQEq4tM0iEWTUOWEz/BY51Biz 2SaA3HdMzlWwcA3nVq8y5LY/KZ7RGmYBDIgeBH1v5chKPQ+8JSMEW55uwfxyukh6kBPOLA iUl+erwRcbBXUnvoXhOcsGxqQHq+MlQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9623261627; Tue, 6 Feb 2024 17:38:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 244A1C433F1; Tue, 6 Feb 2024 17:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1707241138; bh=rb8APAK/NFsWkjSw2CEJHSFqUkeP73aN71SPR67A7Ck=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lciMhFVwD8spj2zXqwGFIForrObq2F8BJkxbrdxDdYKg1fqbP5VAtqDJQUwue4+18 DItyjrNq9uxFdW2im98TsjO377IO4W5VqyMC915WTZkqw+Bcft2n+PVPZvdbs5uY3o Qv7TvTU/TNfcgzvgW8xsYVdhfUp+yQrigOvQyjRk= Date: Tue, 6 Feb 2024 09:38:57 -0800 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, alexandru.elisei@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/cma: Add sysfs file 'release_pages_success' Message-Id: <20240206093857.d834af4f96d643c53e29e02d@linux-foundation.org> In-Reply-To: <20240206045731.472759-1-anshuman.khandual@arm.com> References: <20240206045731.472759-1-anshuman.khandual@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: w49t8u6ezcqm4s5o9bmct6b3bq3wq8wf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BD0D1160002 X-HE-Tag: 1707241139-354017 X-HE-Meta: U2FsdGVkX19529uBh9vsPwFC83GnT+GCqdXKwbMp5oKzcjoCviZW+xFeo1EGqmCEi2AyuelDddBoVAn9Bky5L3jewuCRVpCoWntOhh+xta5fD4A5vZPXELhHdurXXyzfnbhaEkuMX39TLzcsShCrRuPBmPBTbXTtMXE7zq2RG8sVFfB0p1+JDjnwRfNab9PFNa51nOdu5FNVbr3c74orEp1quK7fVMz8LwNHqNGUNvcnxDNOcotL21iR2lT/4C4CgEp+lasJAjHfYs9A/WJZU2Zcr1Ydx+L+k8X8xldNtukumIkoAVCFJYlXPdo8BALGeszOqvHd3Ez8+vPZHdmv4CfFvPh78ty/vOiAFDEpm3x2IoWFngyQQ3E7KGAw+EJYKuPkV984DrrYWPmCY1s0oPBHr8tGJ4SxUawhtlOiRnbr9xDMHnu0W2d8/lU0Pa5s+GCs66P+fzPphgp3qTtwsTxIZduG0XcdBA/RqumG+B7xvQTA7lF7YAq7WBKdFhn1OFdGWfgSA/Ja4v+oC4X/p8iibOVs6/vLOvjRbw9+ZF4c4LKDmCihTfq1Brsc1leUVqy4FskCXH44OCze8MZrBnRl4AHBCdOyO7nOVQB+wFp9E6QFe2yAiB1nXhtsLzTBNfWLiIbAViAqEk7M93j/TEtbDA//y5qo/gtMUaHZ7xLL1ay03WT7sAtuDQ/HaBnXe/Ee60+z8isZo53hLznKNYIJzt69mBJJwH3F5kCyHh/Xc9rCg7MN/pv+sTdksZNOvx6v6zEs34NQzpTkpUSzuU0HoEUAbkVgsEzVfQbQKxoqsZ6njM22zHjhqbz1fBVxOIH4ucxjlmViJy/q7x/VxPGQIdVVvih3sCojaV7Adjuk9oCeomuZkc/ZhfBFdu9W0pzSZPM9oEfDuvJPC9VWLkvXG8HH/XEDomSERcHg8SgUcFO4pkUTEVtg194CeR2e1E3fhszjNqN3HgQUmxn mMkXlrCI lIRIeQNkx6jXLRMvwMTK9+AB5EGzczj+br4zbiKGdLLj4AcHL+CIdhVZhgaMIvtFWTr1LgbYrYO4gCheLJ4SAiAfK26FVb0l/gBnsDnKjofWFltMD6GU8JMLJIOMkr1DLxz2E6fcrb7dhqCGyojqRcBgr9nUJWuZQ4AVbX8hOMTy2hhQvs5bIkEzERowaZ/A5zg8WtIBmpq7W9UsZMDzNXU3XwqVOrmIhx7X13Dx1AZA0fR9k9xaj0yPEjfh/fPCfGQm6GFdf2bFdpLcL4JhtvhUy1tphOlzQpW1bN2YAothaqfB7JmXJo2F+Qc/N6F17Kdya+3KVcv+t+iRjivh4toyORlQlTHSa2nSP5owo7n1REtpU4+Kgc1YJEf779Yr2T7Z+CoIIrWv8K3Xnv7TVSg01gg9xswhtabRw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 6 Feb 2024 10:27:31 +0530 Anshuman Khandual wrote: > This adds the following new sysfs file tracking the number of successfully > released pages from a given CMA heap area. Also like before - this will be > available via CONFIG_CMA_SYSFS, and help in determining active CMA pages > available on the system. "like before" is mysterious. Is this referring to some other patch? To existing code? Please be explicit and complete. > /sys/kernel/mm/cma//release_pages_success > > It adds an element 'nr_pages_released' (with CONFIG_CMA_SYSFS config) into > 'struct cma' which gets updated during cma_release(). The changelog doesn't explain why Linux needs this feature. The value to our users. Perhaps that info is buried in the link which is buried below the ^---$, but as this is the most important part of a changelog, it really should be spelled out here, completely and carefully please. > --- > This patch applies on v6.8-rc3 > > Some earlier relevant discussions regarding arm64 MTE dynamic tag storage > in this regard can be found here. > > https://lore.kernel.org/all/ZbpKyNVHfhf1-AAv@raptor/