linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, alexandru.elisei@arm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/cma: Add sysfs file 'release_pages_success'
Date: Tue, 6 Feb 2024 09:38:57 -0800	[thread overview]
Message-ID: <20240206093857.d834af4f96d643c53e29e02d@linux-foundation.org> (raw)
In-Reply-To: <20240206045731.472759-1-anshuman.khandual@arm.com>

On Tue,  6 Feb 2024 10:27:31 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:

> This adds the following new sysfs file tracking the number of successfully
> released pages from a given CMA heap area. Also like before - this will be
> available via CONFIG_CMA_SYSFS, and help in determining active CMA pages
> available on the system.

"like before" is mysterious.  Is this referring to some other patch? 
To existing code?  Please be explicit and complete.

> /sys/kernel/mm/cma/<cma-heap-area>/release_pages_success
> 
> It adds an element 'nr_pages_released' (with CONFIG_CMA_SYSFS config) into
> 'struct cma' which gets updated during cma_release().

The changelog doesn't explain why Linux needs this feature.  The value
to our users.  Perhaps that info is buried in the link which is buried
below the ^---$, but as this is the most important part of a changelog,
it really should be spelled out here, completely and carefully please.

> ---
> This patch applies on v6.8-rc3
> 
> Some earlier relevant discussions regarding arm64 MTE dynamic tag storage
> in this regard can be found here.
> 
> https://lore.kernel.org/all/ZbpKyNVHfhf1-AAv@raptor/


  reply	other threads:[~2024-02-06 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  4:57 Anshuman Khandual
2024-02-06 17:38 ` Andrew Morton [this message]
2024-02-07  4:34   ` Anshuman Khandual
2024-02-08  0:08     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240206093857.d834af4f96d643c53e29e02d@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=alexandru.elisei@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox