linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Christian Brauner <brauner@kernel.org>, NeilBrown <neilb@suse.de>
Subject: [linux-next:master 3180/4021] fs/ocfs2/stack_user.c:747:11: error: call to undeclared function 'lock_is_unlock'; ISO C99 and later do not support implicit function declarations
Date: Tue, 6 Feb 2024 05:35:02 +0800	[thread overview]
Message-ID: <202402060540.iVHnOa7m-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   23e11d0318521e8693459b0e4d23aec614b3b68b
commit: a336b91b2340eb6fe29f4a5898dd103b55c92091 [3180/4021] ocfs2: convert to using new filelock helpers
config: riscv-randconfig-001-20240205 (https://download.01.org/0day-ci/archive/20240206/202402060540.iVHnOa7m-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 7dd790db8b77c4a833c06632e903dc4f13877a64)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240206/202402060540.iVHnOa7m-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402060540.iVHnOa7m-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/ocfs2/stack_user.c:747:11: error: call to undeclared function 'lock_is_unlock'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     747 |         else if (lock_is_unlock(fl))
         |                  ^
   fs/ocfs2/stack_user.c:747:11: note: did you mean 'lock_pin_lock'?
   include/linux/lockdep.h:254:26: note: 'lock_pin_lock' declared here
     254 | extern struct pin_cookie lock_pin_lock(struct lockdep_map *lock);
         |                          ^
   1 error generated.


vim +/lock_is_unlock +747 fs/ocfs2/stack_user.c

   728	
   729	static int user_plock(struct ocfs2_cluster_connection *conn,
   730			      u64 ino,
   731			      struct file *file,
   732			      int cmd,
   733			      struct file_lock *fl)
   734	{
   735		/*
   736		 * This more or less just demuxes the plock request into any
   737		 * one of three dlm calls.
   738		 *
   739		 * Internally, fs/dlm will pass these to a misc device, which
   740		 * a userspace daemon will read and write to.
   741		 */
   742	
   743		if (cmd == F_CANCELLK)
   744			return dlm_posix_cancel(conn->cc_lockspace, ino, file, fl);
   745		else if (IS_GETLK(cmd))
   746			return dlm_posix_get(conn->cc_lockspace, ino, file, fl);
 > 747		else if (lock_is_unlock(fl))
   748			return dlm_posix_unlock(conn->cc_lockspace, ino, file, fl);
   749		else
   750			return dlm_posix_lock(conn->cc_lockspace, ino, file, cmd, fl);
   751	}
   752	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


                 reply	other threads:[~2024-02-05 21:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202402060540.iVHnOa7m-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=brauner@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=llvm@lists.linux.dev \
    --cc=neilb@suse.de \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox