From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A759FC48260 for ; Tue, 6 Feb 2024 03:27:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A51A6B0081; Mon, 5 Feb 2024 22:27:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3073C6B0082; Mon, 5 Feb 2024 22:27:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1814D6B0083; Mon, 5 Feb 2024 22:27:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 02AF66B0081 for ; Mon, 5 Feb 2024 22:27:08 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A1EC61A0B53 for ; Tue, 6 Feb 2024 03:27:07 +0000 (UTC) X-FDA: 81759942894.07.8F98115 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf05.hostedemail.com (Postfix) with ESMTP id CA91510000E for ; Tue, 6 Feb 2024 03:27:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lq+x7lhF; spf=pass (imf05.hostedemail.com: domain of cuiyangpei@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=cuiyangpei@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707190025; a=rsa-sha256; cv=none; b=bMuAIm9BbBPgv1ISCg7/E0/gOAJOFXFV9AESEc59wAiLD92Fca+5y6V7rp3vqRkLhRaWaz YwUXyRmwgwhEZN48bho/jX21eVlGM1K9TCn54D/pL32IMhXKkRMmMcZCkhbNRG1gLNBHXn WlEiR40pWxu5ElC7wHyzCaiGJL2ewXg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lq+x7lhF; spf=pass (imf05.hostedemail.com: domain of cuiyangpei@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=cuiyangpei@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707190025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EWmE4W0F6JzWR2V7Cfi7Q0WB8ukiHYzdqVQ4h9OXpcs=; b=VLKLG1+6gTseta+m0HSPSp/607cAPFj9aREGhtXFiiqe3bjOxu2UmoGStIElJu4cFl9gOV NXXYpMEkjWH6wt4CL6wqHYJCgtZDxio9ujT1d6bi92nw80akhtMbTEWN+L5iXS5bBeqWKo nZ0QB1HOczCl3/WTBAOscTUNb3lAVAs= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6e03f7f427aso944193b3a.2 for ; Mon, 05 Feb 2024 19:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707190024; x=1707794824; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EWmE4W0F6JzWR2V7Cfi7Q0WB8ukiHYzdqVQ4h9OXpcs=; b=lq+x7lhFHFjmppsXwIfpguIKDdGgOZ37In0kxbpEdpxO/2RCtIH/Pl0EIXUZ0TUDaz mFuh0Ip2bZsjbvyx/0Aancx8h9sAUrwfluQWfj8BAxX6h4LbQRBsU/yfqjm6/l5rHgcZ RNz0OyZ0kt4onqoty8BLQxeSaVnGQAdAxcS6+qq8Rr/jvdCJUNC+WIJFMzNvk2GPqImJ JjzfIFalJ0bDdk8DnMONJ//2PrZ+qlDQkaX/oicSd5ABrzpTda26WVHNc9BpOp4xY5Hs e3lDEn3t2aAjvt7HPh3vqh/3UTqoUrkQCtx5v153OL8pTtpUqu8+IGHKDu2ztCWCTkf5 B4Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707190024; x=1707794824; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EWmE4W0F6JzWR2V7Cfi7Q0WB8ukiHYzdqVQ4h9OXpcs=; b=v+XS5sG88mjpWuFCscB5/0RB28LzzI1uFFCuy5/5jEzqu0leE0mg9qBf+1MOIK/yhd Dwg+b0r2Rm6myu+pYPMQ178IAqP8VvZwaPQ4LHZjz3wjxfBeJEFno8OpRZZmy9BuZcKa VcxN0MeaqPUWrhKyYKz84ey9VpShxWYc1NOAZDwI/BVLczY+zX5rfgHiKVNb8V11cwJl M0ksm8JA+YJ98VQEa/vk94pRzdyWghJGS1ldfXzGOosTTn9WvDhcSF2Zl/dRrAIQ79rd IEjEn43RGnCDRy3+ydLdE7/dSJrkh1iGI4V9MrUyUCqSTbW98t2j4JnTHmNijlLyrRBj ldCg== X-Gm-Message-State: AOJu0Yw8ssJCz4Ls7MpKHUOCnAK3BZ46bPqHCySE5qiUVIqFFVSSXq7F K4i6S+ahuNyJDjSrEgFoJNze1NOTJmODqIUA030j1mMUuxnlLDCe X-Google-Smtp-Source: AGHT+IFcLAO3UlSWN5NwuxhRD3zbinWJslbqmyaRKdP55n6E6QCBvshFD0VOa6+HmXyocmdEJv6olA== X-Received: by 2002:a05:6a00:1acf:b0:6dd:c7ea:29e with SMTP id f15-20020a056a001acf00b006ddc7ea029emr1709495pfv.12.1707190024482; Mon, 05 Feb 2024 19:27:04 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVOoTZB6QeEbsv+OMvjJIOJR9yNONXJ6Fa3btU7RT25GjtJvKHYD/g7kMHQrmp3NKnj1SzGTJg3zPzz98MjmbnGyyYQqNTjKP0uCCkgGrx2mW8D1APiQCivyRJsioj30os47Nz01o3SGML1y64mrfMzQOPzFNiB+8HzAb9UL1AgPK9i/uRuyGb4nRAtZcnJ Received: from cuiyangpei ([43.224.245.227]) by smtp.gmail.com with ESMTPSA id t12-20020a62d14c000000b006dfef3ed2d4sm689223pfl.110.2024.02.05.19.27.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Feb 2024 19:27:04 -0800 (PST) Date: Tue, 6 Feb 2024 11:26:59 +0800 From: cuiyangpei To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xiongping1@xiaomi.com Subject: Re: [PATCH 1/2] mm/damon/sysfs: Implement recording feature Message-ID: <20240206032659.GA6910@cuiyangpei> References: <20240129121316.GA9706@cuiyangpei> <20240206025659.203155-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240206025659.203155-1-sj@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: CA91510000E X-Stat-Signature: zn8z9wwj34tbthzipn43k6xhw8x5xsic X-Rspam-User: X-HE-Tag: 1707190025-293968 X-HE-Meta: U2FsdGVkX19Cys9K3I8BKnnbJynyvzVpUczcX8rcZZ5NzIRC2+4RYBv5nfGkuESgWcfShyc+Pl5VSOzDYPGUj1+gYxYwqvG7DzGdSVBx+kn0AuPsukOnieDTYO2UQI+vf7RzslyAJ2qNAXEHE6+R1AR6/i3CRCd7a/YRiJ7brfclt7ZUIWFYb6vsOgGm9vcJFMsMJF9Pgs4booHZntnV2N5yKHCYUr2LCcek3njAEdkP731fLAoC1vTNM5LiDqbvUWIcmnfFKZRirRG5g1QgsIVwMhad4XrCco1WJ0Ab/Iv0TIfAoScinDd7G9S4q+IuGLU5KaEz+aisZiVPnFabTKUD2p2q6aO1EyvaBrsd4ptja0veZvMZEqOuor4fefHqtWbPcpHgX3ByX0xTHcYF+fmeds4eajAmge7BXhWxxg4reNTegs22x5QcMExsYZJHMsknbxwiFjV/jbGL11qU1KaoF4NpDJ+jgqQOi3Z7sDH1TgvvzTCpvENipF0EFFgngftPnJcSw13t4NTZEqsgHBUblqZz9SLHgLxQes8RpdE7Knoy1zVNHROw69hcd+/8RzPyWrKt1pIbBswHVt1tXevSVVTwvev44dDFvtD/MYNmjLjGUycWvq/916Tq+hm+DGHaCV/rwcqyP6NSjM5xhpl84tpItX1nDz8H27PKIlcjLJGVB0PyTlD1oWIduWOgf2PYhYDPnlJKrV4UCAfH5sxb06kfaPd3gpZmAzK53v7BrZ93D4S+iRG535Rq2d+l+dYuS1hPdlnNqBAFzjdIaMeiulUyuJvZeHFRqk7sDi22IGAXzmDAakao4/imEMxD9x+FPRVUXsFYPJ2g8MVcHXqwkDN+qpksPg3Fn7LL7qWJP+QOg0VJf4yTYnlQ9uhy42U5xss2rF5vqlXGVR4KjDQVqjajEZwlAKBlGC3O6XsC5O7pt/OlAsWz55LMNH6rLDTZm/qtC+fddKdAjae V8OEKvDt 3Kjosklk2RfOTi36CbKM/J5PubawchQUpQ2KpeOj4m33yBRdpEmhCN5LnjZP6Bwo6rQVQoIInt/A7Y7nF9+PuArbj4ntnYenZDncFvbbBmyzujyUhB5SW++EVQv28wPFx4jmHN5Wh2A7ndDTyltJ3u0TqXR60TSDklN9pOLvZMTXWzU2D35ixL4c+jewfQkfKuHL6ObXIu1z7Evcx/Zu7TOs9g4sLcoQOYKpUQBFb7fu7ueikHWCuEm7FSYC3igf17MayS96RPKdM46Kr90Ja8gBoW+Sprn9kWjW6cKDvgxfOafBKiO6RedhFkew69kULh0liz3pm1XzWILx2i6kQQCw8m+8/GxEeJcCVEQQph3Or0kzjKazqYO6CuptLAbOJlL49G5IrI+drHw6ycfXz8uqOWjmECnBQlnfEkDa6QxpC0FXbynwQlBIMWO1QPGVV7h2OnAx0ie2TlYdBcDJNbWyoaOzTFGbSQlfplrLPd3FXvjFiBF38HVTHRMVcHrOVpHiGPe2GSp0OHvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.023134, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 05, 2024 at 06:56:59PM -0800, SeongJae Park wrote: > Hi Cuiyangpei, > > On Mon, 29 Jan 2024 20:13:16 +0800 cuiyangpei wrote: > > > On Sun, Jan 28, 2024 at 08:28:04AM -0800, SeongJae Park wrote: > > > On Sun, 28 Jan 2024 17:13:00 +0800 cuiyangpei wrote: > > > > > > > On Fri, Jan 26, 2024 at 12:04:54AM -0800, SeongJae Park wrote: > > > [...] > > > > > So, 'update_schemes_tried_regions' command is firstly handled by > > > > > 'damon_sysfs_cmd_request_callback()', which is registered as > > > > > after_wmarks_check() and after_aggregation() callback. Hence > > > > > 'update_schemes_tried_regions' command is still effectively working in > > > > > aggregation interval granularity. I think this is what you found, right? > > > > > > > > > Yes. > > > > > If I'm not wrongly understanding your point, I think the concern is valid. I > > > > > think we should make it works in sampling interval granularity. I will try to > > > > > make so. Would that work for your use case? > > > > > > > > > It's much better than working in aggregation interval. > > > > > > Thank you for confirming. I will start working on this. > > > > > > > Great, looking forward to seeing the progress. > > Just sent a patch[1] for this. > > I also updated DAMON user-space tool, damo, to use this improvement[2]. I hope > that to help others who using DAMON with their own tool to easily understand > how they can get the improvement from this patch. > > Also, please feel free to ask any questions and/or help. > > [1] https://lore.kernel.org/r/20240206025158.203097-1-sj@kernel.org > [2] https://github.com/awslabs/damo/commit/75af3a1c0b3e79cd3207f0f8df5b5ac39f887450 > > > Thanks, > SJ > > [...] Hi SeongJae, Thank you for sending the patch. I will verify this feature on the phone and reach out if I have any questions or require assistance. Thanks.