From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FFBBC48292 for ; Mon, 5 Feb 2024 20:11:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45C776B0071; Mon, 5 Feb 2024 15:11:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 40C526B0074; Mon, 5 Feb 2024 15:11:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D4016B0075; Mon, 5 Feb 2024 15:11:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D6976B0071 for ; Mon, 5 Feb 2024 15:11:19 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DC97D40954 for ; Mon, 5 Feb 2024 20:11:18 +0000 (UTC) X-FDA: 81758844636.27.46361FB Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf14.hostedemail.com (Postfix) with ESMTP id CC98A100026 for ; Mon, 5 Feb 2024 20:11:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=txhdvRjN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707163877; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d2qMT3u35mglUa4ImVfxY4C0ppBPUYOL8ACWhlAI1UY=; b=lm9K+V6Gi7RQwdoXRndPUZ8Ji8wS/xY2iAzz5yiz33kq6cVRH48aH9kmEMF+mpPF3YdHmj QAvxcNbgR13aclX2L4/VG8rYU9EoTjU2GBn6DTD0EtxGBAwA0Niv2vxoc232mzAB1+94O3 cJKJECq1JSJtd3cmWo03EBrJSiaH5Mc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=txhdvRjN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707163877; a=rsa-sha256; cv=none; b=14FFanyHK6IdRudfRtLmDFGlYGYr4rPG2CWhAMQaQSuuDVo43pRp9GHVYaZgyEalpfiMK7 Yo1DB22FmMgdxQbytr6QdqETN4azVEOIoTaQ2Ob3jPiH0sJyuKrHFfOK0XVaXOfwdxxb8+ gyE5wmFJpkQzK74rON7NeUPRtZVL9qs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 39FF1CE0FC0; Mon, 5 Feb 2024 20:11:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09C3AC433F1; Mon, 5 Feb 2024 20:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707163871; bh=5A3KTajyzlfiyqCx6ogaKRTMf5L1vQAHm6WF8BBbYi4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=txhdvRjNQDUnze0TucLwhHlfWSx5DElOfsPrV5PZgEMf2b7PGJ/Xh1MSSnX2klFqg BJtBpFfMuP8EskcGjS53a8adKDToULjwu8IWUKEootYIgDe90zxJSWYtoiKMgAlNgV sf4uFBsPQnQRCMpTBuXqi5KG1jTujQMP5ySigq26P1HBCG/P9KetItERYRdCExTc/g CbvEx/upsHlR1l71/7Md1L4+looSE206zPMzewBRcz+WNTElEOcVuvbfyI5KQ+WO9l CmoXpwmxAqZD8THlalIxap/J8gMrw/dGEzCj4QjWoE32UuRWd08myV19m+eA8it2IA sq+FGC6v342Qg== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, linux-mm@kvack.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon/core: check apply interval in Date: Mon, 5 Feb 2024 12:11:09 -0800 Message-Id: <20240205201109.88463-1-sj@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240204204946.87265-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CC98A100026 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6oruckjikjkkx3dzt8xxbrkyce6d4ceb X-HE-Tag: 1707163876-582274 X-HE-Meta: U2FsdGVkX1/J5iLN1XAxGd21hqfgIld8pRZeSkZ5E8hKYVestokRv5oAWihGKIwW7dNaATo6mzHKiRDXEqWGtiQatZJWmJr1dXG/94mi4ievn/1g6VFmUwitIwn02ltiSJuJ/jl2cuB1nUJjk593N89ZmKj6YkyNY1ml+2hypPWHQ3RNecrOcCtY0GTEJVCapa77N11QaHoepjhT+MISH+numcyoiz0ed6Q6wkBZiyv5pq8DUoLIKn5Hyue8kgYzvUZ+q5CJthDidwyQcJAfmStH1pnFoqvLC1SZi4SnHFUBxBtw2Af+EDvoLyJEfdD71M11Qht3HFOM6fUzz7YqLezA8YVDj882sQTLUvKybvRCJJZbd6m+M47KurhI1TKh4WYb9pZxwjJE5Y1k8TQyM19BwSfq61gsX0C0amwfX/kZYQ5V0m2qqeA4LJvst8DPTdmwpcNDHomnhNJ0djwL5SdGJuAqhF4xlD+yGm21Y4ex7B/XP0NMfjdwUj5/V/j5inu6lASQUH8k+5WBjuBkVx7XwRZPZu4L0w9NEOmztdPw+IDpKoCuj2ER3pU5KDkPjngkE4e5X9H2iRG/z3h2cu8cOH7P8yaC3qN/zQRrzbm1aP3NvjGDDPjz/zQtCp7rP80TeUxSXqfRH5CBefG/dqQHEZ+V0tOtfsyDGSkQGcd43n/waVzLN4Tu2+sp31rHzXjMXWTCR1WCSaTzr4oNEzVoFsOnHzy1KagKB1/2TTE3gV14XppEWT/dPjvA3kWlVsYxl4D0YQZ8Cd9bRdWjvVqDVLpEX3Wi3Qg9f9O+2mtkOaLDcs1mH4pMpnXxIePry4s7BSPQYfWVwmZtlOZ2Y+wUtxnoX6pFXdXkjFeUzpEq71T5J/z5B4vFCOeSxU5eS43ZUFzSNyqqcNGbOF68MpsHziJz8IrT/t0QvvL8HVGNItNVIHcqwlGxDqThNpKjafc9ldNG2vMCPh+WdgV Jl5NdBZe B4+YUB335vQzwlBfD965qnmyPOOuRQ76RZEIV8bi8jmFsMgilAuRSz89e8DHu0c4UkQdCmviclARi+i+X2mB85L6W6YtFfuBfoOZ3VkXWGQvmqQUaP38PqPJeyRTp0C8VpPcVspMfjJmRFpAFAeWs0hyEPbfZdIYidgaY4FE7myMdyhxwQxxNmoUeOsP6TXVipriNBF0HiuR1gZmBGD7XCf/WCsPovdeCR+0Yc+1w8vrnzQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I mistakenly broke the subject of the patch. I will send the complete one again. On Sun, 4 Feb 2024 12:49:46 -0800 SeongJae Park wrote: > kdamond_apply_schemes() checks apply intervals of schemes and avoid > further applying any schemes if no scheme passed its apply interval. > However, the following schemes applying function, > damon_do_apply_schemes() iterates all schemes without the apply interval > check. As a result, the shortest apply interval is applied to all > schemes. Fix the problem by checking the apply interval in > damon_do_apply_schemes(). > > Fixes: 42f994b71404 ("mm/damon/core: implement scheme-specific apply interval") > Cc: # 6.7.x > Signed-off-by: SeongJae Park > --- > mm/damon/core.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 0c144fb466b8..f444734cc613 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -1064,6 +1064,9 @@ static void damon_do_apply_schemes(struct damon_ctx *c, > damon_for_each_scheme(s, c) { > struct damos_quota *quota = &s->quota; > > + if (c->passed_sample_intervals != s->next_apply_sis) > + continue; > + > if (!s->wmarks.activated) > continue; > > @@ -1216,10 +1219,6 @@ static void kdamond_apply_schemes(struct damon_ctx *c) > if (c->passed_sample_intervals != s->next_apply_sis) > continue; > > - s->next_apply_sis += > - (s->apply_interval_us ? s->apply_interval_us : > - c->attrs.aggr_interval) / sample_interval; > - > if (!s->wmarks.activated) > continue; > > @@ -1235,6 +1234,14 @@ static void kdamond_apply_schemes(struct damon_ctx *c) > damon_for_each_region_safe(r, next_r, t) > damon_do_apply_schemes(c, t, r); > } > + > + damon_for_each_scheme(s, c) { > + if (c->passed_sample_intervals != s->next_apply_sis) > + continue; > + s->next_apply_sis += > + (s->apply_interval_us ? s->apply_interval_us : > + c->attrs.aggr_interval) / sample_interval; > + } > } > > /* > -- > 2.39.2