From: Breno Leitao <leitao@debian.org>
To: mike.kravetz@oracle.com, linux-mm@kvack.org,
akpm@linux-foundation.org, muchun.song@linux.dev
Cc: lstoakes@gmail.com, willy@infradead.org, hannes@cmpxchg.org,
mhocko@kernel.org, roman.gushchin@linux.dev,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] mm/hugetlb: Restore the reservation
Date: Mon, 5 Feb 2024 11:18:40 -0800 [thread overview]
Message-ID: <20240205191843.4009640-1-leitao@debian.org> (raw)
This is a fix for a case where a backing huge page could stolen after
madvise(MADV_DONTNEED).
A full reproducer is in selftest. See
https://lore.kernel.org/all/20240105155419.1939484-1-leitao@debian.org/
v1:
* https://lore.kernel.org/all/20240117171058.2192286-1-leitao@debian.org/
v2:
* In version 1, there was a lockdep dependency detected by syzbot.
* https://lore.kernel.org/all/00000000000050a2fb060fdc478c@google.com/
* The lockdep dependency was caused because `vma_add_reservation()` was
called with the pte lock. This is fixed now by deferring the
vma_add_reservation() to after the spinlock.
* Version 2 fixes the problem above by setting the restore_reserve bit
inside the ptl, but, calling vma_add_reservation() later, after the
lock is released.
* Reported by a test done by Ryan Roberts.
In order to test this patch, I instrumented the kernel with LOCKDEP and
KASAN, and run the following tests, without any regression:
* The self test that reproduces the problem
* All mm hugetlb selftests
SUMMARY: PASS=9 SKIP=0 FAIL=0
* All libhugetlbfs tests
PASS: 0 86
FAIL: 0 0
Breno Leitao (2):
mm/hugetlb: Restore the reservation if needed
selftests/mm: run_vmtests.sh: add hugetlb_madv_vs_map
mm/hugetlb.c | 25 +++++++++++++++++++++++
tools/testing/selftests/mm/run_vmtests.sh | 1 +
2 files changed, 26 insertions(+)
--
2.34.1
next reply other threads:[~2024-02-05 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 19:18 Breno Leitao [this message]
2024-02-05 19:18 ` [PATCH v2 1/2] mm/hugetlb: Restore the reservation if needed Breno Leitao
2024-02-05 19:18 ` [PATCH v2 2/2] selftests/mm: run_vmtests.sh: add hugetlb_madv_vs_map Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205191843.4009640-1-leitao@debian.org \
--to=leitao@debian.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox