From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D914C4828D for ; Mon, 5 Feb 2024 17:45:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBFC06B0089; Mon, 5 Feb 2024 12:45:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E70366B008C; Mon, 5 Feb 2024 12:45:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D38106B0092; Mon, 5 Feb 2024 12:45:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C45196B0089 for ; Mon, 5 Feb 2024 12:45:10 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 864961C0AF1 for ; Mon, 5 Feb 2024 17:45:10 +0000 (UTC) X-FDA: 81758476380.26.870EA63 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf09.hostedemail.com (Postfix) with ESMTP id CB5DA140020 for ; Mon, 5 Feb 2024 17:45:08 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=eF0SLAe9; spf=pass (imf09.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.50 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707155108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kr2vrWVlUyntHvMw7Si5zE2PHtWM0mT+einhFyctsMw=; b=7Cn72o1KORcHXegtccMEgruvqloG+qgliqujKXi3J30XVLBZoJiWAmK4qvnAqKq1V6WBo/ Ty5rDzDgoA1Eh70Oq+rQrcTaEuKLoPQG2e1j1J6SrTCZFbluNSJIeupNB9DCqx9kFLp94z S4kfAqtWLFsnkGvCCQnppqG9lfKHNnc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707155108; a=rsa-sha256; cv=none; b=AXhYc54xpFNPRAuiyBUJdyBHScnqhh9ivS1Jog33Eb/6mteD0MG04yWk7zrmiRcE4CZJnZ h/dpJi9GTYVJaRVZjmAxyAZbjJoU4Y+bBmoxsbuP8xMJtNSdQYR/lTCpOjzFGnGvGzWP6W hpl5JSnuD6rs/AezB52ClnHcRj3exLk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=eF0SLAe9; spf=pass (imf09.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.50 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-68c813ba956so23320866d6.3 for ; Mon, 05 Feb 2024 09:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1707155108; x=1707759908; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Kr2vrWVlUyntHvMw7Si5zE2PHtWM0mT+einhFyctsMw=; b=eF0SLAe9FKxpwEHsD1AVnblxRhKzqlvheXFDwcLvURYl85XPZjiLsqf+WL+OzHqecw Y0j3MwtNLCZIp3zrWRPhIQ2aTym1rqH6fEaohf7Ot+Ok097v2mZ1/Ml19/TH8GUPJDUO jlFYQmQCnnsP/96q5Ljt877dggVIaMu30/Cg72cuPaUnVXjh+eKjOVDLtYeNMQ3khzvN GFo4alR5n3y9C13zql+FrfE3sJ6n5E87anoi/UtFdN87FK6A/f5aW8IpZKM1JzYz1DHv bzs1qf4cmjwOcY+MzSc6VGIgMq6DPsPu3afg7AEm3tmoTLiMWPJDxUviVoHegOwILLMT 47uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707155108; x=1707759908; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Kr2vrWVlUyntHvMw7Si5zE2PHtWM0mT+einhFyctsMw=; b=P+5h2ntBR1TGdOjoJ8qFTVR2Q61sRIE2luEcSNUzZ9ARQTngMiyBoIMewpa75jK0eC WG77I4oDxkHlI7jyzMjaUwUqmvnuKqmcMqM6bJbxB6/Kc0tcjL+du8tZnoLNtUPOzmLY 5VZFkeApZ43POvBU+UDvCNiTvEprld15ERmtvjlOKgRyF2uGUTSc+NcDTmTUddvK/489 zadsz/swQLuzLTrNzVgmGFdqHyQEQm8Cit3pMCF0foLDZcG5S1avjs4uheenZURTD6Uf qfLlsoMldlmjir0/vN+GTo7OYbS01ZZJkSR1/Z6SZtyqG1PyXQGTKGwlPtyDpS7jqrW1 qvXA== X-Gm-Message-State: AOJu0YxhsvS8q8YlEWaKReRLxddysSWYvD6X8dpA2h57wHxGMB5pmat8 Ib7u3Ivl8GVUCkeCyFQHDMpm+lQonB0W983lHoa5YWdGzfyPpJlUa+ghonV9P+6VyicSBNq16rF s X-Google-Smtp-Source: AGHT+IHYMw0vd64OVr0zEMte3BX2BoxkRkfAfpiJiAxhjtbWihbl0rcbbYsuxMOB9Sysr++MU/eDAQ== X-Received: by 2002:a0c:e14b:0:b0:68c:850d:7e12 with SMTP id c11-20020a0ce14b000000b0068c850d7e12mr85628qvl.50.1707155107926; Mon, 05 Feb 2024 09:45:07 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWYPsWNFHv61exg+gMCQoag7gBZCOBqvyfZr1G9u+oPjqyrOwq3LYPfZ8DHnZ3lXGCW2H019rMJwKaxvLdC5XJN8bQPMtNx4sk0ynWnOH6QQ0slFrl5Ptdld6MfH+LsWOHXY6wGQ6IS12X4C5mk7za1Dt+B8lfZb10uQeB7pc/qZi7KKSgE4gi5/CGlXF+4KBrVRqMRlkZd5pnzVvhMFtp+/ID8YmfxZrrlM0m4QZoS0fYfjZl2v7d6XT0Gx8rUoXS0m9BTSzGFi8JG1cntWWEOJqGd7n7hHxxx4nUep3NwoA6HXavGEL5rXEZrdH+4UAd5sTZupOuxdbJV7A27rTBK67ACC96kircN6b9iBI1gGhtBpK9vNzQrHhudWql3BnS1EE1AS6aSX0WJ9rQHdrdmf3f9tnqcPEtENeciOx5OKeqVX5FAJReENYnTCNdQvPLNQer06oyzN3teSNcXQ48e1ehHBdIWISjJ7sB2lCzU73LG6HbNiR6oXT2JmXEqVaaiqtvL9iLUZ27KHPnSmSugFdYit9jQu51JSiHQgMtqIEKWj8uDuoLdyqhILWFR2ijsYJiEOHPgbH/hy+qkOlatgS3FAMrr+S/UgXx1wrJIAxxRZPk41WEdoxjJjHo8C0dZRbsUwVnhWcFMQZxRkFnSxxmnzmE6FnjNBZzNic9S6vFkSUtAKElK/+YSZSgxAevXVtsRW/5Env/IJqiTts//EICbFYy2RiY+TC0rAd9SM2NM Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id lx13-20020a0562145f0d00b006819bb31533sm176462qvb.99.2024.02.05.09.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 09:45:07 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1rX31n-000fbS-19; Mon, 05 Feb 2024 13:45:07 -0400 Date: Mon, 5 Feb 2024 13:45:07 -0400 From: Jason Gunthorpe To: James Gowans Cc: linux-kernel@vger.kernel.org, Eric Biederman , kexec@lists.infradead.org, Joerg Roedel , Will Deacon , iommu@lists.linux.dev, Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Sean Christopherson , kvm@vger.kernel.org, Andrew Morton , linux-mm@kvack.org, Alexander Graf , David Woodhouse , "Jan H . Schoenherr" , Usama Arif , Anthony Yznaga , Stanislav Kinsburskii , madvenka@linux.microsoft.com, steven.sistare@oracle.com, yuleixzhang@tencent.com Subject: Re: [RFC 11/18] dma-iommu: Always enable deferred attaches for liveupdate Message-ID: <20240205174507.GD31743@ziepe.ca> References: <20240205120203.60312-1-jgowans@amazon.com> <20240205120203.60312-12-jgowans@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205120203.60312-12-jgowans@amazon.com> X-Rspamd-Queue-Id: CB5DA140020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ubcszmzkj99sbux747czop7raysq8b1u X-HE-Tag: 1707155108-170800 X-HE-Meta: U2FsdGVkX185K5GxXYxO3tRDOQBbuTO+VjjDjs/crZvjX87KrWz0Vx0BnAJkt4KxRFG5g315zkVN6H/HWeKfJNWz66hYrJ/+VkkeBOH36Np/Ay7Tj2qvPgqB5/7VgJ/vLTVlGQcPYQad7BDcx0fSqmjBfZN/uiao6hNnIDHEimZcgT3Cv54Ad09G3Sm8fwM8GxbKkMbYki1c01+JH74J02+dRtth6Kf0Y/T/2PpeJGHH3GBCLBaQQ7pDOo1NbiR3vnNRpdmOE8PzMjEYIkdX0Zi+5nL7J9rgp8/LFtnxbZt/IXF4GC54f1xrH6r3ZG+Y/HKeEdBkitTO18EnhDVDbQ1lVRHfrgGRPRhxRENy5gBl/nyhC6KJb3AgB/g4qn6TrHPlUsxAIkixNHnuu34LnnHOw37Qq2+d9evSkXgfYChFMyT2S3fa9OYIX+9EK6PcbOofqy4/GCSB3mn0p6kDqdUk0od2o1ZJMbblWrNosh2r5IOXzMi4MqNK8UCrw5PkHYUA+5jKhzARkMyNWiPq2eZ07rvV12gJ8vXPck0xOR4xBrKUbtPEPO6Xd6h5Ve0XfOn7AziHpEWfYScjF92TO78G5PQY/7j+0nHdhNXQfKTwMiehyVkmtlcT+ZH/NaXMkCn9/2arEaL5pZZHTpSBaVexdOGeohilQR+8ezSe3tqf0AfiQZ8ZHfz9WPCqwIz/20yGQwxT90N7qNLlVm/XHBpucvprSe8W7WR7chmPybgZ9t05rgOiKaqDPJHu9tl/o1OjY6piSrZ0fvWE6NTv8h1dEZCmtls+v5djVkkyRGviqXsZllsbjncTrDcOhoSAQcuUyS+otxm0yHIzGnVhicCiXSzI6K4P9yAA7iK0IXF83OOr9TnYgSff+WgRbTA/tKDvUs14lX6y3T5FfB9YRgvPLHDkCQ1XmN4ttQd7Q6WNPLCQo6PMNACzp7iqu3oLjJsKgf01PyhI3+VZtu8 U+g4PG+1 p3dxOtcrvM12N04Xvfal/lYmI1hETPUnTHluhBMlgK32Tjb0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.007896, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 05, 2024 at 12:01:56PM +0000, James Gowans wrote: > Seeing as translations are pre-enabled, all devices will be set for > deferred attach. The deferred attached actually has to be done when > doing DMA mapping for devices to work. This shouldn't be part of your solution.. A DMA API using driver should never be attached to a device that is being persisted across a kexec. If it does then the device should be fully reset and re-attached to the normal DMA API iommu domain. You should be striving to have an iommu_domain to represent the special post-kexec translation regime. Jason