From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DE7C4828D for ; Mon, 5 Feb 2024 11:43:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CE086B007D; Mon, 5 Feb 2024 06:43:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 856FF6B007E; Mon, 5 Feb 2024 06:43:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D0E36B0080; Mon, 5 Feb 2024 06:43:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5743E6B007D for ; Mon, 5 Feb 2024 06:43:42 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2C5B6A04C7 for ; Mon, 5 Feb 2024 11:43:42 +0000 (UTC) X-FDA: 81757565484.27.72AE86E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 06D3716000D for ; Mon, 5 Feb 2024 11:43:39 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nnEt+6Ta; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mgicj8+Z; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nnEt+6Ta; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mgicj8+Z; dmarc=none; spf=pass (imf08.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707133420; a=rsa-sha256; cv=none; b=q5uprVkVJstvnMBvz/B/M3f/D7tkbx1dFEYi9F6pXO9dfhQ0Ym+jpXUViTREv6+81ZRQSl pvODf96DSr1FvDVZEBRS6O1Llj4qzlwlBd8SEqRBASE65ckICHPJscq42VmoDRZKygSAOj ZoCLMEB83gUxebAHXtn4zjKLzSF59Us= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nnEt+6Ta; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mgicj8+Z; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nnEt+6Ta; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mgicj8+Z; dmarc=none; spf=pass (imf08.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707133420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0PuzXhLwyJ6hL46dcFxwenDBPB8LUfJn9fPk0vsMfBM=; b=rOLX+U8fQ4s9dIxKKRcN7GRAcRrLzugcI/YOrRTPzRdM3CAXeU6lSOo1kY2cjZotFbmZEV OYOIizVHrueY1dtUqIaVqsc7hzHr7q/SXG4btQcxoJwFogQ2u0KQDqRjFD3ovW2+yKWoIU LYWDk+gQ4nLTO8r+TbVFcy1HsUTxATg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 063872227F; Mon, 5 Feb 2024 11:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707133418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PuzXhLwyJ6hL46dcFxwenDBPB8LUfJn9fPk0vsMfBM=; b=nnEt+6TamS7Wde7eoXF4sK3iocuJhs0LuDm9519pSHulP2Ab0O/ETe938vq61/6JCk78WK Kgv5I870s0aXufrAtQm974jkSw3jVd2itVd8v24CUFU5prlVaqR+4N+MBJkqV4br5jh7TI WbtXIy8dRF5KLYcn8joDMvQEjQanEQ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707133418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PuzXhLwyJ6hL46dcFxwenDBPB8LUfJn9fPk0vsMfBM=; b=mgicj8+ZHMtv3Xme9QARO8ZoyIPZbrgZpGuMjwXj6voIxRNm101V/tsR68iiLqnfZZt0B1 eeNGxcx1wd4Y88Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1707133418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PuzXhLwyJ6hL46dcFxwenDBPB8LUfJn9fPk0vsMfBM=; b=nnEt+6TamS7Wde7eoXF4sK3iocuJhs0LuDm9519pSHulP2Ab0O/ETe938vq61/6JCk78WK Kgv5I870s0aXufrAtQm974jkSw3jVd2itVd8v24CUFU5prlVaqR+4N+MBJkqV4br5jh7TI WbtXIy8dRF5KLYcn8joDMvQEjQanEQ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1707133418; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0PuzXhLwyJ6hL46dcFxwenDBPB8LUfJn9fPk0vsMfBM=; b=mgicj8+ZHMtv3Xme9QARO8ZoyIPZbrgZpGuMjwXj6voIxRNm101V/tsR68iiLqnfZZt0B1 eeNGxcx1wd4Y88Dw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id ED27B136F5; Mon, 5 Feb 2024 11:43:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Rm7fOenJwGWFRAAAD6G6ig (envelope-from ); Mon, 05 Feb 2024 11:43:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id A40B2A0809; Mon, 5 Feb 2024 12:43:37 +0100 (CET) Date: Mon, 5 Feb 2024 12:43:37 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, Matthew Wilcox , Jan Kara , David Howells , Brian Foster , Christian Brauner , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 13/13] writeback: Remove a use of write_cache_pages() from do_writepages() Message-ID: <20240205114337.74l7sjanbmajqodt@quack3> References: <20240203071147.862076-1-hch@lst.de> <20240203071147.862076-14-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240203071147.862076-14-hch@lst.de> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 06D3716000D X-Stat-Signature: uq71ix89qt597mg1yumainpud76abbrk X-HE-Tag: 1707133419-560435 X-HE-Meta: U2FsdGVkX1/pxsnLkujumVczS0RZD0Cy4/QVa7gDGboTF9rjA+9nRbYxvzvPElP/LUXciwlLNr2xrUURDds48MdWm+fR9dgMzuDh02QsEP0uFS1AVpiya19EhPp3/+UBOF5cige1pqwaa1+ubZEOhquMQ9BBm+iCOP9PJPyleI+JiKZD5OaukdEIcN4GSwvjlCw9y2L45LLM85Xgead4juz7PcOgOsrfXohO7IBg7IOLsYbdoB0Vj0NssBEW3VQqgDTWSpARAtnxMSWVdKhuNLEt+Qd73VnfOR3/hO1zsaNpw29+BvTswfq7app9QK1Qtl+jnWJr/rU04WUXyk1rjkFaEafW+5NuezRjAKqe/Fc5cxTBd6G1aCC4HzS9wqvNyOeIQzowzQtvHYu8y0KNqsnXqvFb0UaZsPbdGl3IfcD0dkh9gHZbAc1FAoGw1242UEO69yzgYM/ndcO6aSDA9ze/aohR2nqTU/LQYa571IcQSn10jqxbJqTkcQyBvEdqo0mpHVUQDcrWQbABsXGGoC2qTUiGte3i4SiZPxTNKzRNNJD3BrxdBFnCN+u52edIKhAhaD8z6M6LqYXWhQ+BUQVQC5ZtkiB6gWr/g3XO4/ittG45oVYCPk2npkaPmPXrcIz2+EQcA+0aBAN9LP5infQbo9sgp39hn8uZ+RqXt8kxaeR/Erj1811epuN1K3fhWlN2ZNO7COtzcaDgDkVEbW9z7NAAMY88ZUzGGm93P55yuA7WI82G8vr7aI6aFPbnDu2Z1gFJ1Sqil+dd9vVnfKLPpWyU7+CZlumc2Q0/bxmqFKPKc0FxB6TC0s+Uktlq12Qoo3CPy4sugC7zCHjn8Gs96TB9yHAuesU+fix3NZz52e4G8HwpdCvxTQahsJR767WVd7ltBdb702bD6/qQJLJwnx6mhX+UXJbRvg0U8hVMYaB9Q+ofhk+TrOxvW8hs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 03-02-24 08:11:47, Christoph Hellwig wrote: > From: "Matthew Wilcox (Oracle)" > > Use the new writeback_iter() directly instead of indirecting > through a callback. > > Signed-off-by: Matthew Wilcox (Oracle) > [hch: ported to the while based iter style] > Signed-off-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara I've just noticed one preexisting problem which was made more visible by your reshuffling: > +static int writeback_use_writepage(struct address_space *mapping, > + struct writeback_control *wbc) > { > - struct address_space *mapping = data; > - int ret = mapping->a_ops->writepage(&folio->page, wbc); > - mapping_set_error(mapping, ret); > - return ret; > + struct folio *folio = NULL; > + struct blk_plug plug; > + int err; > + > + blk_start_plug(&plug); > + while ((folio = writeback_iter(mapping, wbc, folio, &err))) { > + err = mapping->a_ops->writepage(&folio->page, wbc); > + mapping_set_error(mapping, err); So if ->writepage() returns AOP_WRITEPAGE_ACTIVATE, we shouldn't call mapping_set_error() because that's just going to confuse the error tracking. > + if (err == AOP_WRITEPAGE_ACTIVATE) { > + folio_unlock(folio); > + err = 0; > + } > + } > + blk_finish_plug(&plug); > + > + return err; > } Honza -- Jan Kara SUSE Labs, CR