From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9657C48295 for ; Mon, 5 Feb 2024 12:48:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52F8E6B00A7; Mon, 5 Feb 2024 07:48:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B85D6B00A8; Mon, 5 Feb 2024 07:48:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359BF6B00A9; Mon, 5 Feb 2024 07:48:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 233D86B00A7 for ; Mon, 5 Feb 2024 07:48:13 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 90045805C2 for ; Mon, 5 Feb 2024 12:48:12 +0000 (UTC) X-FDA: 81757728024.25.01ED0CE Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf20.hostedemail.com (Postfix) with ESMTP id A1C6F1C000D for ; Mon, 5 Feb 2024 12:48:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GjUo6bRk; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707137290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jp4Q5U+zIlzWB/BXVKcZBw8dz1qw2kebfH71OdMWBLA=; b=Ccx7v9LYH8N4gOTFeCxnUs5AR6LeZcfxcNV7yxtdtaCclYKCrqsCRVBdhSHHCePeoKSpV7 FlDEwa+vyApYx6j9i5b7qcWa/AqqJm3mnlhdPEWnX40nhT/LV8QVMoXQr5lzuNQdsNmieS HSzgnQQd3dhhMRRC/my0ANsCypXMVXk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707137290; a=rsa-sha256; cv=none; b=5YaprR+9sWTj1cw9ypqjETvKRoJ4ScTpfAr6o6jBsPr8McG9TTUGOoZ0Jniynhcg5dqIEL HINxopZzcyMPnA/xciQGy3oVc+gsuN0q27aFJLq8PmzF/9NQhOAFPWKIpjVQ55v4two7HF H3bV81EoeUMnGtKjqut9+V6SARGAxr8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GjUo6bRk; spf=pass (imf20.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d70b0e521eso33059185ad.1 for ; Mon, 05 Feb 2024 04:48:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707137289; x=1707742089; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jp4Q5U+zIlzWB/BXVKcZBw8dz1qw2kebfH71OdMWBLA=; b=GjUo6bRk0NG6LrAVX8Oj2ZX3smRyOXfQfQ1zmXLuWiNtIcO67+TqIlrPvnK2paRdJ3 v2BXuiykhMMWkvhADslRXd2s7d1O+p1ZyhNont082mSKlLneiN9HEtcJ6LDC6YdGczJO qfzqux26hg58TyoX6oA2KlizsQW+f/SmJFzrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707137289; x=1707742089; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jp4Q5U+zIlzWB/BXVKcZBw8dz1qw2kebfH71OdMWBLA=; b=MKGZ7UEvP3LjtHc+k/PkldNQEve2GymYsleLk537joro9EYC2l+umJFJm+/6ipSNJH 93G4zpSikT3Myw8BihGGuJYmgOF9N9E1L3mIPW7YEyaYgBoKAV+cx8Azg+uW+MWZ86Yn euA7cWWFJ5czw9vForqABonOa6unMSbZiFbo2bo43NIKGYUsSdWQ2tDAgNP0qQgJcoMe +cQLc1zXspZdTEFhpqrXXW+ym6FjwU1p4wai5CwLalLmS7ODfBRq7RsabrzzcSsiSOq2 2DMVLRWswDu14OyMAOmcRoYt2EXmFdI2ZLXxWCSJcxGWfmPgcrM2f1xHX7G7SMmSX+sK rm1g== X-Gm-Message-State: AOJu0YwEXj9EWtqNANQsQexdWwXLvqkx5kHJ/kKTGjwsN3MFBBW8BAfQ XUf8zxnNjJGmbJ6OMqHvub12/qK/hsQ/9T8XGaQZEtUhKIomXGtRv+DKuQq1jU1Cohzfp1RlXPW VBg== X-Google-Smtp-Source: AGHT+IHYbwF4AZxr+BIBzkFZlJurA2gYc1bK0rKQHMh9C8dej+7vIsMA2pXzfcqyntpLUgE85vHpwA== X-Received: by 2002:a17:902:650c:b0:1d7:5943:21b8 with SMTP id b12-20020a170902650c00b001d7594321b8mr10194131plk.16.1707137289454; Mon, 05 Feb 2024 04:48:09 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUtCqunCXxFNFT2rH8Qo2NHg52HZy+4Sa2MQq2EyuiWJcNqHwBIykWLL0u4UqEOMaCvzCtpjJoWSPJUbo7DhzhZ89KO+u16Y1JBm7o5562Gp5pgdhGCm8ufKd7vcjieySULkIG/nzq0GkLQsstXEXl735jvLqddCGKwuHrNHkKp5ZiLBWIes7Vokht2n+r5MJeiPbiSiASXCuBhAAgdrAVebtCTsIVjqdKCwkMRQMYSwJsF6A0+Iz1F5wUcBFMa1Nqw08Pqw1euJtfaGsVLoDWOyTvqaNfiTKMjqmL/vrlUN5In9PeXNXXyH69zZaeBBLX2H/QFEFDCWpg/TUy18gJVkR0z9HhIcZhfZ7GxZndTXSPRoqSjSaq21UcPhGN2Z3TPQSo= Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id kh3-20020a170903064300b001d8f99e4737sm6318404plb.49.2024.02.05.04.48.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 04:48:08 -0800 (PST) Date: Mon, 5 Feb 2024 04:48:08 -0800 From: Kees Cook To: Alexey Dobriyan Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Florian Weimer , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Eric Biederman , linux-mm@kvack.org Subject: Re: [PATCH v4] ELF: AT_PAGE_SHIFT_MASK -- supply userspace with available page shifts Message-ID: <202402050445.0331B94A73@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 63ohmr8w49if6wam7mo1n6bopxerx49t X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A1C6F1C000D X-Rspam-User: X-HE-Tag: 1707137290-315520 X-HE-Meta: U2FsdGVkX19Li9DizoNaXC7IAod8425A4vAuriFOUuys9TgTuyW/dBxk2hzxoSpnn1DJEm8I/lAIrk2fYGEwd8a+0dIAo5re+xJF6LmhA1tuZJYJUtCgb0OQYrVtvzNC40dSKPeG/9Oy64vdTXXdIddYI1FI7z5QtUjgjbLx60nIFwNa5hBXz3R6ciAJm4pKxaHLI4OhskY3AGybU5RFSLKMi7d2WzaRFfHjdm+WE/oR5V5BawE2E5QosoT7UVJibCqJBjc26LxLRXDls0ZJjb0k6qavvizH5bp65tXZqd4ET52hTuxuyVrWAHjlgVYhlHr0R8v5TgvkT51VA36m2diOxH9s/bI8F4y66w+0k4Vo0AqZJyenVjU1bi7+Aaz0Ls4lFEMNGecUXMyLkbraXMYn31f3jdiD9ta1i+Bsw0PL4HO2Ydjcojc95k1qIEeAbFDKetWfMFpA1/Ts5JHZpKTjmU4qaHdY9EIzQxUhjZw808SmA2Uy2q9GJ3r5iKUHb5ers90L1uBPnR/0LAs8rhAMgkJxXqYf56Pp/DUXC8L5e/uOx5ECxBPE0/TozfQmdVzuMErR6IOYdjFpV8v1JPH17s2Ym1qg9PRu+Tdv5kTQuz563UtJXFaj3BoSvbWjWa2m3VOmkmQoOwe5vxTMg3ac3WOiKVGtEcqEcCBynJANEZyDCDCwBLZvg36h9ItSP27lvdZIQ0YLcwFNLjuY7PbOpkK8YjXw/sN+D/5Ed4AJGNettCoj7RcOyNDKPNnaqX5gQQFJU6KTEtYtbEFdVZ/nf/B7xelUUsk9W5m5ZgdHJDBufi/9Bv6jtv0Ai59+gcywMNdVFEYjf4r2OvPUj8oW/k7lin6EwZ0pFh/R8YOxHrc4rGEOAcn1RPJnLKb6ybEqb5dWXhu6URjwEL9DJdZvaXF/c4odfnLcTpscz0a6SApmeUCVkBj+fGqfAtQBz1eNM2lkS/hscowXJ0J N/ahgFJH yzVqKoS8PhEexLSUw2LCYxlgAAt9B5nS4jB2QIk3xnSsVDZsYxzNrFJPchHrasSeoRHnpORqyCIUheCSASDdb8USX61kJckJrEFqEN3eu2PX22iMBgyq8yziClr8fdSwGVGIp+KjR+q2aB+4WT/fLoD9W2wqvV4YtX24efVHoZFTyFpnf5x1msX7uAcnYnEW4XtVAXkSAvqHwHh6QrBAGIBzzyi/8QyaJaLg+sj20GKgwafUObSJKodkRouZood/zr7i3ereIF2E5FQyn4h3RjIr6KpkWL3ES6b3tMChPXBy+dfaR0BsQV7YciGNHKEtnZzVqXL8MV5AJoTo1ANRbp0RCveJBqOzKna16wFIepyGIKA+qlvQN23YfMWA2J33E1HOgayZxBjng32sc1nfSlB7i7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000666, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 05, 2024 at 12:51:43PM +0300, Alexey Dobriyan wrote: > +#define ARCH_AT_PAGE_SHIFT_MASK \ > + do { \ > + u32 val = 1 << 12; \ > + if (boot_cpu_has(X86_FEATURE_PSE)) { \ > + val |= 1 << 21; \ > + } \ > + if (boot_cpu_has(X86_FEATURE_GBPAGES)) { \ > + val |= 1 << 30; \ > + } \ Can we use something besides literal "12", "21", and "30" values here? -Kees -- Kees Cook