From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD49C4829B for ; Mon, 5 Feb 2024 04:26:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1E978D0002; Sun, 4 Feb 2024 23:26:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BCF238D0001; Sun, 4 Feb 2024 23:26:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABE138D0002; Sun, 4 Feb 2024 23:26:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9C39E8D0001 for ; Sun, 4 Feb 2024 23:26:36 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 58215C055A for ; Mon, 5 Feb 2024 04:26:36 +0000 (UTC) X-FDA: 81756463992.22.9D1480D Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf20.hostedemail.com (Postfix) with ESMTP id 371021C0010 for ; Mon, 5 Feb 2024 04:26:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of gehao@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=gehao@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707107194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=TqmW8OUAT2GvIeqBspSGxut5YnyqhBRHQyL7pEnqf3c=; b=TeH1/fhP5+qAFRZQiN2B/LHGT5O+auX1WqPjkW8Amjsu7tTlD4FAHIW674a5G9W6XrgkUi tmYzbeeikob9MC1qiuxRW63B7zn6nEZXbBWGi/ACRC+6eyq2fesGGNN9VpWRYJt/PyeOBh y08b+EH6KsaQL93igpZ3nilFn1uNiFc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707107194; a=rsa-sha256; cv=none; b=cMx1VG0NdyepquYx54Jm+pVYjjuLS65MiDeOMMLMaZWdM43en8AD0Sqpmk6WjOrkwA1r4Z FfRX2QjAFh4lHqgFlP+5kmIt0I7jCd1u0gNgc9Jd543+uY20UYU9ue7SEvfOO+i5yAXIIE V1eCrcYoXKXoe9xli3ryBUdlm1wdj5c= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of gehao@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=gehao@kylinos.cn; dmarc=none X-UUID: 82df3b9b26264eaa85c4e4ca7d33d3a0-20240205 X-CID-O-RULE: Release_Ham X-CID-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:10650bcc-489e-40c1-96ea-1d1d1f4a52e8,IP:15, URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:-5 X-CID-INFO: VERSION:1.1.35,REQID:10650bcc-489e-40c1-96ea-1d1d1f4a52e8,IP:15,UR L:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:-5 X-CID-META: VersionHash:5d391d7,CLOUDID:50f283fe-c16b-4159-a099-3b9d0558e447,B ulkID:240205102834I1NPY1F5,BulkQuantity:5,Recheck:0,SF:24|17|19|44|66|102, TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:41,QS:nil,BEC:nil,COL:0, OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 82df3b9b26264eaa85c4e4ca7d33d3a0-20240205 X-User: gehao@kylinos.cn Received: from localhost.localdomain [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 2087221324; Mon, 05 Feb 2024 12:26:22 +0800 From: Hao Ge To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gehao618@163.com, Hao Ge Subject: [PATCH] mm/vmscan: Make too_many_isolated return bool Date: Mon, 5 Feb 2024 12:26:18 +0800 Message-Id: <20240205042618.108140-1-gehao@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: odqnjq5y15tb44yiqu5e4d6ppgiu3na4 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 371021C0010 X-Rspam-User: X-HE-Tag: 1707107192-304233 X-HE-Meta: U2FsdGVkX188A3Bjzu3AgLWugQChQB28XSDGpKPE3uJzjHPA1TbzK13HUGsm0fL5hGAnoamLhwUf+Q9Dx7a3OjJF9F+bpbu609kh65PpXSevXEc5/YvgXyIKM6QSJlzeKc7OnMBFgS0fRKrkeEJQmFt0p3tbfHcxdcSvs+//V8w/tuZaGootXytvIkim8KHVea7DK/mrZG9ASWXfuWLICd89OHSX4Ya0bJPY8YBzF+UQFk1wp2c15gyMJ7Qa+1Fgw2iGAeLcH4HeLlLc5lI4e4l0RGZk7D5B/FJoF0OULu+JvNlcNf0HeLaP9zB/IwW6KrJtuhZtp9AWEtmVmxZCKtf1dJRoA+9sWohQDfbP04YxlVkKXlVbUyrAUo7WI7yT6PZ9ggokXjDuMMV4aRw/8yHcYiRmjNdqPmY/aVAIuHkQteFRlo/HAShIw8COVFSURxrgzjX0SDXI4R3Acyqre53ZZWuZ/7tQSSvv0Nfyf0yizJcF5xK10GIwTOuuZympDDDhcOlLJcdqE0PM/ZonL9uA1CbPU8xQBR3u0fiBWjQK09YrUN361jUGRSpw4s2MJOl66bPn5cdLddQhIrDhMsE/ijnbqGlNLsbwum8+0EVnn9pnP7zlEtFEGWCeMQ871QVThGu7SbeGRe/SECs5h6Ad4iHFI61OHOvpKXA1ayvNgpN4qnU+Fid3ihh2D+s9cMNfMI2hkP9ljkvfoEnhu+72d3Si4/BT+WQF9YKIpPlWARSKfgxT+EezzpmK5RfM0ALD8mpJ8J0v8hAVsJbgqc48CFuGW0iElwLkRov18i+NksLnD/880SshQgnFiOzwXgUqQxBSS0DQJRXQchRkPjlpCX9OW10E3IryJIWZcPVJisXf8GmA0gHZmdhy49UPSZkPIohxs62uKdjGOb8zxeKbaVfRKplcR7ptJ/Jp8abxq6gLE75vtZjIZfx7SdaG6Zkr2kRdZqdPIyWo48G S7kh4xMq /HxFW8eCnQ/j7PnS0eu89gKo6c+fJbOSWaMioV3Z/WSKYfWpjAqWEUzm+avk0ccJTtDyimFjmwEtputI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: too_many_isolated should return bool which with the same name and similar functions in mm/compaction.c already returned bool Signed-off-by: Hao Ge --- mm/vmscan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 4f9c854ce6cc..143e4b8e8821 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1744,17 +1744,17 @@ bool folio_isolate_lru(struct folio *folio) * the LRU list will go small and be scanned faster than necessary, leading to * unnecessary swapping, thrashing and OOM. */ -static int too_many_isolated(struct pglist_data *pgdat, int file, +static bool too_many_isolated(struct pglist_data *pgdat, int file, struct scan_control *sc) { unsigned long inactive, isolated; bool too_many; if (current_is_kswapd()) - return 0; + return false; if (!writeback_throttling_sane(sc)) - return 0; + return false; if (file) { inactive = node_page_state(pgdat, NR_INACTIVE_FILE); -- 2.25.1