From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB8AC4828F for ; Sun, 4 Feb 2024 13:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AE456B0074; Sun, 4 Feb 2024 08:09:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15ED36B0075; Sun, 4 Feb 2024 08:09:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04E706B0078; Sun, 4 Feb 2024 08:09:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E9A3D6B0074 for ; Sun, 4 Feb 2024 08:09:23 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BD11E1A0257 for ; Sun, 4 Feb 2024 13:09:23 +0000 (UTC) X-FDA: 81754152606.14.79696FB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 08DEF18001E for ; Sun, 4 Feb 2024 13:09:20 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=M4Um41+t; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf06.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707052161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+NJoLSVZxThuI8pKdUvxE4uLXUdMZOul6zavULR8eqA=; b=Hi3nl6sTcZpMQcwzo8FsTGiSAoE5EXOAuZ5Z/RXMoGiH4kRQ5yuAYdU+zUDwJtwKx/bkVj iCJLl+9G3+VZvdQSfc38Vud5D+VVnD8jHggpcEZlqlMY13iQFj5Hw1raoHDEUQI/ZmJtam B/AWZnOojbkoiphXRYkTkpkZcQNv6lw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=M4Um41+t; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf06.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707052161; a=rsa-sha256; cv=none; b=7hLDQ0unK747cCbsYDD6c08Bpnuxk91vymUHwnsVRwe546f+ALYtUtntk/bqIPYs/1Boj1 IwIsLFW/1TMPY7p1PB1GF7MLVRTn+6xAvrVreMCLmcryWSuSMAzpvZ7wAvBRINCp+6qNjX FZ1w8zkm3WtgyIuYfXYp5NrPyo6x4cg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0D64260BC2; Sun, 4 Feb 2024 13:09:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98F4EC433F1; Sun, 4 Feb 2024 13:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1707052159; bh=wS5G8p7qKOmOMkyKYFO2M4ZLkfVca+B/dMqr4h+AJCs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M4Um41+tWedkPEUIYTt1vo58ax57nGthjHG4mdjIl0VWInh0tJS8T2kBHdy5nHx/b H2tJkjwtUEVNmr6lpgWOO4n4y61V1EcXjLPWDJqE6bLBHP6dC79ENJj3zLzDRnAo96 SE2mueivUyNojMY4BP++VzsONomZLK84UtyCnZDg= Date: Sun, 4 Feb 2024 05:09:18 -0800 From: Greg KH To: Fangzheng Zhang Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fangzheng Zhang , Yuming Han , Chunyan Zhang Subject: Re: [PATCH] mm/slab: Add slabreclaim flag to slabinfo Message-ID: <2024020441-version-chihuahua-1067@gregkh> References: <20240131094442.28834-1-fangzheng.zhang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240131094442.28834-1-fangzheng.zhang@unisoc.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 08DEF18001E X-Stat-Signature: aghzfj7fhxsuxwxd3jdzk765gezntc66 X-Rspam-User: X-HE-Tag: 1707052160-489036 X-HE-Meta: U2FsdGVkX1/oVnExKLllr/A1gJgXqolLoQFJ+z8ll0VId9jAMUS2YURWt82Mimtvl7g0cUzwSD6/ldC78KX+IbRgmNoSwVwi3w83BtD/D9pmsMnklP7pel/XJdIY7Eb6nqrAFR8df1uGpte0A3qYW4cVueYuC75lgAz6XS75hCVny4mXgQsdp4VvQTPeSh737IXflxDD+IeVxk1JOW5DVEM4RW/pkn80SSEUJUkB/aA+DHqnJou4j9RBWxQYhpjTqiOq3ge5sihsV5tiSTkjHwz8veYvBMaXzYkWOMfRN608HHST5OW8/AbWY1N3/xOii4aTRX0wTURoXq3k12mkT4IfX8tAML57TeJtUztbgdOtyJQRsszt7LDXTpQVdM5nGGBwjFM1L+Z4n3ad0WYzqLfsSpj4HfIqErGv+VzQpXmAg2A2uAlmMH6mxmkTX94dSKrgPvePO4yDU8c8m0tETkVKBQsVqwZaTvL/epm9+tjquDJnrfXKXaggBZSDWIZRIbRsJQxupRFYCOBlq6sJY36Y8eyOptzDwhCcfHoicXejxCLteRSvpP4MpIcelWwWyt+WiTZsf2oV+CSHEDwCNLiAPLHOcIKJtgrTthazeiT2MD97yyym3trdojtnMXBft5URSiSOZE8Ui/kQwJk426Y4th+b6YzwCQn0S43TWLUM5wtxCkOo8qKj6GoRYYmX9jf1m5mLScw0wtd7h+dLcLR79WozZoxAYQzPZvgDNvJHwmoKyY5bNDzhitCWQOpXrYBey2DMogo1Vnju4fnpTB8kucenlj6zsRZHahbOjUlMd5U6F++Tpke9vUpz2n61WjpZ1yyxtCB4tKz+6Q7MMvJ/wgIT7Fx5FDD9AjEl8D13ZlpxEYJcKW8g8xCEbJCXeGK4OaXekdDUhuINoxAMi+DQ7njNXzhWNK60fgNVOLPzT9HZVcxQJVXLmyaigGGkYgcSsPgsA54Hvvbn3yW H6L5gYNh 4RsUWoPN8N4WklAyUZdwa7eky/WdBFAE3O3T7qH80h5pzX1ts6r1jSSdHTLl3TSfgVLWqYSxZxCkQQCMSIu4moqZmYCUXxqpYdgXgH4XOKtQhhY6CHGqdy2PHAaO71LfS+KKhsCrj58MvDsezA1qy7FvBAPUwiYSW5HIeknRxzkW/0NfSlspVIM7MuIT0325tj7BKWjLGAFqxk6BtW3ppzXcXnLSmif71Rk4YwTjBdKDYwqnN7zqWLVXoutctMKB5fbYepB3we68mVnUcdfTGgknRIGHY7LqATcHwuz4MdvBNtxRbt2x7/RpitnZlIE892jK/Yha4Rq6Y4iNjhASiaWpmvjp8jvAnoefgjbti1r/8iNG9rm6Nfg1woozQhFwP9cDq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 31, 2024 at 05:44:42PM +0800, Fangzheng Zhang wrote: > In order to enhance slab debugging, we add slabreclaim flag to > slabinfo. Slab type is also an important analysis point in slabinfo > for per slab, when various problems such as memory leaks or memory > statistics occur. > > Signed-off-by: Fangzheng Zhang > --- > mm/slab_common.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 238293b1dbe1..aeeb2bfe6dda 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -1038,7 +1038,7 @@ static void print_slabinfo_header(struct seq_file *m) > seq_puts(m, "slabinfo - version: 2.1\n"); > seq_puts(m, "# name "); > seq_puts(m, " : tunables "); > - seq_puts(m, " : slabdata "); > + seq_puts(m, " : slabdata "); Doesn't this change the slabinfo version number above? Where is this change documented so that userspace knows about it? thanks, greg k-h