From: Zhongkun He <hezhongkun.hzk@bytedance.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, Zhongkun He <hezhongkun.hzk@bytedance.com>
Subject: [PATCH] mm/z3fold:remove unneeded spinlock in z3fold_alloc
Date: Sun, 4 Feb 2024 21:15:43 +0800 [thread overview]
Message-ID: <20240204131543.1469661-1-hezhongkun.hzk@bytedance.com> (raw)
The spinklock in z3fold_alloc() is used to protect page->lru,
but now it was removed in commit 'e774a7bc7f0ad', so remove
the spinlock too.
Signed-off-by: Zhongkun He <hezhongkun.hzk@bytedance.com>
---
mm/z3fold.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/z3fold.c b/mm/z3fold.c
index 7f608c0667f3..58946cacbfbb 100644
--- a/mm/z3fold.c
+++ b/mm/z3fold.c
@@ -1068,9 +1068,7 @@ static int z3fold_alloc(struct z3fold_pool *pool, size_t size, gfp_t gfp,
add_to_unbuddied(pool, zhdr);
headless:
- spin_lock(&pool->lock);
*handle = encode_handle(zhdr, bud);
- spin_unlock(&pool->lock);
if (bud != HEADLESS)
z3fold_page_unlock(zhdr);
--
2.20.1
next reply other threads:[~2024-02-04 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 13:15 Zhongkun He [this message]
2024-02-08 3:34 ` Johannes Weiner
2024-02-08 17:29 ` [External] " Zhongkun He
2024-02-21 22:23 ` Andrew Morton
2024-02-22 2:40 ` [External] " Zhongkun He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240204131543.1469661-1-hezhongkun.hzk@bytedance.com \
--to=hezhongkun.hzk@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox