From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD68AC4828D for ; Sat, 3 Feb 2024 17:57:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 411866B007D; Sat, 3 Feb 2024 12:57:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 399E86B007E; Sat, 3 Feb 2024 12:57:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23A6A6B0080; Sat, 3 Feb 2024 12:57:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0CB0B6B007D for ; Sat, 3 Feb 2024 12:57:26 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D721480708 for ; Sat, 3 Feb 2024 17:57:25 +0000 (UTC) X-FDA: 81751249650.23.4466B7B Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf27.hostedemail.com (Postfix) with ESMTP id 32C4640005 for ; Sat, 3 Feb 2024 17:57:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=O+nhKXjJ; spf=pass (imf27.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706983044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h4uAO89DSf3RQZMzijlWW9jpjLoIfP0sKI92dPyza8I=; b=uitev4g3LyjXmIpLPlEwuiUHPR9ty9YqxrFNqSjTYGmsEGDt9xVmT64alcy6q5Pax/aLi+ AuiyafyHi2Eg2itNFEoF1r5QnsryJ8W5TjRQq4qfG89ZuokGNixw7pmxfc2Oz+Ct1CRUOf bdRPLh+HF/dU1g30B3rSswUe9ebPMy8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706983044; a=rsa-sha256; cv=none; b=K/4mcDW+0dbAKek4brn2IeTC3sd4aj/8Ut/zM2C2crguStLDUu9N9NlBHWnVwfokFtBCsi BdOQ+fvK8BVcGGpjmjg2gXV9hYMQkKGnNm0e/FHaIN4cKtkEaV4HJiKwV7RI3rU0RNKkZN zLxkp8pN/pHfneYYUnAqas4VLBgTscw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=O+nhKXjJ; spf=pass (imf27.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu; dmarc=pass (policy=none) header.from=mit.edu Received: from cwcc.thunk.org (pool-173-48-82-236.bstnma.fios.verizon.net [173.48.82.236]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 413Huov7016901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 3 Feb 2024 12:56:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1706983013; bh=h4uAO89DSf3RQZMzijlWW9jpjLoIfP0sKI92dPyza8I=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=O+nhKXjJO4bVxPcA0+xDLeYyR/sqs8uuGW+TPaiaVDrNmVE3w+SM6deaXpmr50Ere FpiFxB9itIewMFM95qnTK+S2B6YA1YPY0Ny0klz9GmM26aR1z1E0rFzIEnJYq2H3me /LvNGIvOroh9UQca/+fn73vzUE8pqW7xsVofDlyItFWUjKqOFtzCp7/qubKcSTxewZ dDTTtGkBWmMJ459MV3miwJCllru6eUPdGei58Cmt8l7vRmrSMIG2/be8CKVh1FRrVh /+4szohXgISbQZXvji31sVZbvx0TVPNOTshSxJOoNGaNvu7gjFBJsPJuxauEnr/Y/A Jd5A8VC8RAMlA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3261415C02FC; Sat, 3 Feb 2024 12:56:50 -0500 (EST) Date: Sat, 3 Feb 2024 12:56:50 -0500 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 04/26] ext4: add a hole extent entry in cache after punch Message-ID: <20240203175650.GG36616@mit.edu> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-5-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240127015825.1608160-5-yi.zhang@huaweicloud.com> X-Stat-Signature: re19j3s48r767gpokt3zb4wr41sz71eq X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 32C4640005 X-Rspam-User: X-HE-Tag: 1706983043-473653 X-HE-Meta: U2FsdGVkX1+SaJLlmJWrY6RquY/dWvdXXfDZvl2mR/92qw4gKwvIy3g9wovL8pgom0FmJ7tfDqHJE7FOchJpABNGJMgRWamy5DSngOpoi7GBiR43qnZb32JvT61TkpMxvhFPZl9ppCz+gs0UcVHGN/Gd41b89JAkv3rviCOVqv7hDeyHZAnOt0Ti7oBEZCHRus1BkBUfPzl3ak+ezvRY7rRc9Z+hYNZ1sgxG5ZmhfnvGPtTnoazoqiVjg3OHhTucWOG2/8C7OjSlAROlTtuKiuEmgm8miqWXe0cfqB0Ofkrrv12YRkwXse9HWJ9CsKUk+yNc9/m8sF1t6O0HVcIezkAY0alFALKSUtGEUZGReAFhdyQDYHqJofjb/fPBILCRzpYJuUoQMHc0Mbkz9kqEoyIgXBurcC9uQTj6N6gaOCeILNdOcBpDOKUntG/yV9g1psnRasefGnGksn0MmB0GGtQwEo85yqzSg9oD02azNh69TFgEQOSvZsoCwhUzVN0RjfkLwbdp3PhxpRS1ijGZkVw4ZJnalOf+kDyO3TCPU49l8144rowBIsjNDQ/koWeoVePBjBXWVjnc0Grfp1WnMOi+WuhMoT+5aRR0xuWuOTq/qEyYqIzU97iyS+789lpkmC+DjZc5JYJY1aS0wMdmY2M4daWaW834BHLix2xFX4KWJ2rKtJUviWaoJ/4cRihMtJNs4Yys0ggW35zLPJhLte1cSbzjMwFnEaiYeKUciFx+4QfuEFVQ6rHIeJnGtA/8w3rt6gA5upZSJFI+Xo2Ir49Up0+yR4t/sd/qc32yD6Kig980Th9t3BVWBjrH6/xclVz3zZhOfFQElyu2awueVlcaL3+8p/PQu9xOE5pJIdxmfkE6Y+H9duN/m/GBjzsJPsCbGjSJ5YXYy1ZpDjJMAL6Znom8Yc1m1c3aAl8sxsKOPihPpAvExeyQQHsoDU9YwW3kTKZTcT0+jU7OUWz YBw1Kulp 4/7RwJxG1e7xqsL4s8GkgJ67sB+1tmz3CbYIkLmd0KV31yAd7G3EVpJy4d1LFlg05Je5tf/BQo/CeeTd8Tp+lugvYK/EvwaoYWhm/y7S3//i7RhwZQqx8B/ZpV7Q0YtNuAMTjPX9tU2xAJ6xPQctfmEwdrF0kGzY2tfESKGhFugJvOpSm7P6bRpQEBUsb7HHDO/Eigyhf8cHPG7Lz6MjlnwyIDiEg7ZCu5Ac9W+1uwHWbDSGBL3ooFzw1kleL5NLEIi/9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000520, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 27, 2024 at 09:58:03AM +0800, Zhang Yi wrote: > From: Zhang Yi > > In order to cache hole extents in the extent status tree and keep the > hole length as long as possible, re-add a hole entry to the cache just > after punching a hole. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Thanks, applied.