From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C558BC4828D for ; Sat, 3 Feb 2024 17:57:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D7F56B0071; Sat, 3 Feb 2024 12:57:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 261316B0072; Sat, 3 Feb 2024 12:57:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1017B6B0074; Sat, 3 Feb 2024 12:57:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EFB686B0071 for ; Sat, 3 Feb 2024 12:57:13 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A04111603E2 for ; Sat, 3 Feb 2024 17:57:13 +0000 (UTC) X-FDA: 81751249146.07.EA43D56 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf10.hostedemail.com (Postfix) with ESMTP id 6D422C000C for ; Sat, 3 Feb 2024 17:57:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b="Vk1L5/Vf"; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf10.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706983032; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ykOOFay+2IfEzshY6L1t7gF/goIrR1N822e2+ESCJlU=; b=75MrnoQp39oTHY16+NjubacdplvrCxsi/PLG6R+Sa6/aKfh7HMZNfarFDxDXLSTWHgRNo4 rV5KvvsyI0IiYiItu7QYelNmgWexsfW8CQj3+6LC9UIqUb3pHsA/KDcJOii9DNMVPQPfwH SNq0N/B4PHkIeG74en6MsCwzleGhYyQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b="Vk1L5/Vf"; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf10.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706983032; a=rsa-sha256; cv=none; b=wJNb1S8e5p2wjmnCzOjb2DS911rPj9MOek4rlwh/3SfXmhxpxH00Z82CDCvSgNcOuJrkQn efNzQk1k728KcrVWsX8cE17dBNvpEjW4sarVTqQTVdoCuGM7N/kMnvyeAT4A+NMMpri6PO nRhW6vOwNA1H34Qvp6ffn/mjICHy+5g= Received: from cwcc.thunk.org (pool-173-48-82-236.bstnma.fios.verizon.net [173.48.82.236]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 413HuClN016639 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 3 Feb 2024 12:56:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1706982976; bh=ykOOFay+2IfEzshY6L1t7gF/goIrR1N822e2+ESCJlU=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=Vk1L5/VfsKskGJpf6kj1FqSI9spLbmpo0OMN1uZCsa+rUQuM5qtPiLL5y1W/fhAYb cL45+7C3/Wgh0+dxd8RotJLxAIJFHDKvba4KAtEX92dq9iauIz06YXfMvET9IyUu9K A3udZQcY3yEOdAHaa0EkgYWPMS9kDP3J6lLRiu7Bs8ooGv3TeuKzmp8yAL6uqpFxwJ 4uMfnpKu1mHh1UIuw85YTTQFGyevCVd94MkBio4d/45deq0m+e8Aet2M0RiSvjzVyu Xy4OkJPUfrKx8QTGJ8Oj7rist3+Uye/a3AuJRQLeoMWFtnoAcQlxCIrJwUO3N66NaC HjWRVEWLx0aTQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id D733315C02FC; Sat, 3 Feb 2024 12:56:11 -0500 (EST) Date: Sat, 3 Feb 2024 12:56:11 -0500 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3 01/26] ext4: refactor ext4_da_map_blocks() Message-ID: <20240203175611.GD36616@mit.edu> References: <20240127015825.1608160-1-yi.zhang@huaweicloud.com> <20240127015825.1608160-2-yi.zhang@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240127015825.1608160-2-yi.zhang@huaweicloud.com> X-Rspamd-Queue-Id: 6D422C000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: isfezowwhi9sskm7d3ygk7m4japrjtb9 X-HE-Tag: 1706983031-895079 X-HE-Meta: U2FsdGVkX1+Je3IFsAMBvEl0Pc6F0cwTj1sHgjdDwxUk9IJ3Bi7NxFhjy/f7EXR+yy+Qw5LjDr8r4+Ajla4ygaeGOxVBinmwxxAntaDKvR3H7laU5GC3SFD1sdi+IFu7elvgg2i2tqaQyZwSfWuZy4IGd4IwBq4XQimXidbjbZNMuvH6z/XIuvoFhBbisnEnwysdaE0HmgHrhr7meqOmgbF16ujT1V2K5+mm6hpzRX3O4iIhdKVVYsg8OFM6uWvc8RHpBASP4OW2o3iyZFBT95Uocf00zj+mHyPcLeRFV1srwSmy/HVauFzxBHAwxf8Sf41gdSJBJDQwpwmhFeaAUv37je0BAI6BVxPHhVWus0GnlW3c8BymQSHgU+z1DUVCwMPamkzgBO5AUpuFxafuyc3zgeZSylat/FUndQuRlGQU3DwZpj+zL+QD/osZQXSdBgFC5io/O2fTvzMctsrNJ0sxzLKnPdwNjr2Wj0ULyG7LsVX+mhrZ+DdmDgNVMwnNNRlwnE9c4j/WGqwFI1AV6ui83Wclnjbok7iQ7TZfs3uFGkesO50r5EgatwT7xmR88KKWUT+leiJAPe2T5q4o6kwmkhX8aMk/j+SDO2M4pbT/OyvpeWdHaWH3h9bVzOZtuTmmWCbw+tLhtTCg+oPhAvadTbOONbc8sTdheGeFgxylmB3ckj7iOSf0lpt4qrdATWn9dCU+Sb2kD4sORgYhz6di9xvlLOqz6vHshPLHxB6HxFLZ4+OsUv7P5eEqYml08psjv+SJokPt6OIzi909u7BTULKzrRNtTcICTFIJxrfTdCSNQTKoH7hUsFheDRTWGJf+gR7TfexqMnKbUaoYM6bz9M+uIFPzvLrazxD5vJ0o5WYXEjjQgHHXbRzzV8zFkC3JcAZn5YI1/dT4MuiXq4z7k1a99tp5D0Pm3m3uaMu1qE4G2IQw4XHnUkZmdXrhOasPAc1rSDFyzdObf8F nVc4utcK 0KpLuFoZBfSx5O6nx8an4tUVxsop6+mkwmKfx+RjRMxRDzz00VJ4IagfNPp31n7x7cj0F/RSOnl9bbHq4d22feHZv6OXj+lCkvtxHpO2nvC4gYASAWjbqxgfZCMxnT1cK0k6CMJsoOOspUg0NKFpECb6TPQ7TZcTAjdozjz34cIwv8m/p0jz+JUbh+FdIAY+hHz2C5+QiO/89gFy/NNInR8QI1fnKUWc49SJ1t3NLKIkEAEt66Ql0Rtv9KhStaucIyO4Q1PFiAkB4TrSKF+dJks0Pf9XiWaJph4Lz5+hYdpDx0Do= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 27, 2024 at 09:58:00AM +0800, Zhang Yi wrote: > From: Zhang Yi > > Refactor and cleanup ext4_da_map_blocks(), reduce some unnecessary > parameters and branches, no logic changes. > > Signed-off-by: Zhang Yi > Reviewed-by: Jan Kara Thanks, applied. I've taken the first six patches in this series since they are clearly bug fixes / prepartory changes for the rest of the series. (There were one minor patch conflicts that I fixed up.) - Ted