From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42AFFC4828F for ; Sat, 3 Feb 2024 09:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C9276B006E; Sat, 3 Feb 2024 04:43:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9792D6B0071; Sat, 3 Feb 2024 04:43:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83FFF6B0072; Sat, 3 Feb 2024 04:43:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 724106B006E for ; Sat, 3 Feb 2024 04:43:35 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 14C3C802AA for ; Sat, 3 Feb 2024 09:43:35 +0000 (UTC) X-FDA: 81750005190.12.C269B3D Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf09.hostedemail.com (Postfix) with ESMTP id E0EEF140019 for ; Sat, 3 Feb 2024 09:43:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=GGikTWdu; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706953413; a=rsa-sha256; cv=none; b=Z/7f0R57Y/unfpMK/uRVXeVBGRrCZOo3VbFIab7vYcPabkJMrjtAZJHUr3Kw9MFZvBPZV8 iQlz7jnDEZwYZQRRMRNM1Mj9iVfViS1+mV7QkiFFtYQ1RFrX0H5keqSBm+YPE/3run+HVN 7jz7iOabGzvVU4SWInvKrPSigjf7M/E= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=GGikTWdu; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf09.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706953413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mgZAg3GpwXZthnw1a16qEM2E56aABkLqL8sx7VGeWyU=; b=AjLLOggq5TeLTCb1gPI6A+hIf34NdZtvVWZJcbU6nfDngChXVEHIkK9eiIjM1cYr87jIuo 6DXHDo2Hxkl5W2KEAdNP5OSTdq1yqbzaLw0eD5TX0eXeUJ5zyTZbzi97SvrfNFID1fymC5 MMKuA1Ox712GpF4Rb7wOvbfWoMbXoWw= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 4497240E016C; Sat, 3 Feb 2024 09:43:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id coJ00F2PtT_b; Sat, 3 Feb 2024 09:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706953407; bh=mgZAg3GpwXZthnw1a16qEM2E56aABkLqL8sx7VGeWyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GGikTWduUt14Id46rEGfYg2pfXHyGPp8xlv4N14UyuPD8YNDf6UOgMAjTsTUyYyjK MOLPiLT318Z9DFMA1aTRb6SJBy+7fDEWR5f6MhMzPmF2GuylCrHQL2GmOtWTK9qIMs d+6YH+AwHAB7ErsrN2j1dcaeyuxnWT/I2LQnTw9lI5JHAdgJFWzHoGkSGTTUNIQLi6 HeUP7mdhZeAIWLEn5K8Nvl4MhFZO2G2gLX4ss8GO25g5jei5zz0MZS8E008Npe8DSq 0ItDlBHY/abMUbde34QFbxPMe8BwEdNql319dPe8RxQy9uXe7X3ZbAMXEdYpoNqc1h MIXjc+eBEaWx//LfzjaDpiGPs4Ic/zyh/B6BuwNwgaqLSntMYP32cLOH06DpQ6SUPc U9Ez/cd/82Lldoqioyh361CAh6kGHUR9YN9clrJptf16ohjSAAT0uJ2cuUFkRTT2Ap qgyWlrUI1N4f4IGuxQ3QGmnLD6VYkgruUA5KdcoU8MJF4jRd0xd0CcGSJ+HrdKyq6V 7V8b3vE7hvI7Zl23Xn9G6zVTNwvrF4V50QcDlTR70dkJL1REommUg3BkxPrEjFdKSA hK+yPzdu+s0WKduoSJu8HR1lQgyruuSdaQ8pRrSepjSzbWJTCPs79t4gzaegWlHQvu SoOlGpgprGToG3Pjzn1YegDg= Received: from zn.tnic (pd953021b.dip0.t-ipconnect.de [217.83.2.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id E13F340E0081; Sat, 3 Feb 2024 09:43:10 +0000 (UTC) Date: Sat, 3 Feb 2024 10:43:09 +0100 From: Borislav Petkov To: Tong Tiangen Cc: "Luck, Tony" , Thomas Gleixner , Ingo Molnar , "wangkefeng.wang@huawei.com" , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-mm@kvack.org" , Guohanjun Subject: Re: [PATCH -next v4 2/3] x86/mce: rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC Message-ID: <20240203094309.GDZb4KrS2GWa5XtGeZ@fat_crate.local> References: <3009aadd-69d6-c797-20b4-95cf926b6dd9@huawei.com> <20240201142016.GFZbuooG9CRoK90U2C@fat_crate.local> <39c1e4d2-b1d0-91ae-595e-1add4698dd7f@huawei.com> <20240202133911.GBZbzwf-M37M-J3EJX@fat_crate.local> <20240202194257.GFZb1FwcPPO8WXF86H@fat_crate.local> <20240202222220.GIZb1rHG3NiZKmdRXu@fat_crate.local> <4d974c1e-b3a8-8b21-88f4-e5f20b2fb654@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4d974c1e-b3a8-8b21-88f4-e5f20b2fb654@huawei.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E0EEF140019 X-Stat-Signature: pbxsjogp7fj94ios8dtfueafx3jqdn88 X-HE-Tag: 1706953412-255047 X-HE-Meta: U2FsdGVkX1/MQQWd0ilaD/Q8IwY+ISOJe1aWgtB+uMSMPa08XmxGleIgV51gpejXXd/Z/qfYkwbFvGljGcS02kfNV7zIHD7x+rXXF3HwFI6mCr4U4gDzdVJd8x406I73Rmv+wPfXXlqx75E7Pb+F0ea+5C42RdClU6pbcMsZk3J5aeUThdLmmuQ1HasKahi+I6Wdk5OHAXpZjoB8qZgP5WV6fMU2Zqdw+PoJKK7Ip1MccfrtmFna7spHaSjXgVli8OYWrIadJacOsWU7lGsy5yWImtkVpcZFVO3JQqWqb0PoHuWIyulMRoo4eCR6Rc9Y5oFgigRfJu9XxzoOJHlQPkShu/JPHDx1zcJPEZ0uKshY+m3N+vjrnvkyYyYTvUBCftMYOP3IyzTBSfQb0gg0dBH7H/bhkVY5v+liAUMphJZVP3MIrW1epVNGBOQKMZ4lXIqY17mZ2ldn4lqEfvTIVrTtSGfYvVSmrb9lEbEebZ8/LTVhmJbZXVZ8/ZwOXIFxcgNttpkOrtA3wtfSqfQ76d6DnKv1fYp7LvUzW9O/OcyG5hSks69ZohSqSaUXwQ67huCrPOozTMNZ75dDafr9Y0whfeSYlNSSjpX3YuHbAgx/vUlH367L2Gxm4JBkICgaedENny9GclM0lnpYrADb/yWgdam7fLbIueNim6Bc3SlFHFeNrera1qG09xHftCVLxQuErmJiRlkXxnGVBrG5cU3JMOlJql7HjGFBFUR05BNfasZDjD1FZYKTUnIsQFUXXCew20VSf0tCw8iSGS/+y9fp6aoHP4bBBalA2TXJDNNbChbaehYY2XwIRxUvjWYgiOkHrTp/uNm8HahxhVbG9wrz4zTtwwpwb25ZHcJP9u/KgK1mEVjL83n2oCwq6wHceMIgRgbIr3falEQkic+KvHAjkGX2jQh8qhrOPx3SEs2xrMvzyp4v9bkvVBqrIujqQGhartBMaa4HvInGzr7 2WOJ8RVB /9qbG25IpomUV9YZ363szHjD1tDV0dAbpx73Np4FqArCmLF+OYuXSyMrnJWvB+ndWFazDGLV/mGG7Z/Ho+mPWtI9HF/Lt5tItI1AizNwgXaibeIXt7vrvYp59Qa/W8Ana8Cif06+/OrwULYTlb1X1D+5XGRsZlt7/iOxhMe0y4VXR3iojQ08/S+AZhpdflDcj9hdo2pwEOyAuFS9Go1CEgsOOhT5RKKm31UOWFyZaHUZUO/Le7EMBzOZzlkXC45nfqee5jaV1aaLboPOnfasL+JL+dPtpk44plpFb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 03, 2024 at 03:56:04PM +0800, Tong Tiangen wrote: > The goal of this patch: > When #MC is triggered by copy_mc_user_highpage(), #MC is directly > processed in the synchronously triggered do_machine_check() -> > kill_me_never() -> memory_failure(). > > And the current handling is to call memory_failure_queue() -> > schedule_work_on() in the execution context, I think that's what > "scheduling someone else to handle it at some future point is risky." Ok, now take everything that was discussed on the thread and use it to rewrite all your commit messages to explain *why* you're doing this, not *what* you're doing - that is visible from the diff. A possible way to structure them is: 1. Prepare the context for the explanation briefly. 2. Explain the problem at hand. 3. "It happens because of <...>" 4. "Fix it by doing X" 5. "(Potentially do Y)." And some of those above are optional depending on the issue being explained. For more detailed info, see Documentation/process/submitting-patches.rst, Section "2) Describe your changes". Also, to the tone, from Documentation/process/submitting-patches.rst: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour." Also, do not talk about what your patch does - that should (hopefully) be visible from the diff itself. Rather, talk about *why* you're doing what you're doing. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette