From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC76C4828E for ; Fri, 2 Feb 2024 22:41:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A7746B00A9; Fri, 2 Feb 2024 17:41:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 630B36B00AD; Fri, 2 Feb 2024 17:41:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A9DE6B00B0; Fri, 2 Feb 2024 17:41:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 336596B00A9 for ; Fri, 2 Feb 2024 17:41:26 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F0C40140152 for ; Fri, 2 Feb 2024 22:41:25 +0000 (UTC) X-FDA: 81748336530.20.9042732 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf01.hostedemail.com (Postfix) with ESMTP id 164C84000B for ; Fri, 2 Feb 2024 22:41:23 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QuxbYus+; spf=pass (imf01.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706913684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TN/MFntii2sGtHOWJtEU34VYQvygXApI1VfgAn1sM3I=; b=lDSM7vvEvulhcKztfsdm+QWTYq4HmAiCYRA9TtwXdmvchPRcClTjrCqGlehTmMR1PMy7Wo XGjNol/YwbMTYngwe28pSmXxNIWCXiwWNKWusdKqCPVWboHzPVz8nliCwtueq1U2mXO6H3 cczX3AyBY/CIG90NNNY8R6fbz2FjwHU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706913684; a=rsa-sha256; cv=none; b=aWUx9fQdhc0J+h7/0lYOTtQwIj9qJQ+fEXHEDZOGQYd5QX/1gUcryIUdtL3Z4A2HFbhLCm 4noFJT68oYAvPYO03lEb+6EBoGHgqqIzs2jFkXMTpnWkqupoaBjRhKNv0wVKJA2ng53nE9 56bVbh904IKQJfI7mvPTqnH/akt9HcM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=QuxbYus+; spf=pass (imf01.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.44 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-68c794970d5so17391616d6.0 for ; Fri, 02 Feb 2024 14:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1706913683; x=1707518483; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=TN/MFntii2sGtHOWJtEU34VYQvygXApI1VfgAn1sM3I=; b=QuxbYus+8UMLf/8pJtu8gwR9yMQWqTwSEZB2gk8BDUr2zeXAzhpAxCG03MfBRGmwYW FDg0tMI9IH6RnfbUA5lEAZRsBESAG8HFx2kEOHo25Co1Ds80DyhO/v2ToiiuCLOQ8bMt zDC+10zP3ZPu6Okjl+SNiT/Z/hB9LS4nNLlGC+7hvv7uH0o2D/U9D8GkMOrd+vDkEAZ3 Du/7JLaN7e9q83hynL27UVSxp0JoTNaEgbk+MN0cHeApEN5DUtp5KLA2Bw1BfsLB+5/l 1JGtruz4AvnT1B33DeWnGvEcBaPqe0vVCuJNuPHt3wp9pNtNeG+Pxz+Wi1VdmbAV32pq fYgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706913683; x=1707518483; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TN/MFntii2sGtHOWJtEU34VYQvygXApI1VfgAn1sM3I=; b=xAwiSG7SHgFIfjPCmHS0xbJqDlf3oJSZi4s4nMQfuCd/+uu7kyvsgnGIURpN2hYI3u +lXFYQycBkfo92oWQkffcj8xgnZMBPN+TBvx2UTRqBzvrukULBcywEgHFPBlP4LLqzGB nW/SgpSjwCDlakHFR1LUyomPKY0dS8wDlH46hDr9ubDk7RHlwNXM5Bl0gC37t+exXvY5 4bGcJKqLlhnD1xzmaN1+GOCwJ/XW5e92mZGsyFJxB/0KWWGrZ3umFYZgJ7lM3xpoWst8 vYaWs9mUZrNLq7B29ueRiDE0o8sq0BOHD1CR9OS50iEBrRKu+6aS+F5BudQNDuSaWMGt 9fSQ== X-Gm-Message-State: AOJu0YwT2RkvG7aZ0worH1ts23uez8zuHx5ZuGBFjmxSdZ1h3PznT8DJ ANAE/AyBifTrEuuXJc+0uNjwyWMmxJpk6cRtYi8Xqy+fwzIJN6txDkGpu2kooxc= X-Google-Smtp-Source: AGHT+IFLtRQYT2Z/5m6+iLpanPS2x7zIBRaj9Bd9wy7efYS0sCiA8TlEtuF7MnxBC+vxylljcXB5wA== X-Received: by 2002:a05:6214:7f0:b0:68c:8266:32e6 with SMTP id bp16-20020a05621407f000b0068c826632e6mr36083qvb.22.1706913682992; Fri, 02 Feb 2024 14:41:22 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCX4bWvYAwUQZC6rHbZggqmXwNlF8A8uqOOd7ksYY2NMdBx0z09rVQSuT2l9M1pmbaeyFfYGVf3rG81eK51QwwlptZAV59nVNqYjWn5Vab9Eu7phEt3j5kkc5EhwoJ0zJ3YUUxb0iK4141MzksdO3SdDx31lCIy/Z7weoTBOhLzujWgKuvLBmzG1VOUYm0avgbZblW9FgN5Qg0qgtZVCgpSOEuKzWEKxPnTrSR0+iRjZnMIGzVt4co+4pH9IRVc6P6GHtwTb7CB+hLi5ZRCx3vfikIgF1FryOMXH7bRjBl8rlaP5pLNi24AkCOKoJNuMcOSJWU+Z+ceA1RSJAsUio19r/UwAkf1xlE09OGkAsHHPjLRVJbBFCDHK89PVIgf/K1FjHz0zfthh3M9jtoYqIz9mj5r8yCFBbJlq8g+i3HuJdslKhg== Received: from localhost ([2600:380:8c43:7b07:78d7:9d13:1945:dc14]) by smtp.gmail.com with ESMTPSA id qm18-20020a056214569200b0068c67e305edsm1207270qvb.49.2024.02.02.14.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 14:41:22 -0800 (PST) Date: Fri, 2 Feb 2024 17:41:17 -0500 From: Johannes Weiner To: Yosry Ahmed Cc: "T.J. Mercier" , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Efly Young , android-mm@google.com, yuzhao@google.com, mkoutny@suse.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: memcg: Use larger batches for proactive reclaim Message-ID: <20240202224117.GA341862@cmpxchg.org> References: <20240202221026.1055122-1-tjmercier@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 164C84000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: kp1se6yacjw9kup36iyftt37fw5qkn77 X-HE-Tag: 1706913683-257900 X-HE-Meta: U2FsdGVkX19hRnITKtnkq4yligtwunb4YZ3biLwdhOwkcnV4b0SeAQvUTH4LRNyXnCqcoUkk7DtjebMWgn/TCUwVeDKWNB515gMIHk/PlwznrZ2bJh5yrFJ4sIdNMKChH0BiyS7RoJsVD/H5pW0PMb2OjHt22DD5ljiwd7l/s+Xu1FmpdhgWFzRT1aJJ2e82kT79D4e1MuDtNmjsZqh5WjdblTv0ptCyR2HNiGRFwh30vTVGenY/cAG4hO8VOLGOq9d8WA8ipQSn9zU2IsEb7fX0ppTvgvnrnAQSSvyWdMBTs92tE93BHASorvCMFtG4d/XZ0yNiZsA8iF9SgPv8PJCvVBWBo4pB70BbnwvpiFWRZq1KK6S/hO5Fyf0sNfgbyaIeSxJG+Zx0Cm/yDou1a5Jh2ObTRHhR8DydVxK7A+ZTMlH5mCHqxDuWlsonj9k4c3xJquw8n2Q/i6dIqZNJrUFtr4G9yiy8Ra9fL4Z5ABwxQ80FjORZsiMZAhb+CbkiVYByg37H+uh76H7YbBbMDmGEnrbucU+m4Ax7crF6YySqfkzgooo8yYDFydPZNHLKDwiZnKJOxwCTfX+mhVYN254KbJwatByjkoxiX/Su6zIuj41ER/3328GtX6pfzZ9wkvDdhaa/AR5QrkeE7kL0R/koiM9+tH02kHoafpMA7cNFMt7KR5bdKK1JfCyKPlrdCDTs6u2AhOaDtlTOjAFX4QggkABV+M4EqjSVI9T7LA/uOVk/voaqaF5Y928s6n+O4Wmjn6d6zz2WZU9VDEam7VsFz/C5aI5J6h9GvIwJiSF8XS34gKdqZvazWDfqjaLEgpWbd22TR3KIDQjbn8gw0lwkmuuwHhMVN+CMoIveG/IhsCIwZErbdMx+zwo4z+YFkSCTg/4+ZOZkA81tEzn5kYWxcj7v6aGFtLISyLb/Pd77okzm0su5eG0dvNNc3beY1ommiFUOwvJoNzuXoSA +EBgvbfg RbNzS3Fru2ffxhYa65c4eSms3CQMFS6UauyncsoGlUBKt+1L0qHPZTKX43GBsjWu9qSJD9RdVepiP6qOnOWBKYF5eexqlnglHUoIBtZ15QTsydcLtcrCkVOiFIoAjh7Gw3r/QotwX5fFxtvk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000397, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 02:13:20PM -0800, Yosry Ahmed wrote: > On Fri, Feb 2, 2024 at 2:10 PM T.J. Mercier wrote: > > @@ -6965,6 +6965,9 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, > > while (nr_reclaimed < nr_to_reclaim) { > > unsigned long reclaimed; > > > > + /* Will converge on zero, but reclaim enforces a minimum */ > > + unsigned long batch_size = (nr_to_reclaim - nr_reclaimed) / 4; > > + > > if (signal_pending(current)) > > return -EINTR; > > > > @@ -6977,7 +6980,7 @@ static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, > > lru_add_drain_all(); > > > > reclaimed = try_to_free_mem_cgroup_pages(memcg, > > - min(nr_to_reclaim - nr_reclaimed, SWAP_CLUSTER_MAX), > > + batch_size, > > GFP_KERNEL, reclaim_options); > > I think the above two lines should now fit into one. Yeah might as well compact that again. The newline in the declarations is a bit unusual for this codebase as well, and puts the comment sort of away from the "reclaim" it refers to. This? /* Will converge on zero, but reclaim enforces a minimum */ batch_size = (nr_to_reclaim - nr_reclaimed) / 4; reclaimed = try_to_free_mem_cgroup_pages(memcg, batch_size, GFP_KERNEL, reclaim_options); But agreed, it's all just nitpickety nickpicking. :) Acked-by: Johannes Weiner