* [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once
@ 2024-02-02 19:06 Uladzislau Rezki (Sony)
2024-02-04 19:44 ` Lorenzo Stoakes
2024-02-05 6:41 ` Christoph Hellwig
0 siblings, 2 replies; 5+ messages in thread
From: Uladzislau Rezki (Sony) @ 2024-02-02 19:06 UTC (permalink / raw)
To: linux-mm, Andrew Morton
Cc: LKML, Baoquan He, Lorenzo Stoakes, Christoph Hellwig,
Matthew Wilcox, Dave Chinner, Uladzislau Rezki,
Oleksiy Avramchenko
Invoke a kmemleak_scan_area() function only for newly allocated
objects to add a scan area within that object. There is no reason
to add a same scan area(pointer to beginning or inside the object)
several times. If a VA is obtained from the cache its scan area
has already been associated.
Fixes: 7db166b4aa0d ("mm: vmalloc: offload free_vmap_area_lock lock")
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
mm/vmalloc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 449f45b0e474..25a8df497255 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1882,13 +1882,13 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
va = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node);
if (unlikely(!va))
return ERR_PTR(-ENOMEM);
- }
- /*
- * Only scan the relevant parts containing pointers to other objects
- * to avoid false negatives.
- */
- kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask);
+ /*
+ * Only scan the relevant parts containing pointers to other objects
+ * to avoid false negatives.
+ */
+ kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask);
+ }
retry:
if (addr == vend) {
--
2.39.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once
2024-02-02 19:06 [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once Uladzislau Rezki (Sony)
@ 2024-02-04 19:44 ` Lorenzo Stoakes
2024-02-05 17:20 ` Uladzislau Rezki
2024-02-05 6:41 ` Christoph Hellwig
1 sibling, 1 reply; 5+ messages in thread
From: Lorenzo Stoakes @ 2024-02-04 19:44 UTC (permalink / raw)
To: Uladzislau Rezki (Sony)
Cc: linux-mm, Andrew Morton, LKML, Baoquan He, Christoph Hellwig,
Matthew Wilcox, Dave Chinner, Oleksiy Avramchenko
On Fri, Feb 02, 2024 at 08:06:28PM +0100, Uladzislau Rezki (Sony) wrote:
> Invoke a kmemleak_scan_area() function only for newly allocated
> objects to add a scan area within that object. There is no reason
> to add a same scan area(pointer to beginning or inside the object)
> several times. If a VA is obtained from the cache its scan area
> has already been associated.
>
> Fixes: 7db166b4aa0d ("mm: vmalloc: offload free_vmap_area_lock lock")
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> mm/vmalloc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 449f45b0e474..25a8df497255 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -1882,13 +1882,13 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> va = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node);
> if (unlikely(!va))
> return ERR_PTR(-ENOMEM);
> - }
>
> - /*
> - * Only scan the relevant parts containing pointers to other objects
> - * to avoid false negatives.
> - */
> - kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask);
> + /*
> + * Only scan the relevant parts containing pointers to other objects
> + * to avoid false negatives.
> + */
> + kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask);
> + }
>
> retry:
> if (addr == vend) {
> --
> 2.39.2
>
Looks good to me, feel free to add:
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once
2024-02-02 19:06 [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once Uladzislau Rezki (Sony)
2024-02-04 19:44 ` Lorenzo Stoakes
@ 2024-02-05 6:41 ` Christoph Hellwig
2024-02-05 17:20 ` Uladzislau Rezki
1 sibling, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2024-02-05 6:41 UTC (permalink / raw)
To: Uladzislau Rezki (Sony)
Cc: linux-mm, Andrew Morton, LKML, Baoquan He, Lorenzo Stoakes,
Christoph Hellwig, Matthew Wilcox, Dave Chinner,
Oleksiy Avramchenko
> + * Only scan the relevant parts containing pointers to other objects
Please avoid the overly long line.
The rest looks fine.
> + * to avoid false negatives.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once
2024-02-05 6:41 ` Christoph Hellwig
@ 2024-02-05 17:20 ` Uladzislau Rezki
0 siblings, 0 replies; 5+ messages in thread
From: Uladzislau Rezki @ 2024-02-05 17:20 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Uladzislau Rezki (Sony),
linux-mm, Andrew Morton, LKML, Baoquan He, Lorenzo Stoakes,
Matthew Wilcox, Dave Chinner, Oleksiy Avramchenko
On Sun, Feb 04, 2024 at 10:41:13PM -0800, Christoph Hellwig wrote:
> > + * Only scan the relevant parts containing pointers to other objects
>
> Please avoid the overly long line.
>
> The rest looks fine.
>
> > + * to avoid false negatives.
>
Thanks!
--
Uladzislau Rezki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once
2024-02-04 19:44 ` Lorenzo Stoakes
@ 2024-02-05 17:20 ` Uladzislau Rezki
0 siblings, 0 replies; 5+ messages in thread
From: Uladzislau Rezki @ 2024-02-05 17:20 UTC (permalink / raw)
To: Lorenzo Stoakes
Cc: Uladzislau Rezki (Sony),
linux-mm, Andrew Morton, LKML, Baoquan He, Christoph Hellwig,
Matthew Wilcox, Dave Chinner, Oleksiy Avramchenko
On Sun, Feb 04, 2024 at 07:44:55PM +0000, Lorenzo Stoakes wrote:
> On Fri, Feb 02, 2024 at 08:06:28PM +0100, Uladzislau Rezki (Sony) wrote:
> > Invoke a kmemleak_scan_area() function only for newly allocated
> > objects to add a scan area within that object. There is no reason
> > to add a same scan area(pointer to beginning or inside the object)
> > several times. If a VA is obtained from the cache its scan area
> > has already been associated.
> >
> > Fixes: 7db166b4aa0d ("mm: vmalloc: offload free_vmap_area_lock lock")
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> > ---
> > mm/vmalloc.c | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> > index 449f45b0e474..25a8df497255 100644
> > --- a/mm/vmalloc.c
> > +++ b/mm/vmalloc.c
> > @@ -1882,13 +1882,13 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
> > va = kmem_cache_alloc_node(vmap_area_cachep, gfp_mask, node);
> > if (unlikely(!va))
> > return ERR_PTR(-ENOMEM);
> > - }
> >
> > - /*
> > - * Only scan the relevant parts containing pointers to other objects
> > - * to avoid false negatives.
> > - */
> > - kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask);
> > + /*
> > + * Only scan the relevant parts containing pointers to other objects
> > + * to avoid false negatives.
> > + */
> > + kmemleak_scan_area(&va->rb_node, SIZE_MAX, gfp_mask);
> > + }
> >
> > retry:
> > if (addr == vend) {
> > --
> > 2.39.2
> >
>
> Looks good to me, feel free to add:
>
> Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
>
Appreciate for review!
--
Uladzislau Rezki
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-05 17:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-02 19:06 [PATCH 1/1] mm: vmalloc: Add a scan area of VA only once Uladzislau Rezki (Sony)
2024-02-04 19:44 ` Lorenzo Stoakes
2024-02-05 17:20 ` Uladzislau Rezki
2024-02-05 6:41 ` Christoph Hellwig
2024-02-05 17:20 ` Uladzislau Rezki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox