From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ED3BC48291 for ; Fri, 2 Feb 2024 16:26:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33D586B0088; Fri, 2 Feb 2024 11:26:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ED166B0089; Fri, 2 Feb 2024 11:26:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B3F16B008A; Fri, 2 Feb 2024 11:26:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0AFCE6B0088 for ; Fri, 2 Feb 2024 11:26:40 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DCCF21604D0 for ; Fri, 2 Feb 2024 16:26:39 +0000 (UTC) X-FDA: 81747392118.12.C9A8439 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf29.hostedemail.com (Postfix) with ESMTP id A79AA120032 for ; Fri, 2 Feb 2024 16:26:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=KUnakPMb; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706891198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qUtud9MaY+8DbGFxC/AgiltFpITZmSHoCy6Sbv7PuJc=; b=U9RSPC0axSqKI6yISwVGrnmcjPnp/jERHx77hzlmPxecIKbJnc2fQeDx0CnUdx65CSp0MF eML2OOaWEtmr37QUsqe6Kx4VYlGEMQmDMhXWnKfwWqJMLy1WMh5OX4f6PyvJTtbNpv6+DR ckpIuwrV7eE7xIyXxWBYNx9BlGqLnCU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=KUnakPMb; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.54 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706891198; a=rsa-sha256; cv=none; b=nAP+67hUBPcKwuXmTMInSb11BTze7eIRKeB/jzAA8GCBSmgEHj25VKNPbbRZFXAUC/Uqnf nM/rfod0WEJVOGG1E1LK18zJvqghP3zbp6XTDAmr3TiFzdQJ4YNhmBbkRoKQRBewfWExMp 5gBrpZZWnC7z2Bhk0b8axBx96e0nK2o= Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6818aa08a33so7250216d6.0 for ; Fri, 02 Feb 2024 08:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1706891196; x=1707495996; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qUtud9MaY+8DbGFxC/AgiltFpITZmSHoCy6Sbv7PuJc=; b=KUnakPMbQbY4QzoENZ6p/0sUiHSwwwkOja7VljVnegkHpsGe3bP38BlOlvIWgBPLH5 GW/gE7rhGLd3vpojv0AnBE9ZDPc11Uny6WzTCE2V2n4Iier4qgXdDSiG3fYrUDWMHSA5 8jTQmS3hzf88awIweCIP6dmrELDBeD7f1a1e0poIzibvNXinmJQFQ40hJMHmjLFOXfhb KO9jIO3oMwRQ/6VQEd/qQdGPYXLG324IcT1+9Ao5WBQbg8leVfv0odmjnupSy4bG4fpG Onut+3SiVjxJKi5xcBHwXDw8/886GPr8GMxHWEpAxjpi4C8q+r3GD/rmiJ6jM47K6xCx aT2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706891196; x=1707495996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qUtud9MaY+8DbGFxC/AgiltFpITZmSHoCy6Sbv7PuJc=; b=FS7btGOfACUIS7VbAWwNzdKF8Bj36UO5h8tZk3hF65POrJRNABHrqtKs6TXys2iM2D qmxK2eB8tLOMkgv6J8Tx7WE0784W7r0FeKRZWWWT4Z3tVCyDt2eMNOeYsoHcUXBO9QPw 4OmjzxK++enPSPhsQ99rwR90xYooOkbZow6o2Ob3fZgjcwqJALdqwmJSb2XwCDPA9bwk YWDK5RAJ8sjhIAnUKCNwn5hrAtLqTmmIqLfozuPAfQ3djsFsrjcmloT418/JicrZ1soE yCgDXzQRVIFAuiqnXvw/wSpyZsCILPG/kunWusOVtlVwtLD2B9z9curVWoMx4psbXceT NlGQ== X-Gm-Message-State: AOJu0Yy9ywXNj0iYURXpP7u0Nu+N2I+9llcwb3u/TLmG8XjFe16BGwJy 6LyPVC334vFmyBGd/1guTsfE9Apv7iqFTJF1dqEn8xb3BVqkzcW7qGDlm4uhqZE= X-Google-Smtp-Source: AGHT+IGLUxKyRPMROGThz1MChgUr1mLMIxBmZCUdizoeeceVrz2k1V+5m9Klz9Xi0rVC6HzCJg9MIQ== X-Received: by 2002:a05:6214:1249:b0:68c:83fb:b612 with SMTP id r9-20020a056214124900b0068c83fbb612mr3698583qvv.31.1706891196695; Fri, 02 Feb 2024 08:26:36 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXLy6eSRRk6gE+pUfspZpC36LSIoz8TKb6OrfiQcB/j535+xtv3G0UK4Jd4hk03HP45prGKixWhBela9dScvtWqZo0JcY7OSJh2l1+ZhzOyGtKU5lEwZKDvwlj+O7EHgg39b82jQloS9S8sBOdhJ40NwoSPwvi58y6q7dOfrynzzEbRifII/TxboaVy60mcfQc4Dg== Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id w11-20020a0cc24b000000b0068c5b3a7f2fsm938734qvh.37.2024.02.02.08.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 08:26:36 -0800 (PST) Date: Fri, 2 Feb 2024 11:26:35 -0500 From: Johannes Weiner To: Chengming Zhou Cc: Nhat Pham , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 5/6] mm/zswap: only support zswap_exclusive_loads_enabled Message-ID: <20240202162635.GF1227330@cmpxchg.org> References: <20240201-b4-zswap-invalidate-entry-v1-0-56ed496b6e55@bytedance.com> <20240201-b4-zswap-invalidate-entry-v1-5-56ed496b6e55@bytedance.com> <20240201181240.GE321148@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: 7o8ktf3yfb18ry3pmtx7asoscta1na6o X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A79AA120032 X-HE-Tag: 1706891197-460906 X-HE-Meta: U2FsdGVkX19rByIlW2Ka+7ziN+CZnv+wbvGOnTUYI+cA/+ZE7S0LNFEnYTMVnrTGPpc8qSg/QE2MwOCI3yA3/HbL+oO+S4OQvWI4NcnoHDt+z5E7RoxD4akAMwaAYoqvKYe+r6QAPrDN5AWVAU1QuRv+YC4Dx9XMXCR8rTPknzvRj9nC4yyq7eNoPNhB+i1wljFEA5ANA+7vWq3Pr7ZwXm94LOKSudjCdBw9px3hEj4Rw5ZR2G8NcfIb3MV8pqCLnVv+ILWM303cKa8Fr+tVDzP62sY4uBYfY4fF9aa2xvOoCaidsvtYrYzGwY855jiCsoEv01cnfDNt76TkKgiE6hq1wJMqK+IfT+a+C2/wHHbsc38uktp44bks15v9mN0UyKanivgU8tu8aUbasjCCx8r+VMtLz9Dn8Ry8Wa8VUZ1MvoPUQms+FuUyTMV5iZVRwnTI44a3o+V218il5921Jj9EQ7LR4qO5J6dqMkbud4VtBs/8RfnTR5Qb3iodGSZjJN0gvnPJnxl9nbsDEHdGNXaPjhCnypWkGIthVuK2+uMvV6xaIkhWJZ+i8fy7FpPtLeACvSCAwQZNo5rKnvScZASSoxCTqzfTaHjs7/BQlAyj9Oh9HyaiiIh6naaWZ2Oip8go8NOgKUkqnLq1yc5Z2cP83YbTNsNFr0cIEdU0RUvBP/nuSZcSeod/Fk+ai4SXHjG3oj2aU7iakxB+IVejzKuaRUT/WqTEB0q0eD0SZhuPSz4A5M+zTwkHWiuNQF+qdqYxLDD6ZMrjSDWCt3pb7V41oN8MwLQ8BZtZPPy/Q3DDRpBl0lrZtxtFhEMn3m6dEMnEnDZva6rtUL6sdjTfIHbskBu0uQW+T40YoZTiMijm5z5vX71ELLaTpPO7O441D3NfEdXZ/ac4ig4gwKD7A+KgzPcikpDh/1NBwJIqVreDPvS4dKv07tZP1ai0dDeqZVtP1jYIQzbS7dF2DQq wY3jbyYq O3NCfxpHJFlhqY7cvwVdKwSWpM+0UEsY8pFDc7a80VuMgSoLT0lhYDU28PlnwPquZIAfnYKTC5c5lYUvGL9pC2CDCJifETVHiDyhmXXx3xOl6wRxxiq7YgqgYPmMXM4rqNRa1/7ssEhHDQKSy/s9G6f1J8Ni1OncTIf0quUVVZWe90E+JO9bQkE+PMCqeKIXSFsSTvMYYnYRZ1nDU/Cuhbogz5RQVBfs8oSWu2MBUIuhK28bcx6PO4rrQBm1uMW24aO36XCYZ1NYNzL5mqStL4TRkuDvc6xjSKMV21eTweXSipbXA6yyGDJ3L2TP2r4Qpntaqh2ykWftBpYvHt9owjB6/MOkEcOjpLiFEi2iBxgIwxxolElOFwAh+T5Q6U8qXaSJ99kCrPZvmcGebi92x2wbj/pIODhVwjsIstQ1YhpR4I1yNTjPJUUK4zQDivxT3wsU4J3Xcc5nUSqz+2Ex024TSfXYcLr8Jmb3D7V8brbSM+oIt7qLi5UsLhA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 08:57:38PM +0800, Chengming Zhou wrote: > On 2024/2/2 02:12, Johannes Weiner wrote: > > Caching "swapout work" is helpful when the system is thrashing. Then > > recently swapped in pages might get swapped out again very soon. It > > certainly makes sense with conventional swap, because keeping a clean > > copy on the disk saves IO work and doesn't cost any additional memory. > > > > But with zswap, it's different. It saves some compression work on a > > thrashing page. But the act of keeping compressed memory contributes > > to a higher rate of thrashing. And that can cause IO in other places > > like zswap writeback and file memory. > > [...] A/B test kernel building in tmpfs directory, memory.max=2GB. > (zswap writeback enabled and shrinker_enabled, one 50GB swapfile) > > From the below results, exclusive mode has fewer scan and refault. > > zswap-invalidate-entry zswap-invalidate-entry-exclusive > real 63.80 63.01 > user 1063.83 1061.32 > sys 290.31 266.15 > zswap-invalidate-entry zswap-invalidate-entry-exclusive > workingset_refault_anon 2383084.40 1976397.40 > workingset_refault_file 44134.00 45689.40 > workingset_activate_anon 837878.00 728441.20 > workingset_activate_file 4710.00 4085.20 > workingset_restore_anon 732622.60 639428.40 > workingset_restore_file 1007.00 926.80 > workingset_nodereclaim 0.00 0.00 > pgscan 14343003.40 12409570.20 > pgscan_kswapd 0.00 0.00 > pgscan_direct 14343003.40 12409570.20 > pgscan_khugepaged 0.00 0.00 That's perfect. Thanks! Would you mind adding all of the above into the changelog? With that, Acked-by: Johannes Weiner