From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3935C4828F for ; Fri, 2 Feb 2024 16:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 696D06B0085; Fri, 2 Feb 2024 11:24:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 647556B0087; Fri, 2 Feb 2024 11:24:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50E6B6B0088; Fri, 2 Feb 2024 11:24:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 429C76B0087 for ; Fri, 2 Feb 2024 11:24:07 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F1C7680F38 for ; Fri, 2 Feb 2024 16:24:06 +0000 (UTC) X-FDA: 81747385692.02.06BEB03 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 0039F16001E for ; Fri, 2 Feb 2024 16:24:04 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Xgnvqcrz; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf08.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706891045; a=rsa-sha256; cv=none; b=kkHhcW1eitLtkEDbMtrN7DFQ4Wa+8y7EiivjIn8MZWSl5ojK7FIERM2uqfPOz5kIMywxAQ UPnm9Npln6gYUxwfWs31qfy+6YbIgZIIv+tfFmKu70jfH2ur8Hh7wdjbxmAtG5yKp/TuN2 JBGJL1khVL0WPm4S0pQEIAKnposZWYw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Xgnvqcrz; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf08.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706891045; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RoPQuVP555ZjHcYb0bsEO28B5B8Z6KNQKo27mt2Vw4Q=; b=DRts9Mv6360hhIPAn3qQllkaEabdvmcKqIdJjxsQcPpQEd65XlzQZN+MmX/h4IIOxMWFQ8 /ZzKkvKhBBm0sqyolsa0pRf5To8/WUGERnQ1GOtZAqpjM3YR1jkAX08dLikyoIMRhvZMUS hKp69RvLJvdKHQiTh8FQmwfkNBpt6Ko= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RoPQuVP555ZjHcYb0bsEO28B5B8Z6KNQKo27mt2Vw4Q=; b=XgnvqcrzwaLIRdH7DwoalzOs/H suF8gwgOZE1lMLZm5JD4lq7mSePMjmu6FgZd7jXL00SjlCKzhHTdFa2b1aDT52iq415qaLpWFwrcw comjaFxYsuAGuLvKjrW0FcCYJksxGFoJ6mvoMnR2qSDGVoC4eR0RDoA2NQej5JcekPJX42zhDBixm JLnITKXgyZb4oG408DSvyLmUuzhCGYPmKDB8/SMHL5IKI7wi7ZZ2/5ZtMMpr+eXbQqvfn7xAe9271 c8vZV9gsjejL5x35bR9Ah1Hh6CsXBMAiWUsTg9Hp8c+BE4Prlb0izdVuLa4YErQHlI0oZa2vSg4h3 PKEIt6RQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rVwKQ-0046jg-22; Fri, 02 Feb 2024 16:23:46 +0000 Date: Fri, 2 Feb 2024 16:23:46 +0000 From: Al Viro To: David Howells Cc: Miklos Szeredi , lsf-pc@lists.linux-foundation.org, Matthew Wilcox , Kent Overstreet , dwmw2@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [LSF/MM/BPF TOPIC] Replacing TASK_(UN)INTERRUPTIBLE with regions of uninterruptibility Message-ID: <20240202162346.GB2087318@ZenIV> References: <2701318.1706863882@warthog.procyon.org.uk> <2704767.1706869832@warthog.procyon.org.uk> <2751706.1706872935@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2751706.1706872935@warthog.procyon.org.uk> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0039F16001E X-Stat-Signature: nwbkzm3994xayxyefdt3e43fxfzf8ie3 X-HE-Tag: 1706891044-558179 X-HE-Meta: U2FsdGVkX1+tSERatkQF5waFZiKusluxvcfdA88aVRjMa1pcv4vCiTRPP3EaEe/KdMsEzPe0J4pHzppR0in/HzEI0Y0G2Ks9mjKFr4RCIrIYReisfggYJ9NoOD6AXMq5r37LzpVvl55SXdOvhzxJwXUifGSJF5sLxVD0Cr5CVimWHTHhTR2KQnhkNQA43nOitu1kfIv1z4PjSAKkvs7iZ/AiXaMfdlV4LOg0HZ6iEO+NCzjtRg0cKYM1YZvi7LPAQXacoy9ZkM8MisGWq5s5bbHzrOG3R4yyCdytqtoEOXBsrRY08NtYbHVcLaTCEH+W1yOtoTKdr2eMpkHpDEnAcACbT0tE2bgpaUEEW4fsyR59nvkoH2QnaqZhs0paNTXeZk3jfLCFfKQVl/B05Nsv+L1wvGg04BjbB0SSBAUmPhqy9sMfoejpESIJiFUj2fCR2wr6W2xzA48Ay+o/B0wraTBRyTd5GEDItnqeXYSX9Ethy3YsgbKOojwTOcR7pqKqKn/JhuAepyPY68gxWGTVVBf5zgyLFMPXIGc7PZLNtG0jCu2KY6T7A2zIwJ9zxrzg1y4qSFziVj7IF8pwee+XRdGWSMCF3msaUHbNjArtp8pUKWoO+U5RLVYl2pJDpttBbKcaIfv9FSdhI7qoxNh5WAVn+lEGmIyS1EHhmZwzR+4A0h0N2W+epZ8NZye7QpRK3PY7xUfod6jzu5DIFVVIf+FErv4jIzMFsnIbAfXKX2Qv7dyHSytAXukdunufwdrrYzYDo4afODPcdUZvDbBpIgvk/WON6cRJG+fQOyCNjFwA/qzbxgBvqsyUxicTvQGeroG4vIxrp/smGjXTpYSA1diaC5MQ7hZBIhY59OOC/AVf2jiPzu44dtIuhy0yVvs5c/u3opizQaCoOW64Xdkntv5rwBKRAj+iXVWcTS2Wq/mbv66w3G2n8tCEH8R284EcLswSbfnL8tfSPpyVrEr +BMo/ufu 4PqV5zTrYvUBtT8nCuXhcVYZoSYJhCGaoZbtNctfW+TDjyWyq54R90vV9KEre1uOPfKFUaGBJjJHTBp4pg4aLS7/8KZVNcpFpSsBLaaOMpjCMnZVOmGslLomo1llhFvZ3EfrZm0O25S4NNdE7o2toqrRmKN4muvmlrkdWwqv9uwVP7czyjsLS3TuhfBsZ9cTcHFDKhOa7Os1bkPW4OOhFFenHYyIqx3EUNhfu9mOpRPwVyyb88dOfEiGosPWY5voyFEPv3x0HqxKmPUCB8TtYaqt0fCHVBup6K03uedPsssI9pRCFxaE3sbPglvX9fRJBRAGIRY0U0K+owybfhmK22vakZj4mhk0vq0HUZNDXzwID78EgZ8ZM9Nhk5Yz/Zr9N+Ub8nyicfkv30jY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.070653, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 11:22:15AM +0000, David Howells wrote: > Miklos Szeredi wrote: > > > Just making inode_lock() interruptible would break everything. > > Why? Obviously, you'd need to check the result of the inode_lock(), which I > didn't put in my very rough example code, but why would taking the lock at the > front of a vfs op like mkdir be a problem? Plenty of new failure exits to maintain?