From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB5DC47DB3 for ; Fri, 2 Feb 2024 04:05:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F23B76B0088; Thu, 1 Feb 2024 23:05:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EAAAF6B0089; Thu, 1 Feb 2024 23:05:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD7196B008A; Thu, 1 Feb 2024 23:05:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B5A496B0088 for ; Thu, 1 Feb 2024 23:05:16 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5D3954026F for ; Fri, 2 Feb 2024 04:05:16 +0000 (UTC) X-FDA: 81745523832.27.AF3C16B Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf28.hostedemail.com (Postfix) with ESMTP id AAE0AC000D for ; Fri, 2 Feb 2024 04:05:14 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=pIco9+AE; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706846714; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zprcRbdEZTEbzRJzXIqOfmdBLyrHEeb0z5ZjrW+eJjk=; b=Jk78PCr8MW/zPbNiINZggG5mpeYc1JTkNBkCROukW0JLdrUBLumzZau3p2NKgBbfP1upJL S2Tc142NX3cOBO1bsh3tEJq+cobTSf0Vo19nigyj0litiG6KH0SnMXdr+fe3D2JH4p18UJ PMbmeYQjF19TVlhTyr8MyFO8Y1T2hPs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=pIco9+AE; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf28.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706846714; a=rsa-sha256; cv=none; b=lmVmu+a4sSGm337fr/DchnF/guNkp5qpW45gcxrpm6sWkCIpLyjoB/gUXdkVzQ5SRWnSDW CuL5IpdHzuEiF/FwKyQDoq9W8g+Avs0Hb5BiIxYpiqIPi78gCwIQrZ4XbwuYKpl5hoIi4s EsbqOOS95TGxplIStywHf1Rz1clWl8w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zprcRbdEZTEbzRJzXIqOfmdBLyrHEeb0z5ZjrW+eJjk=; b=pIco9+AEcGpi1eJkqd1+TWTTQ/ XggxqzL2w7JuIlqFb/qCdHy0ULmOVossWG+kEFJsaGwMh+RytusUgg82M15TvEDjlqwGslNf7cvUq sPt2Vassayxn3kWT9oVofZJaRl0DIN7pORLgWXb+9VTqqAlio+oguHQ5mP/B5DZuelRkEJdARnyFU m/G0i2qfxHjXcpG4x8OeVf8YUMVphbhJ7Uxp1eVbk/1W+xGbO+bqjutgFRWwu6i/wdiHFEvnCchz4 ZhCB1hItyVOF2KQdksSMyIe3+2vMkZTegZ2UOl9ci4kUZVIH/f16rNHViC/gdF6VL8VPSjwmx0o57 Hxxlk+WA==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rVknX-003e9i-0F; Fri, 02 Feb 2024 04:05:03 +0000 Date: Fri, 2 Feb 2024 04:05:03 +0000 From: Al Viro To: Doug Anderson Cc: Christian Brauner , Eric Biederman , Jan Kara , Kees Cook , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] regset: use vmalloc() for regset_get_alloc() Message-ID: <20240202040503.GX2087318@ZenIV> References: <20240201171159.1.Id9ad163b60d21c9e56c2d686b0cc9083a8ba7924@changeid> <20240202012249.GU2087318@ZenIV> <20240202030438.GV2087318@ZenIV> <20240202034925.GW2087318@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240202034925.GW2087318@ZenIV> X-Rspamd-Queue-Id: AAE0AC000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: adgiuorkttaqic7cuawm5rb99bx648re X-HE-Tag: 1706846714-464716 X-HE-Meta: U2FsdGVkX18bbCueRPJxATVBF3LlWBRT2NZTIRX1LqB/GbsNdEmtVyZz7XklHEcBAt6g9pEo/PXJ6AA0Gf+85QHMfn9bV0u2itPYCNKzSIGaIS9Jv0u6ORibqgB1Sl9aOpkSdoFHbxnnD2y/dtFqHCuVRQCK6YN/F4L/i6+wDhP3YGCgGwvEEDaVN4p2RaRv0wDYDsyJBN64oWQYhQc7R79rUfnAgiJMcA9La45LGSC7uxxxDHCM37bOWgBvZVjVd8A8cuvI+MX5N4SU/omgrE4yInIij8a9MN+YHubpFY1NnZ3QDDsH6tYkWJxunVYJoHMNj6b9LHlK53eDvgT92k2ixICxH2F1OCWxLKKKREHG9rPLGnnkBoJgnyZXMPTz7O56JFIYxR2os6DPFgxzq+pvynoUOrJIpHNarlxL8XEZq51sMUEg9f8zw0kW5Y7knSqpmEMSrDAUa+HlC/yhbprSP69FMEPVatG/mMFY/ezciXjGXO2bj7oY7Ml6fboLwsus9WNPXuqdXaH6w8HNhuBPb2l9XJPi5G8ttVm8zXZX7/+t9Ym1CSFM6dqBoB0TfFaSc4Pua3HBO7fjv95WmYTKQzLXttoTrxsDAtt8Mxjc9ZBuif0PnwoupEF7rySAhzZL6pJxemBQrfkUZ2NzcQbKKJgBzV0tjn0AOrLRT9ewP3HkLKR5dA5CvaHDXYLC9NSYg/k9Vv9C2Ch82rc0WRCgr+fXYIyi3tJ1WPo6qXI9uyox27wuLfAXg8/iIaKfh3q9OrF4P+uYqFApXo0VRYT6J2MCCcshpMBFTVnoXGrK8EA2iYDaRxk5H0JGEk3JCEk/MvQgHCgjWYmBO/K2+ZFFwdsToRo+wwceCXIt3vhmK/aYR9Rr2vyRTmrNgQ3GHOI4pBPOaUIpvwN/wmG061gD6R7Zv7R8EAhMRGhk4/BQ8pRjwNTq4wD8BPBM992Q7y/fIaSX1tfyYbo4v23 +knGCmi2 ZChzbi8JhxR2cy5UqlCqWBXHYPF31ujRPYWgHdMWC2pDR1pSVnfmKlaEWbKb3KklHfL1QdJrVJD97xw+oypHNlzMmFMMMPaO5fWznSkYIzhG/RaHNfe6gR00t9NhFxYw4byLWm0FX5QBoDcTyuhJ0sJfKpCwmg7BnEP8uzLbuUM0Kgw3ilpkqtZa25yN8liR+83ggKfdcxAbbPo1/LiBKxi61lgD+6+6Qa2hWN64BJISMcKmLpWE00zR2ncCegcj5l8vdx3DZhz4S/TBxcxbbgVp5Nc6zzRXem+GHzPIlZlGOQ2gyTdak2X8ecRMoqty/gPw5hd2Z11cMwV15+LXWX7n7DHcA8/8Fw4PvHo2ELb7rn0YIWp2E8RsgRF8PMJpotftIYpVN47aQPC4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 03:49:25AM +0000, Al Viro wrote: > On Thu, Feb 01, 2024 at 07:15:48PM -0800, Doug Anderson wrote: > > > > > > Well, the next step would be to see which regset it is - if you > > > see that kind of allocation, print regset->n, regset->size and > > > regset->core_note_type. > > > > Of course! Here are the big ones: > > > > [ 45.875574] DOUG: Allocating 279584 bytes, n=17474, size=16, > > core_note_type=1029 > > 0x405, NT_ARM_SVE > [REGSET_SVE] = { /* Scalable Vector Extension */ > .core_note_type = NT_ARM_SVE, > .n = DIV_ROUND_UP(SVE_PT_SIZE(SVE_VQ_MAX, SVE_PT_REGS_SVE), > SVE_VQ_BYTES), > .size = SVE_VQ_BYTES, > > IDGI. Wasn't SVE up to 32 * 2Kbit, i.e. 8Kbyte max? Any ARM folks around? > Sure, I understand that it's variable-sized and we want to allocate enough > for the worst case, but can we really get about 280Kb there? Context switches > would be really unpleasant on such boxen... FWIW, this apparently intends to be "variable, up to SVE_PT_SIZE(...) bytes"; no idea if SVE_PT_SIZE is the right thing to use here.