From: Andrew Morton <akpm@linux-foundation.org>
To: Zhiguo Jiang <justinjiang@vivo.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v2] mm:vmscan: shrink skip folio mapped by an exiting task
Date: Fri, 2 Feb 2024 01:22:51 -0800 [thread overview]
Message-ID: <20240202012251.1aa5afbfdf2f8b3a862bced3@linux-foundation.org> (raw)
In-Reply-To: <20240131131244.1144-1-justinjiang@vivo.com>
On Wed, 31 Jan 2024 21:12:44 +0800 Zhiguo Jiang <justinjiang@vivo.com> wrote:
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -840,6 +840,13 @@ static bool folio_referenced_one(struct folio *folio,
> int referenced = 0;
> unsigned long start = address, ptes = 0;
>
> + /* Skip this folio if it's mapped by an exiting task */
> + if (unlikely(!atomic_read(&vma->vm_mm->mm_users)) ||
> + unlikely(test_bit(MMF_OOM_SKIP, &vma->vm_mm->flags))) {
> + pra->referenced = -1;
> + return false;
> + }
The code comment explains what the code does. This is, as usual,
pretty obvious from reading the code!
A better comment is one which explains *why* the code is doing what it
does.
next prev parent reply other threads:[~2024-02-02 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 13:12 Zhiguo Jiang
2024-02-02 9:22 ` Andrew Morton [this message]
2024-02-02 9:36 ` zhiguojiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202012251.1aa5afbfdf2f8b3a862bced3@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=justinjiang@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox