From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0E8C48286 for ; Thu, 1 Feb 2024 23:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A72A56B0083; Thu, 1 Feb 2024 18:12:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A224D6B0085; Thu, 1 Feb 2024 18:12:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 911226B0087; Thu, 1 Feb 2024 18:12:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8334D6B0083 for ; Thu, 1 Feb 2024 18:12:01 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 298511C1877 for ; Thu, 1 Feb 2024 23:12:01 +0000 (UTC) X-FDA: 81744784842.22.BABF511 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 1B2FB1A0007 for ; Thu, 1 Feb 2024 23:11:58 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AaZk5H0/"; spf=pass (imf19.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706829119; a=rsa-sha256; cv=none; b=4Gtui4vKLpwsEX0BLQGjbNaiaZCAlUUEqBhdBEwOQUZK1ylP0rkSn0lu+tCyCknnl4LWw8 pWxeC6OsAe3fdQNh4Ht2u/UjbxE745ZMYTerSZC5+ODpYwj6MFtPQmLUqQcjTewsI65MIO DQDfMxxHKJewumvCsCu1cNip8FIJ/sc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="AaZk5H0/"; spf=pass (imf19.hostedemail.com: domain of ebiggers@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=ebiggers@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706829119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PnBh+I7o7XsGAONUZIDSbHAQUbMqMln/AYdsfRnnmc8=; b=gqYMB3oG+8Ij49DoYSKkL0rEgBXNgPOYig0MYn/ABkCNDX5KivIRSUTWIAtYm7FHwd5UtA Ixx/F4ZGTEZWQzXE5LFajmPxG+ASkmDBkDmmyjhs2R2IPptGkDc7G0NNv5MkDlEjrMMKwL Czd2Na1uiMSOgitzkdpKuoIYE/1WkBk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 476EACE18D3; Thu, 1 Feb 2024 23:11:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7286C433F1; Thu, 1 Feb 2024 23:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706829113; bh=bBckTHlnwRsnRIxBqMozm+cZDPwPFIOZVqpGpVOkEzM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AaZk5H0/y6XdJGc4OBWVBMIwflsWjW30D87R9aF2R5qDGHmZ/z2we5N4MzBIrJFgF R5GBGDR7lW9s/UVvZTQHUc9QyeySw8JS0MWMOrhJ+bDJqL0JmCbZTjrvJtYd5aCjcd LUgGf5meauGwQZQApm1WH74dN3nvnP6W7aRWRpiJhDPnDtiz2hSWL5OpiznHQ37nbD wYSckxDrnb7zqrVkPiu0NQDmKVE4SX9JiW622OqGZo950/xIyea3UlNhRV3yV+IVys dUsQEy9ROIZvqV2QYJDHIHr68kP9FTz4s5ngo9FPRnrWcTwu/zV4MPxWJuAMEqWaPK DULEFWyzhXJgQ== Date: Thu, 1 Feb 2024 15:11:51 -0800 From: Eric Biggers To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Subject: Re: [PATCH v8 2/4] mseal: add mseal syscall Message-ID: <20240201231151.GA41472@sol.localdomain> References: <20240131175027.3287009-1-jeffxu@chromium.org> <20240131175027.3287009-3-jeffxu@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240131175027.3287009-3-jeffxu@chromium.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1B2FB1A0007 X-Stat-Signature: fb7nkowp7bh6qur66j89xxgo4eorrdce X-Rspam-User: X-HE-Tag: 1706829118-901449 X-HE-Meta: U2FsdGVkX1/5Pzm2LsEx6GlULZBQf0Nit9PnueoLjbBoHWJahpFn4zlrgqSn0m+b0WAOX7o1ZMJqAc6/9oZ2c3hs/8xFrDB/Ftw/V5jYmRHGNx9c5beCZTEvqQR9YubM5iDoBfOp+XGsNlWMkrNG+hOnekLz5Qsfw/wkEd2UBmSLU+7AqT+H9yn0Goi67dxd8nQBXEcfrwcAKNhJW5Zi+eI/sfM6uVmngRJtqeE7gxUXARC4JgI6fg68UHNmSgwgP0kzAOhRFbWr/9JVTKe2XxG+ltl92mH7g1ZnGVMUk0KOR1VcAom4E1FIO856JC1plhQO1uMUvMpo0ckVC2LrL5Tmyw17gKAgAeKeNJNDxBUrI2Kfap/tZzvPJHely2/kZ2LfWtNMOYR4hhutOOLpo7TEBDfl33RmrqoBmtgMrvU04TfoGGkWPxko67lfohX5zl5ba5s2YV9WtXPuQ/yxbuSkRNmOZXSjSVxl3qD3z9G63Q2EXp9KJsGjzZlsvqXkZ4UINdcWhMCfWkIZpsAoXfYmw+HRx/fbMcWttuOjEKYsVmRbuFGmb9rA/KHXNMzu4xdMJKYOYdaILa63Yimk+b3DR/9NLxKzQEcS4XlNr+a6N+OP9TA0Y9+0W0GPJmveJQ544rUUlFrNkqSoGGEHbsRbXq9ZQjuBfkvWFZTWDFbT8On7F/RbEb4TdjkSbF31dcAaVjdIW8kc9RL+jypXfA9eOr5NM4Hk2ArPmzEHnwcZo6XhW1KtG8C9SkJfG+qVCy4mumEfw1rqjeo/K+WJi8iA4kAtbmQN5PDWtTgYZvJLDn6KBr+61x7sTV1j3LB2rDlHpX+O36hi16tHaAciRCHuqIPtgc1kGcJ47EtEfrVLaCC44lHGGRYsWgTeJYdnwXMzMx3DiCBh+F34t8gW75oSnQbsIiB493nkgvpPijNqatdm04geeqK7WbbuqmeR4wQGlbnYmatsJa3yjfn L+93yses pUEp2tJ1uvfh4TTNb5PB318Yp+f34QFO5bqzBJVT+Q5xMr943ikU5LFepybD1sTZ/4Vw1Ru+I7B0tDNCgGe21SUDUu/CGlgibGxwI506k5tmX4SMR5Z4gUNpqKOQUI6vdizeKFveiRx9GXLqKGM9umZFR09iZNMsDpn+ww6Lh2Kodeo/HWuqmzUFWy68ZrOuDjqPY9qDOhRIvFeZ4PG1j+S1f6B6g12dTQmF1BmWawAfqeQXnbqAk7uioBHY5UHb5F5c1ypWn5weJPuLi+WiaeKa2jw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 31, 2024 at 05:50:24PM +0000, jeffxu@chromium.org wrote: > [PATCH v8 2/4] mseal: add mseal syscall [...] > +/* > + * The PROT_SEAL defines memory sealing in the prot argument of mmap(). > + */ > +#define PROT_SEAL 0x04000000 /* _BITUL(26) */ > + > /* 0x01 - 0x03 are defined in linux/mman.h */ > #define MAP_TYPE 0x0f /* Mask for type of mapping */ > #define MAP_FIXED 0x10 /* Interpret addr exactly */ > @@ -33,6 +38,9 @@ > #define MAP_UNINITIALIZED 0x4000000 /* For anonymous mmap, memory could be > * uninitialized */ > > +/* map is sealable */ > +#define MAP_SEALABLE 0x8000000 /* _BITUL(27) */ IMO this patch is misleading, as it claims to just be adding a new syscall, but it actually adds three new UAPIs, only one of which is the new syscall. The other two new UAPIs are new flags to the mmap syscall. Based on recent discussions, it seems the usefulness of the new mmap flags has not yet been established. Note also that there are only a limited number of mmap flags remaining, so we should be careful about allocating them. Therefore, why not start by just adding the mseal syscall, without the new mmap flags alongside it? I'll also note that the existing PROT_* flags seem to be conventionally used for the CPU page protections, as opposed to kernel-specific properties of the VMA object. As such, PROT_SEAL feels a bit out of place anyway. If it's added at all it perhaps should be a MAP_* flag, not PROT_*. I'm not sure this aspect has been properly discussed yet, seeing as the patchset is presented as just adding sys_mseal(). Some reviewers may not have noticed or considered the new flags. - Eric