From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A99C4828D for ; Thu, 1 Feb 2024 17:51:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 395616B0083; Thu, 1 Feb 2024 12:51:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 344386B0088; Thu, 1 Feb 2024 12:51:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20C036B0089; Thu, 1 Feb 2024 12:51:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E7A76B0083 for ; Thu, 1 Feb 2024 12:51:34 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D505714051A for ; Thu, 1 Feb 2024 17:51:33 +0000 (UTC) X-FDA: 81743977266.03.B52C4E8 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf27.hostedemail.com (Postfix) with ESMTP id D547E4000F for ; Thu, 1 Feb 2024 17:51:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="0vH/fnOn"; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706809892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+kYGSxw/0pVUP/NyhqBrFQ2NZRrfK98HK4WLJcKdinM=; b=kDVtFvVHxiiE+1+Jl1K5VVJ7BK1ukc2v0AtP+GoA4ikxRPT+TxgRKxmSxD1POQ5IliD/mu ibrTnZohF/6ftXV4N70ei5EDN6/E9wZAdxI/ltPh19wbIHk94UKsEGFcyIQL146rw/PaNE AAjur6UcEU51LVJYxuNRT1A5vADS2nY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706809892; a=rsa-sha256; cv=none; b=Mw0fz+3Oc25hI0ti5eh0DpqZ0xOhwWsSt0EdvxuBqgHIezkHWlctCmECP0AsQJ7wkgmUuQ fnIqV9gswmf7aH3Fn1Q1G7bHK6GPPxv+ovEhHFaXE9IZIr1BhNikoyCPgjvMehweB+BtFs zM4T/M8tb2X62hV/YMCaEDVWPfLq6rg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="0vH/fnOn"; spf=pass (imf27.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-42ab7522bf6so5745181cf.2 for ; Thu, 01 Feb 2024 09:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1706809891; x=1707414691; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+kYGSxw/0pVUP/NyhqBrFQ2NZRrfK98HK4WLJcKdinM=; b=0vH/fnOndMvVc1ozE8oJC3gH/sl8z/M1TYn3LfOVBRashbfeMO4D5St8EPb+wpvkdg mb4BhCM3i4pMljtGkaivBm8vytAxH7Di15UbLChVOBO5UCtv8CbsRmLAPJfppjwMIAnT Tx5FJ6j5Ujur66mgOEy1ktekosHWbgXIaR4CBLRjTmCq62NnbcnVnGEw4zVlisD9g7rj OKcCFELXIIumI8UeES4K3AXGyFilyYSigG6AcF1+gai94T0TtpMe3/0StFYtU7sx5umq 5N0uXMQWc/i7q1BUOZIIoqCX5IBIw9Jaolfsqt+VC4TkDrbntWKxrMN0WRyLahdjNI2I X1Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706809891; x=1707414691; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+kYGSxw/0pVUP/NyhqBrFQ2NZRrfK98HK4WLJcKdinM=; b=jy6igNylNbOPUfPcfFVX8MhGRbjkG0Kc6oDbmlLwao1afsau5ZOxDslJ7yXkPzfW+6 LFri6IUQg7lcZluxMR+aBmDHaGff15JKJzzue4HMl5gLhzK3syUKH96av1NuLdKcJaV3 vajYWqHLh4SaCqgpdxm1KmpOA731OKqaXikInfN6ROsKxo3b/lX4wH+22iKV3AHsnLJ9 FoCBz4IOIvYFiECo0vrVV8atZrccKQUapDDF9LbZBuQ0KGoBNXdp0DbbfV4fqT4P5rF2 T7zMl/oaAxKVXEwXP/qmBIfWC51syjJ3vm0gGS5aQ7gHRXw5Y3pOHhcS0zPvxZPJFRev EOkQ== X-Gm-Message-State: AOJu0YwZuqmvxygpgSToVIe9sFbMMXilwLRj5LVYam/NoSP3QzHVex28 EW1xSfydEPiMmCfwbjcnfTbpqz0AWWMUacp0VmAXZ18yKCnVxRMJRQx2TqoSWgU= X-Google-Smtp-Source: AGHT+IF3A1lcUaOO7c/lXY8rz6yXdT7JmIfZvX2NMfbAV/K3cYMuofPlp/431nTYuUvv1HHt9ylzRg== X-Received: by 2002:a0c:c983:0:b0:68c:8208:cf71 with SMTP id b3-20020a0cc983000000b0068c8208cf71mr1141501qvk.31.1706809890854; Thu, 01 Feb 2024 09:51:30 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVxL/p9RoDdK1QuEUqqCFrZbiGpc/objavleFeu1lUXhFE0Lriynlt6mqRwAOppkCw3yWo9iZSRj8bc7qPwyU4t9K+mBpdIG26EVkKMPlYYcK+om5I+Re1tq7E/saShNKa8tfv0MP/fNb36owlQMYlIFNPNKjbRK0B/zeySfvcHQBcyz1kJNXtRfCGN6ZFRMRmaPw== Received: from localhost (2603-7000-0c01-2716-97cf-7b55-44af-acd6.res6.spectrum.com. [2603:7000:c01:2716:97cf:7b55:44af:acd6]) by smtp.gmail.com with ESMTPSA id dp2-20020a05621409c200b00686a22aeafasm3857272qvb.18.2024.02.01.09.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 09:51:30 -0800 (PST) Date: Thu, 1 Feb 2024 12:51:29 -0500 From: Johannes Weiner To: Chengming Zhou Cc: Nhat Pham , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/6] mm/zswap: stop lru list shrinking when encounter warm region Message-ID: <20240201175129.GC321148@cmpxchg.org> References: <20240201-b4-zswap-invalidate-entry-v1-0-56ed496b6e55@bytedance.com> <20240201-b4-zswap-invalidate-entry-v1-3-56ed496b6e55@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201-b4-zswap-invalidate-entry-v1-3-56ed496b6e55@bytedance.com> X-Rspamd-Queue-Id: D547E4000F X-Rspam-User: X-Stat-Signature: z6rc6ew5gc8nu413yiai3hbqtsx56b9h X-Rspamd-Server: rspam03 X-HE-Tag: 1706809891-88247 X-HE-Meta: U2FsdGVkX18qHpaWu201gv9W4f2sGfyriFRfbAosxr14L3YpT7UvaneWG6eU8OT2bzknfZtfbLk36RU0hcGXxexb+BE5ctZ7V3lgslWI27NXJfOX6JrBE68PnCaEUETDlmDwSCQDCiQcJ++/Ca0OWenojLCZipAO6n+ipabsy8fSxfF5FfcQsmvjzr9Q4c/9LCorX8cx6h4dMGwcP0cp6PnQ0A2mLZXNDOZUhjJw4T3SfHxUrst9A/5IxbCUdXMkM5CxiZoD5rf5GWzehCmL6CVFrHKIeLvcw5+xyjJM6arbucyE0oAsdD9xcPgQplVL7/esRo2h8Zm2Q6iy1tek//MOtGamLp2HP0ShzLL5VZSSwPse7NXs/PnFAud7MFg5U6C30MbIrvMXRWNLNt9ZZohfOmD5Wt4LHsij93rvvAB6nWxcru3IHj/OkLUOG5nu8cfXQg3OCEobI5HdBkKX8bWpVItwu+OjwbS2IQheXAukSGIeCZca3gq6rj85lrbBat2RNjAPXh5VNnR2CrQXAj5wnoplVTFW2JPoATLa4LQqbb8HoymKBqQZds3tdrDNbSlPHnGJGdgosqZZ1sA2WALnbABDvEKR1mr8zpkMUCgBV36EXEU428AScDcFXmpcWRBrqGEh4X7B5bJINRn2XAZhiVgwQ+6t+/EgONIDBxgbY9FDA/r7uXPJSGgd4Ml9xV46ObkJszCj6noDOpLHWwkm73aGN5BUuI8fqacihpMg8ol5/mawYZFDPs/qyJfmm53AgCJPl0kukfpDyV9U0Aes7ublJ79NNN2anguKaEqP0ejx+13NgENjXfjDQeFPIdfmA7IBxrdw47eZko8SJEENjrNVDU1U/PROmeFpoyT/zZk/euRBrX15GQVc3d5y3ORUTASGd31XjcCscSbtBRccqFdIZYmXge77xhTzGwO3lC1gs1Rre1huWOeYAUWwlrYrZ799crHEo0DTSqa fX+uU8Sn +20oJhw03uC2ubhyPGNmLvigZOC41b0Pz3H8J/flYTAys6kZ1MeTTpq2twzjs2ATg/dO629FxGAhfwFOC+1fGIaZmfKOEhN5ZUlYK714lhGj36hYHp4ucnWyfjtRVrmJaJ5Csww9X75sloCqG4UOt5TgzKbeV1Y5OWiLcKtyvvmwoOTpbzoHbbTyLkx81B8habLXAx/ngcS0zxyjVC+dKGVTjuHIyAQvFBk5ZJi2bg62HrVKKFUBMtdNv//koYnsKb8K3KVf6aScMCeIytdzuve3gXXUnKqctyRp2L9sSzko7KV7gxVa62/RvWlhrY34x5xPKlEr88CCaz0h53fAXYxRwyeVs4fRCXwVGdKCvlLg/LRCbJRXJxbw1/iErGyCQLuM12LDSZRVU0L7wFTW0CmK3P8689Cm6MVG47W8iHO2iW9pKoC/6EU+zZn/DHlnH5Q5Lh6OC3HYHAsCa9L78bQouBPPJ1M33wfH4ZKyiBzwPn9OS9WIPfRFIVmYpCmZVs2V3QNdSZJsu6yu6w0fLc7Bl9AmUtpPE4kyN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000259, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01, 2024 at 03:49:03PM +0000, Chengming Zhou wrote: > When the shrinker encounter an existing folio in swap cache, it means > we are shrinking into the warmer region. We should terminate shrinking > if we're in the dynamic shrinker context. > > This patch add LRU_STOP to support this, to avoid overshrinking. > > Signed-off-by: Chengming Zhou LGTM. Acked-by: Johannes Weiner