From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30859C4828D for ; Thu, 1 Feb 2024 14:20:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 875C76B007E; Thu, 1 Feb 2024 09:20:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FE416B0081; Thu, 1 Feb 2024 09:20:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677E46B0083; Thu, 1 Feb 2024 09:20:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 516616B007E for ; Thu, 1 Feb 2024 09:20:43 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 207A9C0DDF for ; Thu, 1 Feb 2024 14:20:43 +0000 (UTC) X-FDA: 81743445966.16.0DAAE34 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf14.hostedemail.com (Postfix) with ESMTP id C7875100025 for ; Thu, 1 Feb 2024 14:20:39 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=PCKLKH2G; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf14.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706797240; a=rsa-sha256; cv=none; b=KpP3KGxmA1S3B4/uWI6PAX8sowLd2vY1F/JBZD9P1euJxdScMgbcI8zmc+MI/gZxI1ezMT LPZ3OY4CB9UV+SQOKclg6Emd0a8vnStGKOm16ZRQssMy6gEBbOE1SM/nv4meOeV4JH2AK5 toG50zuBl4qtm+aoy0fontZ9q3FQtq8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b=PCKLKH2G; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf14.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706797240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/OhdUbt+2wIzO2wFvINMaC7euPQN8qk4saXMmk8Ewqk=; b=o850fXZ7pl4qWmRFVfbNzmNLaWPD944JT0lg1IWESJrGEo3MB1X1Y08ohMesUkftzScVPm 3Q56f0Qc4d0BKzWCGs4UbOKqetmmDLVJqLRXb+6W2w7z0Jwg+8sCpGvvTs9CRr+iqddNdZ WWQjeRtlpT0aZzb+WEXlQU2SRkFBUx4= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id A2BA140E01A9; Thu, 1 Feb 2024 14:20:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 88CsPpaq-GMn; Thu, 1 Feb 2024 14:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706797233; bh=xLdndXITEY495qtqbGzZcEEPT9mnJ0YIOGrS6BKjJaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PCKLKH2GkFT3YzrJ8zxsR7Ehs6Wl+PfNG/Dkdd7QMeybdYcaLVfX6ROGM2FM8DBbk pDmdTpb5pJMNFrVM3bhv+5mH2AWEa7s9Eo20bzpQ6+ZU+lDKmz3s9RWhlbe6eti1FG 7RQuRZwmEJhvftzGBIvW6P/lCNTx+mrfT/EwpcCYUWdsqMmGAXZYQg41/22/Tbflt1 U06MBKgX/d6yq9vauEkcPeB5++5fksDWecFa36Di4P2MISXL66lLnpL00scQSiEsl8 0fa2ZI/fuIl+s823oru494flUcBFsw1cZxFsmT9n0ectL4ylZVmnFM9NmcdAkff+aX hCAGks4QivkqDRcO6dxB6SuaYCYlYRVn+L/2PloWZm0L3JCc+k5BWTSImegkx5ijPc SZ9EwSSYSfz+u3u7HS8GnwGT9WsQwvkQKirwjANhNQFv2rC9rZ8nPJXh8QAX07UhQE vl+aCknAX4g3BXtku8hnEml4nARoZVt+isnROhC1t5EvdvwQzB7gB4qu1JAFA8UeqH 2eimCKBkVKMISn0JOu2xAnfMLipmuxfgkTTQG8JkiJy9T6ZYfIKDoCmyud8+GRaTCE 0Y1/t0JIqsPyfNnGBqv8vzBxC09bpR8gw5cs9iVzXww6lb3NzOHUPL5OLPu9QEEYk6 k7cwvBP7UQ5VEXHclrZ1IjG4= Received: from zn.tnic (pd953033e.dip0.t-ipconnect.de [217.83.3.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6C90940E016C; Thu, 1 Feb 2024 14:20:17 +0000 (UTC) Date: Thu, 1 Feb 2024 15:20:16 +0100 From: Borislav Petkov To: Tong Tiangen Cc: Thomas Gleixner , Ingo Molnar , wangkefeng.wang@huawei.com, Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Tony Luck , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-mm@kvack.org, Guohanjun Subject: Re: [PATCH -next v4 2/3] x86/mce: rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC Message-ID: <20240201142016.GFZbuooG9CRoK90U2C@fat_crate.local> References: <20240111135548.3207437-1-tongtiangen@huawei.com> <20240111135548.3207437-3-tongtiangen@huawei.com> <20240131070258.GGZbnwov0g918F-FGz@fat_crate.local> <3009aadd-69d6-c797-20b4-95cf926b6dd9@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3009aadd-69d6-c797-20b4-95cf926b6dd9@huawei.com> Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C7875100025 X-Stat-Signature: 6uggoksrnyk1es9yb14wn3qk7nkgks7c X-HE-Tag: 1706797239-320757 X-HE-Meta: U2FsdGVkX1+Egj6Z3JdM9QyJOAP2X6ravMjvMLIvoF9sNx+Gyfa3vZW82Q96qihYZmeMGKbORLmzYvieAeqOJI/QzsUczd7ghWvz8KPp8yXQuo2BgDW6IRNkSFTUmWyueHM8Ix3LKIpOmCHoqB7hAiHaqSv1engqx7SLYczIpCdzJ77JxvSbv44qbYZlIWsFBUXSEJUeM7lo8eKx4YVhulgjMJWvzYVWjeePF2RLy3nLjtwYSslNDOUZoKnOBG17yluRDdeunz16oZ/G1t5PWkc9rQxSaBcWDtYPw/2E1ZgGwScb4p7dh7/8N+uMxhbbr3hF2mORKHolrUOB0FHrOa310usbEfZ3SkDpQ8nizud1wGm9IiseST5qTBBSelqSNYqaWysJvW7L7FhZDtEiveLavLtrvQckTkidDmirQrPrALes7RJOsk33S0NEEcDAzlX1fbNvbMe7LmYDgvrOmcSFCOefjwZX9NQhUqRY1s61dB0gaubPxH/KVFt4AWoBBsMCl2CS8VQzex6ajZ2+pcGXG0VHQSHCQJOQnR1lbWfHIjAsBfKqAZZoAZOT0yhUCVKvMikoHqwpndZLHrCzUSVYY4MyxBTuNckgbL+8LjVIK3sezsPWJ9/rjFn8O4+Y6jTzklFNS9B8wA0sY2NdrctNn/dMPj7kBsgrYurG1DOHTxAorHNQ13dKdfih97iYP/wmsIuiWNMd0Trg0N2imOO0F7Vev0g+a78tiVM0o7uiYbhiQPWLH3oqqX2R3kM1H1dV5Qe4YZ6Mk+OwchKEjY9OSqzY83fBF+itjuOuA2yvEw9fDn8tUNlPItUxVx7hi9ilYxBz00o3OMUT71ylfIjeMStiwisFBK7eJj3mc2bVEJIIOn9rtT7WcMfkrWkkO/rkpendrASJ5EjMa96sxp34poMYMCQXylkoUvSzk69sxGQn/vvRWljeVP0oGMaa8b2Jy/T4hIen3vKtFoq G8TYX8OX 00A/eM3ffF8EYArbn7WrK8Wgl6Fp6Tl1N2ACyGF+vN9gXyHDgg54KCo/6DkjX0G/OCNIqtvq6RxnYAGFZKfp8avK010U9gu8lewh3w4QkHj92bpuMbgEofbKleaBSZ1AWJkLHPELsylsD1swhQDcWg1uu6O6+nkpuPC9a6nH92dv1zayJSDypUwnVkTTm03TcHPOoz2Ocr+AvVPY/u2okmedmf1qMQw/VqZlnoCe4HK2y1tCWfrpWF/jI/K0Aa3cuI5S4jbaXByYdpgd0rg49kS/2J3UCwmmRwmdnbNmsyia7rmbdmNSI7eb7Sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01, 2024 at 07:37:25PM +0800, Tong Tiangen wrote: > =E5=9C=A8 2024/1/31 15:02, Borislav Petkov =E5=86=99=E9=81=93: > > On Thu, Jan 11, 2024 at 09:55:47PM +0800, Tong Tiangen wrote: > > > Currently, there are some kernel memory copy scenarios is also mc s= afe > > > which use copy_mc_to_kernel() or copy_mc_user_highpage(). > >=20 > > Both of those end up in copy_mc_enhanced_fast_string() which does > > EX_TYPE_DEFAULT_MCE_SAFE. >=20 > OK, how about this commit msg change? :) >=20 > Currently, there are some kernel memory copy scenarios is also mc safe > which use copy_mc_to_kernel() or copy_mc_user_highpage(), **both of tho= se > end up in copy_mc_enhanced_fast_string() or copy_mc_fragile() which doe= s > EX_TYPE_DEFAULT_MCE_SAFE.** >=20 > In these scenarios, posion pages need to be isolated too. Therefore, a > macro similar to MCE_IN_KERNEL_COPYIN is required. For this reason, we > can rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC, the new macro > can be applied to both user-to-kernel mc safe copy and kernel-to-kernel > mc safe copy. Maybe my question wasn't clear: why is that renaming churn needed at all? What are you "fixing" here? What is the problem that you're encountering which needs fixing? Thx. --=20 Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette