From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73027C4828C for ; Thu, 1 Feb 2024 13:52:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CED256B0087; Thu, 1 Feb 2024 08:52:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C75F96B0088; Thu, 1 Feb 2024 08:52:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEFDE6B0089; Thu, 1 Feb 2024 08:52:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9D1FC6B0087 for ; Thu, 1 Feb 2024 08:52:36 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6ED3840E1D for ; Thu, 1 Feb 2024 13:52:36 +0000 (UTC) X-FDA: 81743375112.23.18D2E18 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf13.hostedemail.com (Postfix) with ESMTP id 2953A20010 for ; Thu, 1 Feb 2024 13:52:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Wnr/ij3c"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ObB0qpuj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Wnr/ij3c"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ObB0qpuj; dmarc=none; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706795554; a=rsa-sha256; cv=none; b=4hYnlhJI9AgniAC6ammWvG1k210eJCF81Kp8I3FVMIWXmJYP0bL82Q/zFL7nsiCCZLgh/g +spRH4TtraSYTR/O12AeqM+f9avu9VhGy1coYcZKCtkO47qd8ozVtqljo7KXtTAQit8fm6 Be1AVLhz2xcEK1rYOYRvYogek3UGGXQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Wnr/ij3c"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ObB0qpuj; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="Wnr/ij3c"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ObB0qpuj; dmarc=none; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706795554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QXLAKSzHX3H7LPzmvOeu1w9fqDyHIC6pdFRLsbYn6qU=; b=AjVAsqMCk3iuZclLYamU+mqVsaZVKuyRmDwRqGfyGbyyV9xWxTpd46tZq0/Xrk/2BBeGle vdM9QEpfpNZN1w++cXNB2FMfkk5/CYXm7MoFPa1Iquk4Z1e/ys8mSsq9sxooXxA/TMdNW/ ASwVf/aDkNu85NlEvTdf6iKk700UpjM= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 25C8E2216C; Thu, 1 Feb 2024 13:52:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706795552; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QXLAKSzHX3H7LPzmvOeu1w9fqDyHIC6pdFRLsbYn6qU=; b=Wnr/ij3cMxbQLn1J5JeiEN3JP3xSrwMxBG7wen/9M+eXezXyuPZuf/P+usPZaJlgzx0vI2 dsT/79GLcdEicmUXpa7/V0nK09Y2hjYPAd3lDtcFYQB71aq0X7wUFladF7H7NutqtZrK8R bEN3lTZURBQtT6H1FUL5y/aAovSYJGM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706795552; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QXLAKSzHX3H7LPzmvOeu1w9fqDyHIC6pdFRLsbYn6qU=; b=ObB0qpujeoxkArOyrTmPv46kyZCeJVO+CPQl6xTZopBwm6HvYMYNwh+As6rGhyHXDogBoS buDTjdUv61uYcABg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706795552; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QXLAKSzHX3H7LPzmvOeu1w9fqDyHIC6pdFRLsbYn6qU=; b=Wnr/ij3cMxbQLn1J5JeiEN3JP3xSrwMxBG7wen/9M+eXezXyuPZuf/P+usPZaJlgzx0vI2 dsT/79GLcdEicmUXpa7/V0nK09Y2hjYPAd3lDtcFYQB71aq0X7wUFladF7H7NutqtZrK8R bEN3lTZURBQtT6H1FUL5y/aAovSYJGM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706795552; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QXLAKSzHX3H7LPzmvOeu1w9fqDyHIC6pdFRLsbYn6qU=; b=ObB0qpujeoxkArOyrTmPv46kyZCeJVO+CPQl6xTZopBwm6HvYMYNwh+As6rGhyHXDogBoS buDTjdUv61uYcABg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 185C313672; Thu, 1 Feb 2024 13:52:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ajPtBSCiu2XWSwAAD6G6ig (envelope-from ); Thu, 01 Feb 2024 13:52:32 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id A6C19A0809; Thu, 1 Feb 2024 14:52:31 +0100 (CET) Date: Thu, 1 Feb 2024 14:52:31 +0100 From: Jan Kara To: Matthew Wilcox Cc: Liu Shixin , Alexander Viro , Christian Brauner , Jan Kara , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm/readahead: stop readahead loop if memcg charge fails Message-ID: <20240201135231.tgnn7cnlmtqh5n4f@quack3> References: <20240201100835.1626685-1-liushixin2@huawei.com> <20240201100835.1626685-2-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2953A20010 X-Stat-Signature: 4zsqzm6jrpp86nczm8p54a3pz85yij3u X-HE-Tag: 1706795553-348994 X-HE-Meta: U2FsdGVkX18Eb1cgueW/U3mzXRcMUpV2d0fDUgS16UemAwBKv8eyRhjawWiHLZtqk+Pg6PyAbkoqUwkoMOxkbJ6OTO6xDIvoZ2ENGG0JbUko2lD9DwS8gY++AGNi2oeBLyohzIqd84IDRF9cxPCKy4BqrnvBCWUEwpC9ChS6Rar3fgLj1bBBWrhWTW17qi6x20Z5Oyhi7godFJolRdBFGRkeN8lKel1uaYGrAH00BScCN6ve//I6ASzcPNjzqFhF1sKuujBOw/+Ho5+oUUvp/lHhOgLKxAkmm/jv7UDsZvINGFkFOAB4+8GLTx+x8fxp99sF0POEJ96IT5ZJoFGvfEiLuDqBlN+JgmjPTpxlqjIwqXp6xrMcF5KsA0cHO3x6orIx1+JwAt48nxdgOWUPgxOYYgGdCCo1S0QPkiBKUL8NkEjjvgQk1XB2QNmu+kLpX93+GAXyhFFDRDHySjR3xyW6hsuPihjZsIz1rxE607vsE+Fe9ZHRxdQCTNx6fQSe0zKDKyN29BwlwqHAW1lj8lkpTTaST0bpuNV6LIDQOgS8bO7IcCvMaNKNPB+zd6jvMw7AMKzBw471s50PuoC2q/9w7amjIAaZcWj6qwfvuO/kAwLz4Y1RcK2RuHHsfQWb4juABySKWqsDTF7gp1Q8+l/8Rsq+RPLBpv6G3bGiwfYIWCiWjTtb7LmpWDtxUsah9NH19tPxBmfYbcB9SflMVy8YjrEoGfAx9xE5ciTGnuUrNO5YLgkyVHYyojO4ORRQuguHTv76IQLfCknYA51Ys1DA/6YK2zI44R3Fq6PSYmIMiFyZ6c20CuCr8B9xxUZpR289S7i13FDt3iFAzS+7JbaoBN9tOp6WGNoDBKS5+EnAwYL/UqOQzrTAGFTy+2UECjo5KdfQqruVnuneyUcx+bczja9jPRvqqN8wrQxwdFD1zGC1HmfwH96C5u6UbFuIJpYI5/v8gVOBV0rnn0B m1Zcailp ZWR/TnHcLKUpOxiuMEshc5aZY6rvDyNJUtkmlGkRnDOhHzAZuvI7CPzD6AmVD3jAN5wIocWFrugm2rsyO2jdlOAe+FxtWzPIe8UbtSvH4RiiAXe1mE0PYVQK5YpVTnjmTEcC2NxIhys0jueVDHick2Zplwxj5s8OTpSMQW2RANU0I41ArxlqI5/gelg47XwxfwFL3RipJlA/WX1a7WcI+LWNa2ArSQuWtf082tuwRi1xLrw0FvK+WUAa2ruW96yCa5DZ6HUryzr4m/AZEGA4MSk7qxQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 01-02-24 13:47:03, Matthew Wilcox wrote: > On Thu, Feb 01, 2024 at 06:08:34PM +0800, Liu Shixin wrote: > > @@ -247,9 +248,12 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > > folio = filemap_alloc_folio(gfp_mask, 0); > > if (!folio) > > break; > > - if (filemap_add_folio(mapping, folio, index + i, > > - gfp_mask) < 0) { > > + > > + ret = filemap_add_folio(mapping, folio, index + i, gfp_mask); > > + if (ret < 0) { > > folio_put(folio); > > + if (ret == -ENOMEM) > > + break; > > No, that's too early. You've still got a batch of pages which were > successfully added; you have to read them. You were only off by one > line though ;-) There's a read_pages() call just outside of the loop so this break is actually fine AFAICT. Honza -- Jan Kara SUSE Labs, CR