From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 620B3C47DDB for ; Thu, 1 Feb 2024 10:30:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A5516B0075; Thu, 1 Feb 2024 05:30:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5555B6B0078; Thu, 1 Feb 2024 05:30:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4439C6B007B; Thu, 1 Feb 2024 05:30:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3655C6B0075 for ; Thu, 1 Feb 2024 05:30:02 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E0834A1AA0 for ; Thu, 1 Feb 2024 10:30:01 +0000 (UTC) X-FDA: 81742864602.19.565AA95 Received: from outbound-smtp41.blacknight.com (outbound-smtp41.blacknight.com [46.22.139.224]) by imf16.hostedemail.com (Postfix) with ESMTP id 2A769180017 for ; Thu, 1 Feb 2024 10:29:58 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.224 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706783399; a=rsa-sha256; cv=none; b=jSe+JVeyTQ+5s3kkfc9hRSlwk6k5XKaL3eMJpuzzVOCE51VM5CgeDofyxZUS8km5G77tUd bXvEOFK/oxiQH0gDyeiFdFes9XfoKDsagBcT+g/+rH+i4Yz45cHxjWqrZzfSe63nqw5VL/ 9nbA0G6aXe0C7yst9/T8TRwldTNVcFA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.224 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706783399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ASXgWwY2X/TWVWHF1Drj5oI1NAhqL6j+kMZBjOBbCiE=; b=dRcWO3JIvhwdDq4c6vt1Y3JrLAXeyAxH3PQ5HzwDNgGDjn18f6bbICi8wFBdgScO9XgeC4 7u92k4xVgb+wDcmOXzOS1XHlUtvBlHSZ3Obc7HJ5cElzJlCom/vBKQmTwTQGHDfj1DNR/W c+bcTDgs4enEhBaawCWgVWK11re2GVA= Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp41.blacknight.com (Postfix) with ESMTPS id 58E132435 for ; Thu, 1 Feb 2024 10:29:56 +0000 (GMT) Received: (qmail 434 invoked from network); 1 Feb 2024 10:29:56 -0000 Received: from unknown (HELO mail.blacknight.com) (mgorman@techsingularity.net@[81.17.254.19]) by 81.17.254.26 with ESMTPA; 1 Feb 2024 10:29:56 -0000 Date: Thu, 1 Feb 2024 10:29:54 +0000 From: Mel Gorman To: Baolin Wang Cc: akpm@linux-foundation.org, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: compaction: limit the suitable target page order to be less than cc->order Message-ID: <20240201102954.e65g2q3twdtxhjzc@techsingularity.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2A769180017 X-Stat-Signature: 3ngp8t7izpnpy73pmwdkdup57d3mm1tu X-HE-Tag: 1706783398-892790 X-HE-Meta: U2FsdGVkX1/rZaupbKljQsgObzxGlDZx1ubVvb+mwqBhrsNVT2WWBHQLzA0spYG1ArOSV0nq5+Za1hPipCvGNuCB4oEou6pwsuAGUUz7PJMx1rNrbHXLmVvaEQhriKpuNkSZPa1ISzaMUXfrzblzkVKrN7KGClxPcu7b/6kVNlptjTmqViOqX+W0pf1S0s/yB6OYaKlXPUXPxBBWb8OHjwohOoNV492kvRC+IOpVuG1qpgQHc3NQrwuya+bXLaSgqEU8DClSui7xpKPyFPLrKjc/dInXEeG0EoNk0/GjhVw2/ijouwVApPVn6KRx4rUGAShLWniolD/5jS3psivmnK0ofGMrD+lhyn70PDHZt/JW6pd4cIp2oW3ILk5lsWW+RNew+C5bWj5d9rOk4/4bwAs1pGi6k8WjaU4bJB5XhM3TsVz2ZDIFfMjkPNmg/1LNb9bnwPwjWmGDzeoyl4UO6I19+9bzchg68OKa7whGGwd3/mXdQJ0dAsqyrc4Phg98s4hlNwo2UDMLvQytRzGVMTnO1y245XFZznD59cZTw5RAPzmSB+ZwI0wmxL9vpzD7xKkAzZNcBQsEf7s3sYAbzYrQc+f6Xh54LU/WMB/Ul+SY3tglmi+ZEpJ4D2s7kQ24Gog8Fdf8OLD4wzjrd+7aztx9fP99B10djE4MjDSVo46MzyPqZYjvYwBWxvKEXtx6Q6kHs4Y4ui+AJ0g1aqQM0DhxVTYHiYITmPYp4D10ky7WBWg7eMD/TQML3xh127qF8VM7UTzeuM96Gk4GJ3dm7QNabguuDpphuj37BB0wSQe6jEfsc7IkVbDfrzPpS05049totagjcM9+D/U1nwn19mGYmGG2ST7zje4vTW249a1DNuxw+lbAIk0nZuB9Wg9kC0/LLG0NgfG7NPQe4MeaQ2ZqgVJVW8DkKgjX3J9V4gHG8TaxPOoIBMA/r536hicj9o2hzUe+XYRS60VokJN r+2Gh68s wopP4ItxtL0kV94jBOjA8LNm0fleRykoKNr9v4lLymN01YzEhevylPmfvLYNZK3Q9OF5l5equG4iqBwE8k/1TjxZ/pHC5Ep1om2hGWqksFyQY9rmtrUb9A3/DBFcLIRyD58GpwAhlJmKTymrG7xUQjXIOD7ilGj4qpzh745spT3gncV+2hZiU+snUPLoF/Gty6+F5OpRVuOaCZT+4zFFYgQ99XIeADQ8ZcToV9hGHjW03ekgiEiHgFai9SQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 22, 2024 at 09:01:53PM +0800, Baolin Wang wrote: > It can not improve the fragmentation if we isolate the target free pages > exceeding cc->order, especially when the cc->order is less than pageblock_order. > For example, suppose the pageblock_order is MAX_ORDER (size is 4M) and cc->order > is 2M THP size, we should not isolate other 2M free pages to be the migration > target, which can not improve the fragmentation. > > Moreover this is also applicable for large folio compaction. > > Signed-off-by: Baolin Wang Acked-by: Mel Gorman -- Mel Gorman SUSE Labs