From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8018DC47DDB for ; Thu, 1 Feb 2024 09:28:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E76996B0081; Thu, 1 Feb 2024 04:28:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E26EC6B0082; Thu, 1 Feb 2024 04:28:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC7BF6B0083; Thu, 1 Feb 2024 04:28:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BD0EF6B0081 for ; Thu, 1 Feb 2024 04:28:16 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8D2581A0E28 for ; Thu, 1 Feb 2024 09:28:16 +0000 (UTC) X-FDA: 81742708992.21.4B36BCC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id 335B54001B for ; Thu, 1 Feb 2024 09:28:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EK1Xce2m; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ywSa7cRP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EK1Xce2m; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ywSa7cRP; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706779694; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5ZXgLLa0AgQAAzLt+5EkE3Qo2/vmJJ/AA1BTUNqnDIc=; b=PebjpMXuxlOKDCOY/3/0dyYOI8ryh7+xocrVIFOMmKQlsYDSSgVvpbAFvKwBBMrIsElDb7 JSGxZqQjozXlUMR/u3PTiq6a1Fv5gHE5ScO7dGCCVPHjH/xGmEkRi9Mrw3uT0IxG4/7G46 iS/XPNh6wd8qhzkSSBS8UgRap0mZ/zg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706779694; a=rsa-sha256; cv=none; b=hxwV6YJQ3L4h9EQusy1biWzUfvmdyckqOa5Y/RlWU5c3D20jmiquS/n++N1mnlfBVrWx8B Fhd1vRyPLj7qRm1dNRUh8PyqSSJAUktUVeIygS4SU6hvQJ7u2+C664Sb2zI1BS7IcTlhU0 lIXCoGiAnUDGbvMxbJAnH2Iqf24yvlk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EK1Xce2m; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ywSa7cRP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EK1Xce2m; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ywSa7cRP; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3F1E02205A; Thu, 1 Feb 2024 09:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706779692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ZXgLLa0AgQAAzLt+5EkE3Qo2/vmJJ/AA1BTUNqnDIc=; b=EK1Xce2mBq6yxLlhpfJlbluuhV5OslGE3Ihq9ykf96pXF7vJhk6atO/IXrz7yoZH4lkPQ0 cahd+9kJXp7PcDARqcqCi1l0kZ+qRxr7cs0B5VdUeF1/6JKo0Hl762DvbC3T4xYb+c3A8t 53PsZNMu4QDHVkC6lALalNs72sasIZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706779692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ZXgLLa0AgQAAzLt+5EkE3Qo2/vmJJ/AA1BTUNqnDIc=; b=ywSa7cRP+K5QgHKyokZsMb2v6/xI9DEvDMndE6k61NRtyyee4b3nrZrDVebWl4Jq+YAGyF EK7zD6pNtRQqx0AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706779692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ZXgLLa0AgQAAzLt+5EkE3Qo2/vmJJ/AA1BTUNqnDIc=; b=EK1Xce2mBq6yxLlhpfJlbluuhV5OslGE3Ihq9ykf96pXF7vJhk6atO/IXrz7yoZH4lkPQ0 cahd+9kJXp7PcDARqcqCi1l0kZ+qRxr7cs0B5VdUeF1/6JKo0Hl762DvbC3T4xYb+c3A8t 53PsZNMu4QDHVkC6lALalNs72sasIZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706779692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ZXgLLa0AgQAAzLt+5EkE3Qo2/vmJJ/AA1BTUNqnDIc=; b=ywSa7cRP+K5QgHKyokZsMb2v6/xI9DEvDMndE6k61NRtyyee4b3nrZrDVebWl4Jq+YAGyF EK7zD6pNtRQqx0AA== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 317B513594; Thu, 1 Feb 2024 09:28:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id LrYEDCxku2X+UQAAn2gu4w (envelope-from ); Thu, 01 Feb 2024 09:28:12 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id C935DA0809; Thu, 1 Feb 2024 10:28:11 +0100 (CET) Date: Thu, 1 Feb 2024 10:28:11 +0100 From: Jan Kara To: Liu Shixin Cc: Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm/readahead: stop readahead loop if memcg charge fails Message-ID: <20240201092811.ycoh2rekx4wagglc@quack3> References: <20240201100835.1626685-1-liushixin2@huawei.com> <20240201100835.1626685-2-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201100835.1626685-2-liushixin2@huawei.com> X-Spamd-Bar: / X-Rspamd-Queue-Id: 335B54001B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 91q7gdj3wsf6o134fdzg8kdnzodgrw87 X-HE-Tag: 1706779693-442449 X-HE-Meta: U2FsdGVkX1/9AYAIemI5uU3zU4mhtCK72EUdFrrfsm+okbPofXGUPk0NnsuY+McAj89+vFps/UXYn+ry7aeyD6/UluBOVSS3bbFx65NYef3B8PflrZrCKjAgFpQyBtyEMm9uWwiURMy9ZHpsrsMQeqqImhnXGd/xPS26juj5f2SDJom13g/r/NNZ+9de8vfYWJyvCQs7lHHXvjl4HZsla6Ac0WVRuAawzLEWZ4KTNEn4pHPu8AU/uWXw6Ps+2IzWqXagMUrvh6KSLM3BeedsREQ/AK3Y3Ff///5qPLxyDdfqT7G6bvjb9E66TyDuD0oIXAvbwa9dt8KuTBYR4YpeFy4X5HYAN1kirRGrC5igVGl4Q5PDe7po2LtEnAt3RQMaVVUmu7iJOC0PyKyixTnah9e1GOUozTOk992wuKh4sVCSMLUK121oA0EOxJ7kIFbojMP7tdpfK8t1XzJE6B+IPQ+BLGC6aEdozsrtkRy/WTiCFqttkN9nHL20QXmxtwVE3CFZhK2bc7g6ds2haWQDKOUbX8SyzmK5ii78k3Sb2Nsc+bfeiJmRCVfpYKoY5m3gfHxLYgDKpYT6vFQXYPicAVSLhjyehbwpV54Jdw44f7DaXjG7jCqLdqEiyRjWy6dsMcxCOFDOk4TdHcBmYnTbT3+BSRVluNlkWEGhRMYBAveZg7LKA0GdjgNQVi0dWFTJPKWqr2MqD56UwYoqN04s75ZExKBMMZgg3iX7CTuRBD32E1WAiGN+Vdc3I3/BNo0E9xLcO+Q8JSVgYO93tCdyQydkoySRtZ1YqF1YvCTN6brEWS8Y5hrL55RByXqVXXKsqypdcb1PM1zcf03A8l6EJ4dvfMB/Jz6ouX53ST6HgHy+AV/45b4ZLgESUVl2E7aLMYADxh8KKN52gd1H44tRlJ1iizsmXZjuajv6NJJqW0ASf1nB/eVr8VHNVOa8Q1a68kILSahoJStv8pUmnHN ZjbzAAl2 n9gdu0tvpNoGYERhGbOOT49oG8tMCK0hZ9NJ/LXlEr2zK5A9bMMqZkk6cVM3dRXHSAq12nfmh4NOEVnWGF1V+Bsa4lQplkHjShA+1PyDfWaaArzy2l6/R/phNJf0r9nBU4K5FaW7mHxySfXZQo0R7TwbAzBelIWhRzfgmewUVCG0SDWTS65b6Kvtcj53IXZ+/YwpcGQCf+Xv5zzGnFpuU+qE/JS/YZ1myKreqI26VuqMkrue/VqIpS54pmKauo+UH0k9poy7imO4bvCRf4N5tTEguBSu0QQs1vx2sfMPm7IKgSNg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu 01-02-24 18:08:34, Liu Shixin wrote: > When a task in memcg readaheads file pages, page_cache_ra_unbounded() > will try to readahead nr_to_read pages. Even if the new allocated page > fails to charge, page_cache_ra_unbounded() still tries to readahead > next page. This leads to too much memory reclaim. > > Stop readahead if mem_cgroup_charge() fails, i.e. add_to_page_cache_lru() > returns -ENOMEM. > > Signed-off-by: Liu Shixin > Signed-off-by: Jinjiang Tu Makes sense. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/readahead.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 23620c57c1225..cc4abb67eb223 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -228,6 +228,7 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > */ > for (i = 0; i < nr_to_read; i++) { > struct folio *folio = xa_load(&mapping->i_pages, index + i); > + int ret; > > if (folio && !xa_is_value(folio)) { > /* > @@ -247,9 +248,12 @@ void page_cache_ra_unbounded(struct readahead_control *ractl, > folio = filemap_alloc_folio(gfp_mask, 0); > if (!folio) > break; > - if (filemap_add_folio(mapping, folio, index + i, > - gfp_mask) < 0) { > + > + ret = filemap_add_folio(mapping, folio, index + i, gfp_mask); > + if (ret < 0) { > folio_put(folio); > + if (ret == -ENOMEM) > + break; > read_pages(ractl); > ractl->_index++; > i = ractl->_index + ractl->_nr_pages - index - 1; > -- > 2.25.1 > -- Jan Kara SUSE Labs, CR