From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D06AC47258 for ; Wed, 31 Jan 2024 22:20:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0D016B0075; Wed, 31 Jan 2024 17:20:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B95AA6B0078; Wed, 31 Jan 2024 17:20:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E8006B007E; Wed, 31 Jan 2024 17:20:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87F866B0075 for ; Wed, 31 Jan 2024 17:20:21 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 52131120946 for ; Wed, 31 Jan 2024 22:20:21 +0000 (UTC) X-FDA: 81741025842.01.53B3A09 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf05.hostedemail.com (Postfix) with ESMTP id 56C14100024 for ; Wed, 31 Jan 2024 22:20:18 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=emRQ=JJ=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=emRQ=JJ=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706739619; a=rsa-sha256; cv=none; b=wHaU+79paaojOav98czeH71q1yko7ba/1OgJh8Js59UNhFR91C2uMNa1yd7Wy91b6FpfOv wu17d/0aQ2hdJ3qSlA0APZaDUFZcKIzH46osibfWnvtruBAwBWmp0Q/7TW7VyBR1ZXs35x bkBLEXZhVUy+E145AYmHWRrRLs8jT5k= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of "SRS0=emRQ=JJ=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=emRQ=JJ=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706739619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references; bh=viLlGxnrYUyhaQ0+sXTRxpeLd/pY6fSXf0otFTMjiEE=; b=1AyRFvO/3qif8THOIfPzf/wOShpA6EviznK8EjJdmlSCtV6Apz0IMJgj4g1Wo/cAoxpBJw 9zKGS9ArKM8pLuQZEUtaozonV7oa/x38eu2GSAtJG3QA4BjPD/mvTNZWMUVGWNxjg4QQK9 3MPLzNMpicFzBAohHnh6fyw7aZgni8M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C2006CE237A; Wed, 31 Jan 2024 22:20:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 134EFC43390; Wed, 31 Jan 2024 22:20:12 +0000 (UTC) Date: Wed, 31 Jan 2024 17:20:27 -0500 From: Steven Rostedt To: LKML , linux-mm@kvack.org Cc: Andrew Morton , Linus Torvalds , Vlastimil Babka , Kees Cook , Christoph Lameter , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Do we still need SLAB_MEM_SPREAD (and possibly others)? Message-ID: <20240131172027.10f64405@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 56C14100024 X-Stat-Signature: gxhcq6twxig9sinrst3tksdpnwhswt5p X-HE-Tag: 1706739618-279763 X-HE-Meta: U2FsdGVkX195xQaSea/Z1CPqDf0yw2zFSogUprcR28HAt2aKWtta8tpuuoD+IVHmDgh20KA3eqz+F78q/Ju+36mIwnTYtS+JJyutFLqakwV6hWs8MuOlDD+0uLRihUBjG3zUp2pwE/P2OszsIt6KsztNlHN29cruwmvpyjdbAqY4+cbtOkJroTXHlmaRhySoV/O8FNy+CwoDKQW9Fo+/HX9r0iJjfT1RKQ/JGAqhQSohflP2WKKUSAX82tqUa3KrJJtisagEl6wtd1Fj5h4nC+fUe50HONnd1FAeaUhJwUIFH4voufGAfWgx8kymGshXNljbmXM6/6679O4CdxCrih6indo8Oa8cWzm0DztleP2EaWKgLH/aez4wFTPxo8nta8FriS8kwgjo6CHqFNWovCvOWH2rk7syeBGqIhfF/Bttq8a+UCwks6iSSK8IhfMDMhfT5vOkxsQpbhjFZuoJPDKikxT8CgDHkvNRR0qNuKNluxY1HDxAhskHMHtQbQm9yBeoUqfEZw0TMohUTMyL8FVE4Jilz9oGGDWJYFPrwgKom9IAYEqE8Lu61Q2oulOlC4a9OVwmj3Tn/mehvLPj1IhmcDVDUjH+OP7WygLbXFKqtod86NthdOoQWJx3bTnlVZ/jW2L5DV252OEAo3IodndDNqdGr0y4ARB5uDTcQFpFJzn2R3l2jwdONf9Nh9hha7UrVNZsP96Kku6X6R928dTaKnSAB5hKj0f656fgd7LccpQ5jKLLGuAZlt7NEu/4wFRDY3GJx+sFP46Jz5F3t9mwR/MnChhTht4/cgm7reEh+zjxkcKJG4JSirzm/+vQBK6i7fi2GAkrwLbGBAfyTlsBsWsXC2LXHT2+KRdldkYXy93TvN7SRgjhODxFFUKGuCS3ckJsWtPh5WtLGzNgV8ChDGRUvy5n0TzXEBs9PdG4jR2L2c/5NJfJ9vg95qHYi/3+bDJPdkR/TtpyO+g zhbvPrK/ 7XLFKgdv2ouGUVY5tfJghtQyp9ah+J14PppfoCzKEajpEErhaUnpUUJT5CprDDHxGECulAGotBBy2aYZ336IGX1WXSOYwMfCJho/K9Gnms3qerLEOpL/INodfQiOw9HaWIS9YwjryryTIU09+MS0W/1AIhUI0oLqKVi9RMt1G8q3rwLtZUUHVIrT3sjlVkg2KFv3t/gFgF6mumq5HckbyuqGvNuJJQbyxjXgKX4A+POdQLGQF7MS5xr2E9VsZlgbnI2/98kY0Aei1GJcvlbLaR6lF36N0Kqvk+q8tpuf1NyJx7eyof5Ymo3ZGHjOIuqmJHkWLUiRfcrAS9TuxxyFCGvwDHmW/xEXgEGbQp7CvX62FkBeT1KTG4Qj4CSaB2rIk4TXT22P8TB32Ky3r7vZI7Y8ylbcZZnjQKzQvVj+vJhP9b3pWahKXMCsw2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I was looking into moving eventfs_inode into a slab, and after cutting and pasting the tracefs allocator: tracefs_inode_cachep = kmem_cache_create("tracefs_inode_cache", sizeof(struct tracefs_inode), 0, (SLAB_RECLAIM_ACCOUNT| SLAB_MEM_SPREAD| SLAB_ACCOUNT), init_once); I figured I should know what those slab flags mean. I also looked at what others in fs use for their slabs. The above is rather common (which I probably just copied from another file system), but I wanted to know what they are for. When I got to SLAB_MEM_SPREAD, I found that it's a common flag and there's a lot of caches that just set that and nothing else. But I couldn't find how it was used. Then I found this commit: 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h") Which I think removed the only use case of SLAB_MEM_SPREAD. $ git grep SLAB_MEM_SPREAD mm mm/slab.h: SLAB_MEM_SPREAD | \ That's all I find in the mm directory. Is it obsolete now? Can we delete it? Maybe there's other SLAB_* flags that are no longer used. I don't know, I haven't audited them. -- Steve