From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B267AC46CD2 for ; Tue, 30 Jan 2024 21:40:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 322596B0075; Tue, 30 Jan 2024 16:40:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D26A6B007D; Tue, 30 Jan 2024 16:40:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14C096B0082; Tue, 30 Jan 2024 16:40:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 070626B0075 for ; Tue, 30 Jan 2024 16:40:13 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 89A8D140482 for ; Tue, 30 Jan 2024 21:40:12 +0000 (UTC) X-FDA: 81737295864.26.9E6B21A Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id 28C42100022 for ; Tue, 30 Jan 2024 21:40:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VMmDyszM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+R+8+Cbs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VMmDyszM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+R+8+Cbs; dmarc=none; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706650809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3uk8ksGjp+S/t97XadUwt9XprzXFLFr3a0kQ6HsH4bQ=; b=d/O3CQnBL6nSNrOat2nnn7QbR9efIpCn8noHIHmL8lHvbl3Lb2hwngswcovRynHr5QjjHv F72P9RA/xzMUFuQHvyzUPqYsgflLvzthdstej4D288th3NmPmg/ChOSwrjIXUeSVxdZOZj BanW32qKtBw0Ab5WDkgE8cNO1tm6nAw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VMmDyszM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+R+8+Cbs; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=VMmDyszM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+R+8+Cbs; dmarc=none; spf=pass (imf14.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706650809; a=rsa-sha256; cv=none; b=x60N0P2UmSbZFE+7gHauvKRkDMjt5dN0ysCXO8nh2eE4mvBdBWCLAfPwy6iNYgdfjKFtdm SlouA8GVvOd7jFXtPMbzrOcjfzQsfW0KqNFPCjlNKzuc6bG10KwiV8L8rRCO+Q/DiJhuA9 41//8tBdJmPGcFlPFWJtKMoMwh/TLYw= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 318E221FB0; Tue, 30 Jan 2024 21:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706650807; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3uk8ksGjp+S/t97XadUwt9XprzXFLFr3a0kQ6HsH4bQ=; b=VMmDyszMhOgX153e8Q8P/4Y6Zu/EvHkdqibK3Wn695Pt4esQqem/mEPDAzKsaQV8wJGauw BYmBM28clHZNiW3pDWwBU80fJ4imkfAaRltJXUwlnsNuT2IHr1n2V72gP68noR26ykm3Bx 5rZhB84BRj6vDXSqQisLDOHeL4yF+xs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706650807; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3uk8ksGjp+S/t97XadUwt9XprzXFLFr3a0kQ6HsH4bQ=; b=+R+8+Cbst92IRAezsU4YrXEpatYNOVUMJjIlxnw82J2D/fhIIM8m1bsjNlQsrkX7v9nE06 ECw0o38O4LKHYVBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706650807; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3uk8ksGjp+S/t97XadUwt9XprzXFLFr3a0kQ6HsH4bQ=; b=VMmDyszMhOgX153e8Q8P/4Y6Zu/EvHkdqibK3Wn695Pt4esQqem/mEPDAzKsaQV8wJGauw BYmBM28clHZNiW3pDWwBU80fJ4imkfAaRltJXUwlnsNuT2IHr1n2V72gP68noR26ykm3Bx 5rZhB84BRj6vDXSqQisLDOHeL4yF+xs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706650807; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3uk8ksGjp+S/t97XadUwt9XprzXFLFr3a0kQ6HsH4bQ=; b=+R+8+Cbst92IRAezsU4YrXEpatYNOVUMJjIlxnw82J2D/fhIIM8m1bsjNlQsrkX7v9nE06 ECw0o38O4LKHYVBg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 1BA5513462; Tue, 30 Jan 2024 21:40:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id PT9uBrdsuWWuGgAAn2gu4w (envelope-from ); Tue, 30 Jan 2024 21:40:07 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id A5D09A07F9; Tue, 30 Jan 2024 22:40:06 +0100 (CET) Date: Tue, 30 Jan 2024 22:40:06 +0100 From: Jan Kara To: Mathieu Desnoyers Cc: Dan Williams , Vishal Verma , Dave Jiang , linux-kernel@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org, Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Matthew Wilcox , Arnd Bergmann , Russell King , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/8] ext2: Use dax_is_supported() Message-ID: <20240130214006.qgqykoqm4c2pk4kh@quack3> References: <20240130165255.212591-1-mathieu.desnoyers@efficios.com> <20240130165255.212591-4-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130165255.212591-4-mathieu.desnoyers@efficios.com> X-Rspamd-Queue-Id: 28C42100022 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6r8a395c38qrmsdyri54u1jqronjg8oe X-HE-Tag: 1706650808-884945 X-HE-Meta: U2FsdGVkX19IdDxjLQN1RGXcpqsTz/0M7uQdsZh0eXxKgA/rtEmQiXRF013zS9/g2eA20RxpUYgkLAZjbQlA4AL2iQPtgWk0nZcpFrYpYCrBxML6kQSTyjIi8tK3Mx1GFoTeKy/vKOMTm03sDHcOqD8Jc3fQvAtsqrz+tR8arq+9C5JocNWZVFCYVlcqljqJMgu9RMVF5MBCUZICYwXcSXMtYIn0Zz9N+UwsCT27ELncNaQJ4ZBqn0gFwbALgBYi9HSR94MnFsCuiik8M3lmsTPrPc2FZ7qSKHN8jSdLbjlp0lrZDB3zIT8zPicub9Cm/O25K5042ZwbTScmfLkctYqZHr7O9nYr42Jb2AWjVTVrhjWLNgrviR7jV8zc/fDF9BFsYg2Bl85yvRMhiFtzKfU6SUVsMV4S1e1QwCBQsrOCNoLfInI8ReaZRU49RUEBZpH2hWpcgdXYyqyNPMNj79I3VsTqXeSZ/naPXd3V3t3kzuP6jf8ellV5FNetT2O6Qa2SbD9vwVN84JpjoetFd8gp2AZ9/PqVNpJN2WGuGr87kspfjWWz6oqISR0468gixib/lnQjtX+O2EV7tKu8zZHdobQdgEO1OFTBU6OHvckUDvHC0zNjE522oUJrWk+nNDcbuxS/F49gQHFTAwmQ2eTvlfGjVIlNBLKZ1OR7p2tUMpq1Sj1wxihmAr0QMJ/uT2+HBRK91MSdR9SQj4h4widWRb2i5SuVhr5h48/OhaTNUjE1dWdIsUJ8Zw132sXDDxQR2nBNCIWCJtFV98QZBKzd+diQI+hTVqPFMnpozKADEPp3qfNNE9C7WVXHoXNr4ExLZ2yL9dJM9+T+kEGjJ/rUXXnwxeHraT94yUSsOmB74c8u2DhpnHp2orqsdQfaHSLV9xXYgj3uCxq7NJUbux7ihpKeZZ6OyaXvqjzTBIb9gqo50ZRvgD8mIDaR9xwxEQ7umE0k9rQMK3++k1k I0wm/5WL uX1gd5EdjysbA1SY42WDG2H+HbTVyXRndzC+hO1yc4+0kmdjFRBzXbGAIg+UUPaM89oJfpik4Ev+32gcmOUe5NxkWEOgAPWh2g+FbusyVus0mK9pWQjNc+Zbp7BtPJxU0tV7yHyBFxK5sisyXy062pGEmPZAYC3bMF54m+j8Cvgv/Tc5dm22N1n0bICtGY3zDccC4KIqgMVig3iT5uzg8xjd+OB2ygTP1ElrBL0XtOFklOSqkSD3neROLzCoYThtwArQo4yBNIV80+qzkw7h6gkCvzig/DAneqEhRQF8KpoBi3LJBK4e5qjn4GU8nqQxXKNlEPPkb0GJApCi0BD6FTrINQPNmqjkBn5l4jbRjHuUWmW4Cq8YaDQh0HIOdCNPm/nW9xSSIcplwPTE4DAVEdvzdRrPBzsc1NtI9SwchNHOTcSFxFaOw5hpXKPN6nlbX7sjrQAo3RDz/aj53EjWOpS/AR5YQrmavLlk/n8cMNzFAny+EEtklrjK1D5RVCCTnBQjX6A37XGs15meNWuMJzPoAGJgOinYPOb/KHnhwkUf5t5LnNYBygmuaDSXKZOq7CCdkSN6aytaoTG8PTuDZsGjuHgUHCwGGKhriAcbRFlxP1H2/yhxd3+Z8M95RFgjtPdeJPyBJDa6y3yhjloI6F8dyfKADRazvuYGVPEKzt7O0fO85rnNPUho9kg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 30-01-24 11:52:50, Mathieu Desnoyers wrote: > Use dax_is_supported() to validate whether the architecture has > virtually aliased data caches at mount time. Print an error and disable > DAX if dax=always is requested as a mount option on an architecture > which does not support DAX. > > This is relevant for architectures which require a dynamic check > to validate whether they have virtually aliased data caches. > > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > Signed-off-by: Mathieu Desnoyers > Cc: Jan Kara > Cc: linux-ext4@vger.kernel.org > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: linux-mm@kvack.org > Cc: linux-arch@vger.kernel.org > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Matthew Wilcox > Cc: Arnd Bergmann > Cc: Russell King > Cc: nvdimm@lists.linux.dev > Cc: linux-cxl@vger.kernel.org > Cc: linux-fsdevel@vger.kernel.org OK, yeah, this is better than v1. Feel free to add: Acked-by: Jan Kara Honza > --- > fs/ext2/super.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index 01f9addc8b1f..30ff57d47ed4 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -955,7 +955,11 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent) > blocksize = BLOCK_SIZE << le32_to_cpu(sbi->s_es->s_log_block_size); > > if (test_opt(sb, DAX)) { > - if (!sbi->s_daxdev) { > + if (!dax_is_supported()) { > + ext2_msg(sb, KERN_ERR, > + "DAX unsupported by architecture. Turning off DAX."); > + clear_opt(sbi->s_mount_opt, DAX); > + } else if (!sbi->s_daxdev) { > ext2_msg(sb, KERN_ERR, > "DAX unsupported by block device. Turning off DAX."); > clear_opt(sbi->s_mount_opt, DAX); > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR