From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B6AC46CD2 for ; Tue, 30 Jan 2024 21:09:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C38A6B0081; Tue, 30 Jan 2024 16:09:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 573586B0082; Tue, 30 Jan 2024 16:09:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43BB06B0083; Tue, 30 Jan 2024 16:09:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 374296B0081 for ; Tue, 30 Jan 2024 16:09:50 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C6BB1140DB2 for ; Tue, 30 Jan 2024 21:09:49 +0000 (UTC) X-FDA: 81737219298.09.4E81786 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf02.hostedemail.com (Postfix) with ESMTP id 6F5A380026 for ; Tue, 30 Jan 2024 21:09:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b="PhEU/CIe"; spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706648988; a=rsa-sha256; cv=none; b=vb4jkTOnvlm/rOevh4XFBKXPCgMqVZ9a+Q2KWWcT3ctve3E2AgRB5C1rQOXGUL9f170Ge9 LftOTF114Aw/WqugXESeICSc0ga8nkLfhqq+zDOpR9fAhg2RM/9KP+MdLX3KU73PFGppC+ X+QUNZ/bxjKpD2/RlLInmlbBTj3ksYw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=fail ("body hash did not verify") header.d=alien8.de header.s=alien8 header.b="PhEU/CIe"; spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706648988; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qxvJh9OlK2TfsrykVRe+iMMQqnU9phwVzHJ0qccrQE=; b=zz4t5Xu85qyT6iIxdEClK73pRKChkqcdTkAaBjH9XlUaOgfAlRpBSXIXcb4EiTMlvemAZe DDA3x4bQHBZmOpQ17S1shlFoAO3sTFOSoJCV2KyB88HvgtG+LKUN+Gua9p+5yDRoexTqU4 1zGdFd6WoHgRM+E7G9vvOFdwRymtfNY= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 99EC440E016C; Tue, 30 Jan 2024 21:09:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9dtgCcRxuuf0; Tue, 30 Jan 2024 21:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1706648980; bh=bJPo8ARfu4bb/8etD558K4kEYcakH1/Jplzb9yO6z2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PhEU/CIeFKefePRNCVVfnWgqZ+oQ6NklARokqwCfUE0aHtDUx1IXqr6K7Bju1OxSF gupEOBS3x9s7wgo9mtgVZ8Y2waPTYE25PtuY/mOfjbJ9MBbiyy8N8BbqmbQ/AXbkNu rxI6MJgP2QqKIAQEk3uTF7bVGwwxWkLhBCrq7qf4muFbHbvagYwDGjJUrn5O/gPhSq PFH8NvDstTJMSv4X5tvxqKGqWHq1NkXHyDUIokv1TBAiArHgBpuSRMBr+CETIsJ1d9 12MWbc/0jGUX+SBC+tJ8ZG5gCqh2oyF2TAe2kYtvItwUjEGmStCOWP8z5DMyl58xnq zsO+hFeBG6PNAYHoIfwnNWK2/e0GEXJpt0uLL0+Zk0P5lVSkfM0S/QBRkc/we2Xc6h BsNgYiUgRP+p9QuQ3RSRGXxnsnkvWFJCEXTG+2MjSm3YOC1CVFa03z7RjBBiTO3ghn N6OxxrpNth4xe5aYmHV1FNmCbEx9BBZUQvB4Ga+T2STFvdf5aL+2q2ncS++O6Wsh3H abTLvLLlGlLZvYmgyPlEbHYh+g/tEWvNSn2uc8s2rrcssh6/7jEsTsGOAw46RUsBq8 PjMnQSUFRhoPLQVMZT7nE5C8LC8n6FvvMocE0EGNowEAp0z7StzlWaTBeaoL3l3ca0 Chk1ooHJth0OYnsINGlDovWg= Received: from zn.tnic (pd953033e.dip0.t-ipconnect.de [217.83.3.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id F2C7A40E00C5; Tue, 30 Jan 2024 21:09:23 +0000 (UTC) Date: Tue, 30 Jan 2024 22:09:18 +0100 From: Borislav Petkov To: Tong Tiangen Cc: Thomas Gleixner , Ingo Molnar , wangkefeng.wang@huawei.com, Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Tony Luck , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-mm@kvack.org, Guohanjun Subject: Re: [PATCH -next v4 1/3] x86/mce: remove redundant fixup type EX_TYPE_COPY Message-ID: <20240130210918.GFZbllfs4jUcd_QHL2@fat_crate.local> References: <20240111135548.3207437-1-tongtiangen@huawei.com> <20240111135548.3207437-2-tongtiangen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240111135548.3207437-2-tongtiangen@huawei.com> Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6F5A380026 X-Stat-Signature: 98g54ce8r7mts9zowxzgpt9y474hjzq9 X-Rspam-User: X-HE-Tag: 1706648987-41718 X-HE-Meta: U2FsdGVkX18zU8cmcHrps4EfhFtyR3fC4ZMZfuHPb4XCoS7R+ZzMOfHoeyDk0DFN0wAJwA3IQV8Dni92cyo3jENzJPaqVTaajBxuoGLl18Ojf0arQ3yw7Jyy5+mRKtkaf7oWSL7qBXyMY+q6IWX1e97EMWnj+9SgqKp+hvFMs3dpVxgAzjtP3i4o5Ib+vJq7Fm8ZmGgDuilk164Y4PlAkG8RK0XODvo6RDhjpIVUG3pSQjQpHJrH9kWLynIx53A3pq3rr8JB/et9ikVf+JV7HvDn2BNxEnWnprc1ntTIVXQADtaTEvWcp5Jjj5zgzzlgdae5/TOFztSB8QnG+rWAfWsxJbXrNFcGYlTCiH05hyw6qhJ9YPaYEc72AE4UJxTz/FiP9FFIIDS1aUqpbkW31YtantLqLfFLMAI7//HsIkEeJAa1u9PbD0p19Do1EAj6CH9nz1+byOBiY76tuXWDdLEQqYe3dwvZgnD62Hl9/X1pDwSoEO7GWqfSZyxYPUKGK+u+j/r/pFlo/LvqcuikO9Q9PUNo+3ZzyP4ZPmkcnaJIuol7S9Ldpgui4h8qsIycbQVG3Xe0uOyJ9DwxgnweT0i/WskmRv/8ODGDreQ20Y2FGaqlKRoh8zif/2GYQvzxqAPs8Q7K7JdXx0v2uDwY9sUqeKL5b180SapC897X9tKkwLe4rkoSv+g8V5hJ8Dx4HsV86RR07PNEFkPhqw+aZVP804zfM000yOo6MBX4NG2kt9/YwFCqFiEHAksapwooIDZ9+xhqJitN2yS1iomy75V9B9H19YqLu+hcFQXGfNukZ4vk7Zrq0ygltzOmnKCd39WaV/Kh7jAHLfQbzTurxowQa0wB4e5NIUmIr1tRdEaU+xRL+Bzih4BZ6lOpK3EhRj3U1F3CaVyXN9+0SUiWITzDLJ4jt4XeK8z454gjXpkkahAGJgeuvtdWYkRYTsbQo+2U2kLFGW9cCMcKQvA vhdDtXC+ 6KAesYEYaeCnNaSSfOtF1rQbcKAtGFqM3pQO6rwd5YuvtqbOH/JrSY/VoDljM4vkHHuLROi+ZUhjdGhODYxwx2TdN3y605EPsxdFy2BWDAGZ6Xa3DxywQMrtOO9ihmCu4gJwBRO38spqtCY5/coaSvvMcjXTA+wenIb4k1V3iQIgQep6jWTzsHYupgC9ot43rCrk3oSb7D0W214iIexCKRpTcmzl7lZZ9SMjD/93b+QxxVapne0FaQ507dYYdb/XyEf2jiuv6nB47aPDXowlIgkfl4aiSABC0Q8o6gWXPsI+F0RGfFNZhKtpLQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 09:55:46PM +0800, Tong Tiangen wrote: > In commit 034ff37d3407 ("x86: rewrite '__copy_user_nocache' function"), > rewrited __copy_user_nocache() uses EX_TYPE_UACCESS instead of > EX_TYPE_COPY=EF=BC=8Cthis change does not broken the MC safe copy for > __copy_user_nocache(), but as a result, there's no place for EX_TYPE_CO= PY > to use. Therefore, we remove the definition of EX_TYPE_COPY. Please use passive voice in your commit message: no "we" or "I", etc, and describe your changes in imperative mood. Also, pls read section "2) Describe your changes" in Documentation/process/submitting-patches.rst for more details. Also, see section "Changelog" in Documentation/process/maintainer-tip.rst > diff --git a/arch/x86/include/asm/extable_fixup_types.h b/arch/x86/incl= ude/asm/extable_fixup_types.h > index fe6312045042..787916ec1e12 100644 > --- a/arch/x86/include/asm/extable_fixup_types.h > +++ b/arch/x86/include/asm/extable_fixup_types.h > @@ -36,18 +36,17 @@ > #define EX_TYPE_DEFAULT 1 > #define EX_TYPE_FAULT 2 > #define EX_TYPE_UACCESS 3 > -#define EX_TYPE_COPY 4 > -#define EX_TYPE_CLEAR_FS 5 > -#define EX_TYPE_FPU_RESTORE 6 > -#define EX_TYPE_BPF 7 > -#define EX_TYPE_WRMSR 8 > -#define EX_TYPE_RDMSR 9 > -#define EX_TYPE_WRMSR_SAFE 10 /* reg :=3D -EIO */ > -#define EX_TYPE_RDMSR_SAFE 11 /* reg :=3D -EIO */ > -#define EX_TYPE_WRMSR_IN_MCE 12 > -#define EX_TYPE_RDMSR_IN_MCE 13 > -#define EX_TYPE_DEFAULT_MCE_SAFE 14 > -#define EX_TYPE_FAULT_MCE_SAFE 15 > +#define EX_TYPE_CLEAR_FS 4 > +#define EX_TYPE_FPU_RESTORE 5 > +#define EX_TYPE_BPF 6 > +#define EX_TYPE_WRMSR 7 > +#define EX_TYPE_RDMSR 8 > +#define EX_TYPE_WRMSR_SAFE 9 /* reg :=3D -EIO */ > +#define EX_TYPE_RDMSR_SAFE 10 /* reg :=3D -EIO */ > +#define EX_TYPE_WRMSR_IN_MCE 11 > +#define EX_TYPE_RDMSR_IN_MCE 12 > +#define EX_TYPE_DEFAULT_MCE_SAFE 13 > +#define EX_TYPE_FAULT_MCE_SAFE 14 You don't need to renumber them - all you need to do is to comment it out: /* unused, was: #define EX_TYPE_COPY 4 */ --=20 Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette