From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04650C46CD2 for ; Tue, 30 Jan 2024 15:52:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B9266B007D; Tue, 30 Jan 2024 10:52:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7685A6B0080; Tue, 30 Jan 2024 10:52:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6570D6B0081; Tue, 30 Jan 2024 10:52:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 556666B007D for ; Tue, 30 Jan 2024 10:52:06 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1B54212085A for ; Tue, 30 Jan 2024 15:52:06 +0000 (UTC) X-FDA: 81736418652.21.6F8A891 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf13.hostedemail.com (Postfix) with ESMTP id 265452000A for ; Tue, 30 Jan 2024 15:52:03 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=vpta12bn; spf=pass (imf13.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706629924; a=rsa-sha256; cv=none; b=AlBhRP91DjLlZBJAq91NXPLRMw4oj3LDp9uKVUUCxPxRd4dyXnCMRtE58dbvdEhdbbB5Nk 6jBt3Nlkjvfg4uzu3FJ1JctznnjntGaKSHvEgcCwOgKjulTrbzcMvR6+ZAdVR7jw2Vx4C9 iFgL4FU3J5FpEZNUD6+hJcLYYke1Fvk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=vpta12bn; spf=pass (imf13.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706629924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EDKgQ8EjVSjsSkLiWJDakoC4bVJBW8jYaW7ZEBGiuZg=; b=IbuimkCs855QFrDJfheabNxUFqPH+/oeq3RxabGwsqZ+USvB+H9C2aTucRCySPAjIwm5ZO dPnWrkmVx27KCCf4acCqp+QVvgEHp/cxxD53wd3fdja4J8sM9LMd1rqtqZLI2XVsKsMk7b zRwoMwniLpOeGSOItrpukIG4kViC+xs= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-42a99f34cc8so22646661cf.2 for ; Tue, 30 Jan 2024 07:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1706629923; x=1707234723; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EDKgQ8EjVSjsSkLiWJDakoC4bVJBW8jYaW7ZEBGiuZg=; b=vpta12bnxbpWREbF155GIW434DZ/20vtqliwCVXFeGaEnOYPYgmq3TTT865pkqQ34y fwpbSsrhvztxLYC01Dggz7mmi4pLRM5gzJnpp2dgsPKoV5j7B3Ikta1GpgmEWKY94TtK kJgbixJpjKrbzobOYiihakeNWhTURva+CL9ZXD9fWDfJ0wgC/QtY3rKHTHT4KKocTYVo FtMCpLi4H3BkoKi4V0c37zKMYwSMbbStdGMtEq0BLig1U5WWHfwfqXWnJzYJtoJctYkl 4tZYtp5v5fgZANBEbFuKVYoN2sNyrCybslc/Wuu0OtxCgrXMMzUkMSN1MCxNe3B6j0jn 4lzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706629923; x=1707234723; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EDKgQ8EjVSjsSkLiWJDakoC4bVJBW8jYaW7ZEBGiuZg=; b=tnBFIkx/RHIyuv2gS3fSX+RFlM5hARsZw0MGGqV8J3ZxrFczjsGSbdQS+7IkRx5pWK 7XfhizvGvuTkHnP4Bs25y3opYGbjeOXE+rqZlw/FEK17BN3Ex5aZyvCG7HCLLrkiIXKw FzFZVDptf5N2e5lV0zvwljlTvoM24oB9UoNSpp9ELnNFLa3pEO3emYdZ0PHSNEkiiNnW V48l3zC0AX+KWNvRwFq1B9CtmuZovcZMynr8M4MVGjc5EmwgmoeVin2kyjHKXLpUDbkD RBcQCWbpJrxb4ILmGf2qtjxt16DUlot3JoiBsUA/xOipRC8hXUnnqoYvo+Lp2Hoykauo BF4g== X-Gm-Message-State: AOJu0YznpW4yXRt4ZnoZ5epETpt+VZOfhnVyEypQLM52M9aA081gJJL4 SBQATF55t0wbgBeShv2/KHQ9o04pAUQpjdFY4pD4XfldKjMVGBv8sUerM9/+WJY= X-Google-Smtp-Source: AGHT+IHyXour5Y7pAwTZhV2ka4GDvuqw5YyY5jKAxx7XXZvnlw2JMJfhgFeiluhaq73ynDtXvaZtnA== X-Received: by 2002:ac8:5dcd:0:b0:42a:b176:1fde with SMTP id e13-20020ac85dcd000000b0042ab1761fdemr2821771qtx.73.1706629923104; Tue, 30 Jan 2024 07:52:03 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id bp43-20020a05622a1bab00b0042a0d455bdfsm4181160qtb.64.2024.01.30.07.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 07:52:02 -0800 (PST) Date: Tue, 30 Jan 2024 10:52:01 -0500 From: Johannes Weiner To: Sergey Senozhatsky Cc: Yosry Ahmed , Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/20] mm: zswap: cleanups Message-ID: <20240130155201.GC772725@cmpxchg.org> References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130122131.GA9406@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130122131.GA9406@google.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 265452000A X-Stat-Signature: 4asbdt6i3ijg36au99zmubzr7ptfz9pf X-Rspam-User: X-HE-Tag: 1706629923-464850 X-HE-Meta: U2FsdGVkX1+s2KwiCS0b44Q/UJhqpEQJ/vGmxMvJKRNWpcOtoHS8ADhCqbbEZ2hi7riGsSKiNDt4sECFurHgu18Oik5mnMO+2OIt+jUPln/KHuPnX0FmcB4ZUYszhN45uOmurmEO4xCQLpTynMa+aq3apajOS75ZsECUaGSatNX8qsYIA5p3koXqxGGIQcVy3YgJoRyXb/zSIJBGhxQW5Ad3CUbguLApriqguHf8Jr2HoQrbmZc4oQinCsflbaF70ONPne5jYrcVAabzdmJffXe3uj3dHMbqsjCFBUC5bL28GVd1F8AFaPViTd417vXXoAPHfHNYG0vB6Xv/WWdvfbj9uWkSfWnjRhTqreU5Bu6ti6WAviI6rMqJ/cAevnaACzcogL4ALBRVRh9TlwRy3SXXIs9O4wiw9Vd/Lnv4INZxHzca4g4zBmb3+05L8UmeK6sYi0NhYXH2QPZfEn/7bc5y+QlIz9RtfrqZsYEUE7eRMBR53Wif4NGMeRyYL8gcrl/Nz/aIQi5jH1zKhVCzj8rolQjbZPG80gGqwtSaRqF7MW7yomFwfPilW1k0HXQlxc/PWRkHSz7AV1VN9plK3joNnUtB99x/5CNlfbl3augOVyBH1QcRq+UgY4t0OesysY5yVwhvkym5p1qCLHgxCry8Tbym9f09jQFYYVUDTTBLZSXi/Ng+WmHVFAHq4s9VqDY837SBobf/aEei1DFV/iuFztv+msU1HSEgnD86PMeQjYUGxelGndytWH9JlVzSJm3X7UrpM4A5L+lWnNqVBqzelpjaHsYuYDzP2vi0wNV+FgDfD/yxoUeuu0NoKGCMagAs15h0uQHoBzSgP01qHg8wqwCVHMqHl6jOe5+AqfpY5OesGhFl4/xmDkpzhEAJBhxIR7bg8JmZ3NPi8vJc7vsRdockXdzyrZVBN82EQNU9HJLNcI1CVLIQC0g/fZ3jkQFq0cU8Qb49mfGDsPk 8NAq08Bd CMnsvLusgpoHI+lrTsHNTgecDNBua/eNSWCSdYS52urhyYhPbV21Xe6FPX9hPMcG67bB68XcVOAHl/Hcel8xkcb9R7Di0JRujBbXbmouwqAcfdT5dzMahSgoMaQwPzgNQUkgaLfj1iO8Ety4qwMfFwpXbtFR4pNOTRAq96NqlhZ0zmmfeeCk+KOHOCjvwlPdittqbuMlrwU8HtgF6sPQ0wMhda74CC/uxg950T+J0xylDZ5YWWs4Rhhes6BnwIV5Wz2vZzRTKWckED0R4iLcy6rdb0Oz50PmCQyNrcRpGVJE9xNdklYSBfQ2d4YAbW9S45vx0FJNxDi2+R9hjoE4snFZCrvq5oap5Our5pvsjj2WDrPqdk1oFCKjkIRKa0rWgd5wOZNfTd96mr0Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 09:21:31PM +0900, Sergey Senozhatsky wrote: > On (24/01/30 08:16), Yosry Ahmed wrote: > > Hey Johannes, > > > > On Mon, Jan 29, 2024 at 08:36:36PM -0500, Johannes Weiner wrote: > > > Cleanups and maintenance items that accumulated while reviewing zswap > > > patches. Based on akpm/mm-unstable + the UAF fix I sent just now. > > > > Patches 1 to 9 LGTM, thanks for the great cleanups! > > > > I am less excited about patches 10 to 20 though. Don't get me wrong, I > > am all of logically ordering the code. However, it feels like in this > > case, we will introduce unnecessary layers in the git history in a lot > > This also can complicate cherry-picking of patches to stable, prod, .etc I'm sensitive to that argument, because we run our own kernel at Meta as well. But moves are pretty easy. The code doesn't actually change, just the line offsets. So patch will mostly work with offset warnings. And if not, it's easy to fix up and verify. Refactoring and API restructuring (folios e.g.) make it much harder when it comes to this.