From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BAD1C46CD2 for ; Tue, 30 Jan 2024 11:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B9B56B0080; Tue, 30 Jan 2024 06:33:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 242CB6B0081; Tue, 30 Jan 2024 06:33:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06E696B0082; Tue, 30 Jan 2024 06:33:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E44716B0080 for ; Tue, 30 Jan 2024 06:33:43 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A2D4FC03A7 for ; Tue, 30 Jan 2024 11:33:43 +0000 (UTC) X-FDA: 81735767526.02.18437C8 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf05.hostedemail.com (Postfix) with ESMTP id 22A3B100021 for ; Tue, 30 Jan 2024 11:33:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WMHmAUIO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kCUu1BNm; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bEt7+Fb4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZN+0xaMa; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706614421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ul8XI1L/cZzOQhlwvI1+prP8LmIw3V5FpvNQXXSV384=; b=i/l2l5Xrv2icZYy7fP4ceFE8ZKqSAgoZFerCyaKTSE/HDF6t8mwC3ukS6DskD49b5S0JzW Ek67AP+b5T60FA7epLsdYdUUSfiVXhT9g3XNxX9KAXKBoU5n1uWzFiNuQKVRbfEQuaZfll UhXOK42+oSOI/1CvsDZrvh/lVkUSGJw= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WMHmAUIO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kCUu1BNm; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=bEt7+Fb4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZN+0xaMa; dmarc=none; spf=pass (imf05.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706614421; a=rsa-sha256; cv=none; b=1yh5vq6nzawbBTnKaLm+5aVIKPBCK0i84w7qEOMuXWAT4fua9PJOMtqMQ4zVggAvTlyfu1 /vkClo7Prc/kpfGhZbbK0ZaCl/KXgI8nUK8AN3iz0vl6dRPWEXIykYP6fYVI3oD/gc9e+X 5PxlW1pYJGzK+tbMY/5L/jP5xDreKdY= Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EBD8D222EC; Tue, 30 Jan 2024 11:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706614419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ul8XI1L/cZzOQhlwvI1+prP8LmIw3V5FpvNQXXSV384=; b=WMHmAUIOA7jXezAvq0ZkXKvyPhWYRVDv6j4CkOfdnTknst0pMIebKWOKs36pgauuGiThav 4acrlDq3WeGHd+huaR6pHDvE8bPYMFc4AMbLCDaIX6NM9KxohY3i5pTv+Q3DpNJ+Vb22GV m/GlA8vVgU5ZyaeZQdJmXSfimOZIL/Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706614419; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ul8XI1L/cZzOQhlwvI1+prP8LmIw3V5FpvNQXXSV384=; b=kCUu1BNm+2hjT4FskcjKJfLnyjAR22BERPd4NoVtsxfbAmqVrtwBy6Idg9dOpKpctlVkxW ioqf2Qe7qSRH/nDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1706614417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ul8XI1L/cZzOQhlwvI1+prP8LmIw3V5FpvNQXXSV384=; b=bEt7+Fb4F6iuZ2rG1MhIuzS/7eZbMXnhx+Wvwe5rxC0rdbM0s85/aC6UZufC7+BB9Tl23E aE9zv/1rzWgiyVfy151g+RHuv/mJ7ZPlKj+m/4P7P8DBQ/J2iift8xkLBFHsUZ+MfNLbyg gqm3Nwd/p27Y1Vhtqja3VmJEQdNIQHw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1706614417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ul8XI1L/cZzOQhlwvI1+prP8LmIw3V5FpvNQXXSV384=; b=ZN+0xaMaQHPUiTqxVr6sHBw3gfPjXpy8jPFBkfD9rZmxSpx+iUGYygPweVaUCf56A9k1nz gci3cDsnNWbLagDg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id D997C13462; Tue, 30 Jan 2024 11:33:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id MzMrNJHeuGWXDwAAn2gu4w (envelope-from ); Tue, 30 Jan 2024 11:33:37 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 7816AA0807; Tue, 30 Jan 2024 12:33:37 +0100 (CET) Date: Tue, 30 Jan 2024 12:33:37 +0100 From: Jan Kara To: Mathieu Desnoyers Cc: Dan Williams , Vishal Verma , Dave Jiang , linux-kernel@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org, Andrew Morton , Linus Torvalds , linux-mm@kvack.org, linux-arch@vger.kernel.org, Matthew Wilcox , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org Subject: Re: [RFC PATCH 4/7] ext2: Use dax_is_supported() Message-ID: <20240130113337.frem6a3y5n2iibnh@quack3> References: <20240129210631.193493-1-mathieu.desnoyers@efficios.com> <20240129210631.193493-5-mathieu.desnoyers@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129210631.193493-5-mathieu.desnoyers@efficios.com> X-Rspam-User: X-Stat-Signature: j1ghzhcbr79emat6p6ckhum638o6ir6m X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 22A3B100021 X-HE-Tag: 1706614420-574358 X-HE-Meta: U2FsdGVkX19OzfVWgqRIPEVSK9tpYSecWkOivUQ8ux38509gJxMtsububoCmIJ7k0HBw9aO2AojmO6DbKQ5hnExp7I6GiMJ5V2dUaenIIUazcYPuT+EURRhNhlksCPT3PjC0u9FXy9cvjr0T6wDvwEwVLuvtdq70578ZZ2tQXsaj5Bs6Udty8AelCd7TB8cQxPg8HnOiU2HE2XNFtsaakUSQpNvYhpOKK3xYk7iKVwc615ZByurOiuMmCMmXJl6Gl6TGWBzYUKk2TupE9ufJdhtduxpmpaDbkeT3mxsHRwdgKwIFs0RXpeWycVpTmZnMqLlMYu6IolJr0zSgLJEwkaSQwYpGQkv0tVpN+hDxWJaqcRxoiAb+iex3UfltX4fkYginWAajJf1VcjB0VaeD8AKPJ4oOSfJFvJQvvQyk2cxufAVgEGRNa64T7dB86cz/dgRStGsDVhtSTUjTEDeE2GJREhXmjNMWQYz94dJZsVGnmkuHbac+0kQZO032yRpTYM8dObSS0jYPkCpdzNy2TgSaBr4OSssmFDpA73e0sUooX1ibqM0GqvBLO0urjEvc0DxPXIO7ZBpE5LJjOeBB0jNNC3g8X1hP68Ord4eLy63BSzMcB7XKfKiiBQQKlNb3nnPg+N58RtXQEU30TBcJYFhxQCSbsGWku6lL3kQnGBI3DVhbTsruZf5ecGnoN9JiBXp/gru/SyxuRgfgaWjtRYAPAgXQ5F4Widu7PVQ/KPNtIXOtmPXUh2WUWcAqUk40wNOPUSE8fTMSvgU44RmWr5NcrhpMZoyLTq9L26W75jydDNCWPuS4v9r1GwVwSSJrC7GTvhi8QbZt02RQEDF9DLNso1AHOzG/XEksSa1AAKNT4dTaCdwQU8vwl6oJDC5YL7Q1ykg0cYtspxe6bfUzKzFg3Cs9DXl7i68lGSKIH3cVDcdV/tjmJsEdPbtqM+iB2HFR+xNWYK2HK92VzuD LJ0fvRvN sY46pEtuYtyRmaLVcCoGIyML0ZRUry1hz+b4XOALgAzX/itfUxgXkqQnxcMPqzAcIIaYd1McaWBAGDqHMa/5oQgKp/tuVNrOn2caAKs8WaMmppeEh3hczEf4GevUQuW69M/kb3aFsl73b7B8RCfDdo+6Z/+RRxXgglfkkch+CevxLnp7Eb3p1XtMFVu9sF6O5gdy5HS2caTG95U9AeUc4X3XUYdSXh00wqHB+eyx8GvETYdWStPK10tD6UZ3uQ97xG35IujHJd/MsKaY9xoaXfyvjWaedI+JXC8y+Aurga/Qk8YKgF0sceEAOgTYqRSXBXON704U2onQ1WOA0rQyk45/qddFLnPNGYfzSLlWJZL2Ge0bo0hx0BNfBtT5l0l4PqvztsN22oqJTpp7x9qphrXeRCCHZULOxaLZg0YUgJC5fC+Itxg5xoUJC95MmRDcsel9JcXs3LAcjCe3iQFSXwLFeLSqGzJ/kX5znRXW2z3jkQjiJr6GPbeXLajjAdUuUpZ35R0PGbS7+TY06SbZ5RO1pAE3Z66wesw504X9zHDdmCe3vl6sgFpJVOPUcvvMgvXfOff3Pn9dgdRJGSFhDiJt7bXyMC946TMxYUn8xN8xV5fugA+ZIfAj5lg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 29-01-24 16:06:28, Mathieu Desnoyers wrote: > Use dax_is_supported() to validate whether the architecture has > virtually aliased caches at mount time. > > This is relevant for architectures which require a dynamic check > to validate whether they have virtually aliased data caches > (ARCH_HAS_CACHE_ALIASING_DYNAMIC=y). > > Fixes: d92576f1167c ("dax: does not work correctly with virtual aliasing caches") > Signed-off-by: Mathieu Desnoyers > Cc: Jan Kara > Cc: linux-ext4@vger.kernel.org > Cc: Andrew Morton > Cc: Linus Torvalds > Cc: linux-mm@kvack.org > Cc: linux-arch@vger.kernel.org > Cc: Dan Williams > Cc: Vishal Verma > Cc: Dave Jiang > Cc: Matthew Wilcox > Cc: nvdimm@lists.linux.dev > Cc: linux-cxl@vger.kernel.org Looks good to me (although I share Dave's opinion it would be nice to CC the whole series to fsdevel - luckily we have lore these days so it is not that tedious to find the whole series :)). Feel free to add: Acked-by: Jan Kara Honza > --- > fs/ext2/super.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index 01f9addc8b1f..0398e7a90eb6 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -585,13 +585,13 @@ static int parse_options(char *options, struct super_block *sb, > set_opt(opts->s_mount_opt, XIP); > fallthrough; > case Opt_dax: > -#ifdef CONFIG_FS_DAX > - ext2_msg(sb, KERN_WARNING, > - "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"); > - set_opt(opts->s_mount_opt, DAX); > -#else > - ext2_msg(sb, KERN_INFO, "dax option not supported"); > -#endif > + if (dax_is_supported()) { > + ext2_msg(sb, KERN_WARNING, > + "DAX enabled. Warning: EXPERIMENTAL, use at your own risk"); > + set_opt(opts->s_mount_opt, DAX); > + } else { > + ext2_msg(sb, KERN_INFO, "dax option not supported"); > + } > break; > > #if defined(CONFIG_QUOTA) > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR